From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 1/3] drm/i915: Fix eviction when the GGTT is idle but full Date: Wed, 11 Oct 2017 13:05:02 +0100 Message-ID: <8b146a9f-d5bb-d520-f079-24345854c43c@linux.intel.com> References: <20171010213809.7752-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3CFDC6E651 for ; Wed, 11 Oct 2017 12:05:05 +0000 (UTC) In-Reply-To: <20171010213809.7752-1-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzEwLzIwMTcgMjI6MzgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBJbiB0aGUgZnVsbC1w cGd0dCB3b3JsZCwgd2UgY2FuIGZpbGwgdGhlIEdHVFQgZnVsbCBvZiBjb250ZXh0IG9iamVjdHMu Cj4gVGhlc2UgY29udGV4dCBvYmplY3RzIGFyZSBjdXJyZW50bHkgaW1wbGljaXRseSB0cmFja2Vk IGJ5IHRoZSByZXF1ZXN0cwo+IHRoYXQgcGluIHRoZW0gaS5lLiB0aGV5IGFyZSBvbmx5IHVucGlu bmVkIHdoZW4gdGhlIHJlcXVlc3QgaXMgY29tcGxldGVkCj4gYW5kIHJldGlyZWQsIGJ1dCB3ZSBk byBub3QgaGF2ZSB0aGUgbGluayBmcm9tIHRoZSB2bWEgdG8gdGhlIHJlcXVlc3QKPiAoYW55bW9y ZSkuIEluIG9yZGVyIHRvIHVucGluIHRob3NlIGNvbnRleHRzLCB3ZSBoYXZlIHRvIGlzc3VlIGFu b3RoZXIKPiByZXF1ZXN0IGFuZCB3YWl0IHVwb24gdGhlIHN3aXRjaCB0byB0aGUga2VybmVsIGNv bnRleHQuCj4gCj4gVGhlIGJ1ZyBkdXJpbmcgZXZpY3Rpb24gd2FzIHRoYXQgd2UgYXNzdW1lZCB0 aGF0IGEgZnVsbCBHR1RUIG1lYW50IHdlCj4gd291bGQgaGF2ZSByZXF1ZXN0cyBvbiB0aGUgR0dU VCB0aW1lbGluZSwgYW5kIHNvIHdlIG1pc3NlZCBzaXR1YXRpb25zCj4gd2hlcmUgdGhvc2UgcmVx dWVzdHMgd2hlcmUgbWVyZWx5IGluIGZsaWdodCAoYW5kIHdoZW4gZXZlbiB0aGV5IGhhdmUgbm90 Cj4geWV0IGJlZW4gc3VibWl0dGVkIHRvIGh3IHlldCkuIFRoZSBmaXggZW1wbG95ZWQgaGVyZSBp cyB0byBjaGFuZ2UgdGhlCj4gYWxyZWFkeS1pcy1pZGxlIHRlc3QgdG8gbm8gbG9vayBhdCB0aGUg ZXhlY3V0aW9uIHRpbWVsaW5lLCBidXQgY291bnQgdGhlCj4gb3V0c3RhbmRpbmcgcmVxdWVzdHMg YW5kIHRoZW4gY2hlY2sgdGhhdCB3ZSBoYXZlIHN3aXRjaGVkIHRvIHRoZSBrZXJuZWwKPiBjb250 ZXh0LiBFcnJpbmcgb24gdGhlIHNpZGUgb2Ygb3ZlcmtpbGwgaGVyZSBqdXN0IG1lYW5zIHRoYXQg d2Ugc3RhbGwgYQo+IGxpdHRsZSBsb25nZXIgdGhhbiBtYXkgYmUgc3RyaWN0bHkgcmVxdWlyZWQs IGJ1dCB3ZSBvbmx5IGV4cGVjdCB0byBoaXQKPiB0aGlzIHBhdGggaW4gZXh0cmVtZSBjb3JuZXIg Y2FzZXMgd2hlcmUgcmV0dXJuaW5nIGFuIGVycm9uZW91cyBlcnJvciBpcwo+IHdvcnNlIHRoYW4g dGhlIGRlbGF5Lgo+IAo+IHYyOiBMb2dpY2FsIGludmVyc2lvbiB3aGVuIHN3YXBwaW5nIG92ZXIg YnJhbmNoZXMuCj4gCj4gRml4ZXM6IDgwYjIwNGJjZThmMiAoImRybS9pOTE1OiBFbmFibGUgbXVs dGlwbGUgdGltZWxpbmVzIikKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNo cmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGlu dGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50 ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXZpY3QuYyB8 IDYzICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdl ZCwgMzkgaW5zZXJ0aW9ucygrKSwgMjQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V2aWN0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbV9ldmljdC5jCj4gaW5kZXggYTVhNWI3ZTZkYWFlLi5lZTQ4MTFmZmI3YWEgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZXZpY3QuYwo+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2V2aWN0LmMKPiBAQCAtMzMsMjEgKzMzLDIw IEBACj4gICAjaW5jbHVkZSAiaW50ZWxfZHJ2LmgiCj4gICAjaW5jbHVkZSAiaTkxNV90cmFjZS5o Igo+ICAgCj4gLXN0YXRpYyBib29sIGdndHRfaXNfaWRsZShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyBib29sIGdndHRfaXNfaWRsZShzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqaTkxNSkKPiAgIHsKPiAtCXN0cnVjdCBpOTE1X2dndHQgKmdndHQgPSAmZGV2X3By aXYtPmdndHQ7Cj4gLQlzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmU7Cj4gLQllbnVtIGlu dGVsX2VuZ2luZV9pZCBpZDsKPiArICAgICAgIHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu ZTsKPiArICAgICAgIGVudW0gaW50ZWxfZW5naW5lX2lkIGlkOwo+ICAgCj4gLQlmb3JfZWFjaF9l bmdpbmUoZW5naW5lLCBkZXZfcHJpdiwgaWQpIHsKPiAtCQlzdHJ1Y3QgaW50ZWxfdGltZWxpbmUg KnRsOwo+ICsgICAgICAgaWYgKGk5MTUtPmd0LmFjdGl2ZV9yZXF1ZXN0cykKPiArCSAgICAgICBy ZXR1cm4gZmFsc2U7Cj4gICAKPiAtCQl0bCA9ICZnZ3R0LT5iYXNlLnRpbWVsaW5lLmVuZ2luZVtl bmdpbmUtPmlkXTsKPiAtCQlpZiAoaTkxNV9nZW1fYWN0aXZlX2lzc2V0KCZ0bC0+bGFzdF9yZXF1 ZXN0KSkKPiAtCQkJcmV0dXJuIGZhbHNlOwo+IC0JfQo+ICsgICAgICAgZm9yX2VhY2hfZW5naW5l KGVuZ2luZSwgaTkxNSwgaWQpIHsKPiArCSAgICAgICBpZiAoZW5naW5lLT5sYXN0X3JldGlyZWRf Y29udGV4dCAhPSBpOTE1LT5rZXJuZWxfY29udGV4dCkKPiArCQkgICAgICAgcmV0dXJuIGZhbHNl Owo+ICsgICAgICAgfQo+ICAgCj4gLQlyZXR1cm4gdHJ1ZTsKPiArICAgICAgIHJldHVybiB0cnVl Owo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50IGdndHRfZmx1c2goc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmk5MTUpCj4gQEAgLTE1Nyw3ICsxNTYsOCBAQCBpOTE1X2dlbV9ldmljdF9zb21ldGhp bmcoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAJCQkJICAgIG1pbl9zaXplLCBh bGlnbm1lbnQsIGNhY2hlX2xldmVsLAo+ICAgCQkJCSAgICBzdGFydCwgZW5kLCBtb2RlKTsKPiAg IAo+IC0JLyogUmV0aXJlIGJlZm9yZSB3ZSBzZWFyY2ggdGhlIGFjdGl2ZSBsaXN0LiBBbHRob3Vn aCB3ZSBoYXZlCj4gKwkvKgo+ICsJICogUmV0aXJlIGJlZm9yZSB3ZSBzZWFyY2ggdGhlIGFjdGl2 ZSBsaXN0LiBBbHRob3VnaCB3ZSBoYXZlCj4gICAJICogcmVhc29uYWJsZSBhY2N1cmFjeSBpbiBv dXIgcmV0aXJlbWVudCBsaXN0cywgd2UgbWF5IGhhdmUKPiAgIAkgKiBhIHN0cmF5IHBpbiAocHJl dmVudGluZyBldmljdGlvbikgdGhhdCBjYW4gb25seSBiZSByZXNvbHZlZCBieQo+ICAgCSAqIHJl dGlyaW5nLgo+IEBAIC0xODIsNyArMTgyLDggQEAgaTkxNV9nZW1fZXZpY3Rfc29tZXRoaW5nKHN0 cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+ICAgCQlCVUdfT04ocmV0KTsKPiAgIAl9Cj4g ICAKPiAtCS8qIENhbiB3ZSB1bnBpbiBzb21lIG9iamVjdHMgc3VjaCBhcyBpZGxlIGh3IGNvbnRl bnRzLAo+ICsJLyoKPiArCSAqIENhbiB3ZSB1bnBpbiBzb21lIG9iamVjdHMgc3VjaCBhcyBpZGxl IGh3IGNvbnRlbnRzLAo+ICAgCSAqIG9yIHBlbmRpbmcgZmxpcHM/IEJ1dCBzaW5jZSBvbmx5IHRo ZSBHR1RUIGhhcyBnbG9iYWwgZW50cmllcwo+ICAgCSAqIHN1Y2ggYXMgc2Nhbm91dHMsIHJpbmJ1 ZmZlcnMgYW5kIGNvbnRleHRzLCB3ZSBjYW4gc2tpcCB0aGUKPiAgIAkgKiBwdXJnZSB3aGVuIGlu c3BlY3RpbmcgcGVyLXByb2Nlc3MgbG9jYWwgYWRkcmVzcyBzcGFjZXMuCj4gQEAgLTE5MCwxOSAr MTkxLDMzIEBAIGk5MTVfZ2VtX2V2aWN0X3NvbWV0aGluZyhzdHJ1Y3QgaTkxNV9hZGRyZXNzX3Nw YWNlICp2bSwKPiAgIAlpZiAoIWk5MTVfaXNfZ2d0dCh2bSkgfHwgZmxhZ3MgJiBQSU5fTk9OQkxP Q0spCj4gICAJCXJldHVybiAtRU5PU1BDOwo+ICAgCj4gLQlpZiAoZ2d0dF9pc19pZGxlKGRldl9w cml2KSkgewo+IC0JCS8qIElmIHdlIHN0aWxsIGhhdmUgcGVuZGluZyBwYWdlZmxpcCBjb21wbGV0 aW9ucywgZHJvcAo+IC0JCSAqIGJhY2sgdG8gdXNlcnNwYWNlIHRvIGdpdmUgb3VyIHdvcmtxdWV1 ZXMgdGltZSB0bwo+IC0JCSAqIGFjcXVpcmUgb3VyIGxvY2tzIGFuZCB1bnBpbiB0aGUgb2xkIHNj YW5vdXRzLgo+IC0JCSAqLwo+IC0JCXJldHVybiBpbnRlbF9oYXNfcGVuZGluZ19mYl91bnBpbihk ZXZfcHJpdikgPyAtRUFHQUlOIDogLUVOT1NQQzsKPiAtCX0KPiArCS8qCj4gKwkgKiBOb3QgZXZl cnl0aGluZyBpbiB0aGUgR0dUVCBpcyB0cmFja2VkIHZpYSBWTUEgdXNpbmcKPiArCSAqIGk5MTVf dm1hX21vdmVfdG9fYWN0aXZlKCksIG90aGVyd2lzZSB3ZSBjb3VsZCBldmljdCBhcyByZXF1aXJl ZAo+ICsJICogd2l0aCBtaW5pbWFsIHN0YWxsaW5nLiBJbnN0ZWFkIHdlIGFyZSBmb3JjZWQgdG8g aWRsZSB0aGUgR1BVIGFuZAo+ICsJICogZXhwbGljaXRseSByZXRpcmUgb3V0c3RhbmRpbmcgcmVx dWVzdHMgd2hpY2ggd2lsbCB0aGVuIHJlbW92ZQo+ICsJICogdGhlIHBpbm5pbmcgZm9yIGFjdGl2 ZSBvYmplY3RzIHN1Y2ggYXMgY29udGV4dHMgYW5kIHJpbmcsCj4gKwkgKiBlbmFibGluZyB1cyB0 byBldmljdCB0aGVtIG9uIHRoZSBuZXh0IGl0ZXJhdGlvbi4KPiArCSAqCj4gKwkgKiBUbyBlbnN1 cmUgdGhhdCBhbGwgdXNlciBjb250ZXh0cyBhcmUgZXZpY3RhYmxlLCB3ZSBwZXJmb3JtCj4gKwkg KiBhIHN3aXRjaCB0byB0aGUgcGVybWEtcGlubmVkIGtlcm5lbCBjb250ZXh0LiBUaGlzIGFsbCBh bHNvIGdpdmVzCj4gKwkgKiB1cyBhIHRlcm1pbmF0aW9uIGNvbmRpdGlvbiwgd2hlbiB0aGUgbGFz dCByZXRpcmVkIGNvbnRleHQgaXMKPiArCSAqIHRoZSBrZXJuZWwncyB0aGVyZSBpcyBubyBtb3Jl IHdlIGNhbiBldmljdC4KPiArCSAqLwo+ICsJaWYgKCFnZ3R0X2lzX2lkbGUoZGV2X3ByaXYpKSB7 Cj4gKwkJcmV0ID0gZ2d0dF9mbHVzaChkZXZfcHJpdik7Cj4gKwkJaWYgKHJldCkKPiArCQkJcmV0 dXJuIHJldDsKPiAgIAo+IC0JcmV0ID0gZ2d0dF9mbHVzaChkZXZfcHJpdik7Cj4gLQlpZiAocmV0 KQo+IC0JCXJldHVybiByZXQ7Cj4gKwkJZ290byBzZWFyY2hfYWdhaW47Cj4gKwl9Cj4gICAKPiAt CWdvdG8gc2VhcmNoX2FnYWluOwo+ICsJLyoKPiArCSAqIElmIHdlIHN0aWxsIGhhdmUgcGVuZGlu ZyBwYWdlZmxpcCBjb21wbGV0aW9ucywgZHJvcAo+ICsJICogYmFjayB0byB1c2Vyc3BhY2UgdG8g Z2l2ZSBvdXIgd29ya3F1ZXVlcyB0aW1lIHRvCj4gKwkgKiBhY3F1aXJlIG91ciBsb2NrcyBhbmQg dW5waW4gdGhlIG9sZCBzY2Fub3V0cy4KPiArCSAqLwo+ICsJcmV0dXJuIGludGVsX2hhc19wZW5k aW5nX2ZiX3VucGluKGRldl9wcml2KSA/IC1FQUdBSU4gOiAtRU5PU1BDOwo+ICAgCj4gICBmb3Vu ZDoKPiAgIAkvKiBkcm1fbW0gZG9lc24ndCBhbGxvdyBhbnkgb3RoZXIgb3RoZXIgb3BlcmF0aW9u cyB3aGlsZQo+IAoKTG9va3MgbGlrZSBpdCB3aWxsIGZpeCB0aGUgYnVnIGFuZCBjYW4ndCBzcG90 IHRoYXQgaXQgaW50cm9kdWNlcyBhIApwcm9ibGVtLiBXYXMgdGhlcmUgYW4gaWd0IHdoaWNoIHdh cyBmYWlsaW5nIG9yIGFueSBidWd6aWxsYT8KClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8 dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK