Re: ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs

Mun, Gwan-gyeong
2019-02-21T18:47:41Z

On Mon, 2019-02-18 at 11:44 +0200, Jani Nikula wrote:
> FWIW these are all valid checkpatch complaints.
>
> BR,
> Jani.
>
> On Thu, 31 Jan 2019, Patchwork <patchwork@emeril.freedesktop.org>
> wrote:
> > == Series Details ==
> >
> > Series: drm/i915/dp: Preliminary support for DP YCbCr4:2:0 outputs
> > URL : https://patchwork.freedesktop.org/series/56059/
> > State : warning
> >
> > == Summary ==
> >
> > $ dim checkpatch origin/drm-tip
> > 646f25f459f0 drm/i915/dp: Support DP ports YUV 4:2:0 output to
> > GEN11
> > -:20: WARNING:TABSTOP: Statements should start on a tabstop
> > #20: FILE: drivers/gpu/drm/i915/intel_dp.c:6926:
> > + if (INTEL_GEN(dev_priv) >= 11)
> >
> > total: 0 errors, 1 warnings, 0 checks, 9 lines checked
> > 485e788bfeee drm/i915/dp: Add a config function for YCBCR420
> > outputs
> > bfebbc7e2acb drm: Add a VSC structure for handling Pixel
> > Encoding/Colorimetry Formats
> > 2b312268f5ba drm/i915/dp: Program VSC Header and DB for Pixel
> > Encoding/Colorimetry Format
> > -:44: ERROR:TRAILING_STATEMENTS: trailing statements should be on
> > next line
> > #44: FILE: drivers/gpu/drm/i915/intel_dp.c:4412:
> > + if (!intel_dp->attached_connector-
> > >base.ycbcr_420_allowed) return;
> >
> > total: 1 errors, 0 warnings, 0 checks, 93 lines checked
> > 317c3a0c98c6 drm/i915/dp: Add a support of YCBCR 4:2:0 to DP MSA
> > -:41: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the
> > * on each line
> > #41: FILE: drivers/gpu/drm/i915/intel_ddi.c:1740:
> > + * indicate VSC SDP for the Pixel Encoding/Colorimetry Format.
> > + */
> >
> > total: 0 errors, 1 warnings, 0 checks, 21 lines checked
> > 49b8aff26fa2 drm/i915/dp: Update pipe_bpp for DP YCbCr4:2:0 outputs
> > -:54: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV)
> > #54: FILE: drivers/gpu/drm/i915/intel_dp.c:1770:
> > + bpp = min(bpp, 3*bpc/bpp_divider);
> > ^
> >
> > -:54: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV)
> > #54: FILE: drivers/gpu/drm/i915/intel_dp.c:1770:
> > + bpp = min(bpp, 3*bpc/bpp_divider);
> > ^
> >
> > total: 0 errors, 0 warnings, 2 checks, 119 lines checked
> >

Thank you for guiding me.
I will fix all of warnings from Fi.CI.CHECKPATCH.

Br,
Gwan-gyeong.

> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx