From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd) Date: Thu, 25 Oct 2018 09:51:35 +0200 Message-ID: <8c956766-57ba-c6f7-405c-04a41ae926be@linux.intel.com> References: <823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <823eb7cc-ba7e-b816-1821-c73dfd4c70bf@googlemail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: =?UTF-8?Q?Christian_K=c3=b6nig?= , "Zhou, David(ChunMing)" , Julia Lawall Cc: "kbuild-all@01.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , Gustavo Padovan , Sean Paul , David Airlie , "linux-kernel@vger.kernel.org" List-Id: intel-gfx@lists.freedesktop.org Op 25-10-18 om 08:53 schreef Christian König: > Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing): >> Reviewed-by: Chunming Zhou > > NAK, GFP_ATOMIC should be avoided. > > The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire. Yeah +1. Especially in a case like this where it's obvious to prevent. :)