From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dhinakaran Pandiyan Subject: Re: [PATCH v3 2/3] drm/i915/psr: Move logic to get TPS registers values to another function Date: Mon, 11 Mar 2019 17:15:41 -0700 Message-ID: <8df961409d5f808234a9ba8980fae40dccc3b927.camel@intel.com> References: <20190305234734.19506-1-jose.souza@intel.com> <20190305234734.19506-2-jose.souza@intel.com> <20190311232802.GD24277@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD25389BA5 for ; Tue, 12 Mar 2019 00:15:43 +0000 (UTC) In-Reply-To: <20190311232802.GD24277@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi , =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE5LTAzLTExIGF0IDE2OjI4IC0wNzAwLCBSb2RyaWdvIFZpdmkgd3JvdGU6Cj4g T24gVHVlLCBNYXIgMDUsIDIwMTkgYXQgMDM6NDc6MzNQTSAtMDgwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YQo+IHdyb3RlOgo+ID4gVGhpcyB3aWxsIG1ha2UgaHN3X2FjdGl2YXRlX3BzcjEoKSBt b3JlIGVhc3kgdG8gcmVhZCBhbmQgd2lsbCBtYWtlCj4gPiBmdXR1cmUgbW9kaWZpY2F0aW9uIHRv IFRQUyByZWdpc3RlcnMgbW9yZSBlYXN5IHRvIHJldmlldyBhbmQgcmVhZC4KPiA+IAo+ID4gQ2M6 IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ID4g U2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5j b20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDU2ICsr KysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+IC0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwg MzMgaW5zZXJ0aW9ucygrKSwgMjMgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9wc3IuYwo+ID4gaW5kZXggODMxZjM0NWI0YWQ4Li4yZmEyZjRjOWM5MzUgMTAwNjQ0 Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+ID4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiA+IEBAIC00MzcsMzIgKzQzNywxMyBAQCBz dGF0aWMgdm9pZCBpbnRlbF9wc3JfZW5hYmxlX3Npbmsoc3RydWN0Cj4gPiBpbnRlbF9kcCAqaW50 ZWxfZHApCj4gPiAgCWRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfU0VUX1BP V0VSLAo+ID4gRFBfU0VUX1BPV0VSX0QwKTsKPiA+ICB9Cj4gPiAgCj4gPiAtc3RhdGljIHZvaWQg aHN3X2FjdGl2YXRlX3BzcjEoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkKPiA+ICtzdGF0aWMg dTMyIHBzcjFfdHBzX3JlZ3NfdmFsX2dldChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ID4g IHsKPiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZHBfdG9faTkxNShp bnRlbF9kcCk7Cj4gPiAtCXUzMiBtYXhfc2xlZXBfdGltZSA9IDB4MWY7Cj4gPiAtCXUzMiB2YWwg PSBFRFBfUFNSX0VOQUJMRTsKPiA+IC0KPiA+IC0JLyogTGV0J3MgdXNlIDYgYXMgdGhlIG1pbmlt dW0gdG8gY292ZXIgYWxsIGtub3duIGNhc2VzCj4gPiBpbmNsdWRpbmcgdGhlCj4gPiAtCSAqIG9m Zi1ieS1vbmUgaXNzdWUgdGhhdCBIVyBoYXMgaW4gc29tZSBjYXNlcy4KPiA+IC0JICovCj4gPiAt CWludCBpZGxlX2ZyYW1lcyA9IG1heCg2LCBkZXZfcHJpdi0+dmJ0LnBzci5pZGxlX2ZyYW1lcyk7 Cj4gPiAtCj4gPiAtCS8qIHNpbmtfc3luY19sYXRlbmN5IG9mIDggbWVhbnMgc291cmNlIGhhcyB0 byB3YWl0IGZvciBtb3JlCj4gPiB0aGFuIDgKPiA+IC0JICogZnJhbWVzLCB3ZSdsbCBnbyB3aXRo IDkgZnJhbWVzIGZvciBub3cKPiA+IC0JICovCj4gPiAtCWlkbGVfZnJhbWVzID0gbWF4KGlkbGVf ZnJhbWVzLCBkZXZfcHJpdi0+cHNyLnNpbmtfc3luY19sYXRlbmN5Cj4gPiArIDEpOwo+ID4gLQl2 YWwgfD0gaWRsZV9mcmFtZXMgPDwgRURQX1BTUl9JRExFX0ZSQU1FX1NISUZUOwo+ID4gLQo+ID4g LQl2YWwgfD0gbWF4X3NsZWVwX3RpbWUgPDwgRURQX1BTUl9NQVhfU0xFRVBfVElNRV9TSElGVDsK PiA+IC0JaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpKQo+ID4gLQkJdmFsIHw9IEVEUF9QU1JfTUlO X0xJTktfRU5UUllfVElNRV84X0xJTkVTOwo+ID4gLQo+ID4gLQlpZiAoZGV2X3ByaXYtPnBzci5s aW5rX3N0YW5kYnkpCj4gPiAtCQl2YWwgfD0gRURQX1BTUl9MSU5LX1NUQU5EQlk7Cj4gPiArCXUz MiB2YWwgPSAwOwo+ID4gIAo+ID4gIAlpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAxX3dha2V1cF90 aW1lX3VzID09IDApCj4gPiAtCQl2YWwgfD0gIEVEUF9QU1JfVFAxX1RJTUVfMHVzOwo+ID4gKwkJ dmFsIHw9IEVEUF9QU1JfVFAxX1RJTUVfMHVzOwo+ID4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0 LnBzci50cDFfd2FrZXVwX3RpbWVfdXMgPD0gMTAwKQo+ID4gIAkJdmFsIHw9IEVEUF9QU1JfVFAx X1RJTUVfMTAwdXM7Cj4gPiAgCWVsc2UgaWYgKGRldl9wcml2LT52YnQucHNyLnRwMV93YWtldXBf dGltZV91cyA8PSA1MDApCj4gPiBAQCAtNDcxLDcgKzQ1Miw3IEBAIHN0YXRpYyB2b2lkIGhzd19h Y3RpdmF0ZV9wc3IxKHN0cnVjdCBpbnRlbF9kcAo+ID4gKmludGVsX2RwKQo+ID4gIAkJdmFsIHw9 IEVEUF9QU1JfVFAxX1RJTUVfMjUwMHVzOwo+ID4gIAo+ID4gIAlpZiAoZGV2X3ByaXYtPnZidC5w c3IudHAyX3RwM193YWtldXBfdGltZV91cyA9PSAwKQo+ID4gLQkJdmFsIHw9ICBFRFBfUFNSX1RQ Ml9UUDNfVElNRV8wdXM7Cj4gPiArCQl2YWwgfD0gRURQX1BTUl9UUDJfVFAzX1RJTUVfMHVzOwo+ ID4gIAllbHNlIGlmIChkZXZfcHJpdi0+dmJ0LnBzci50cDJfdHAzX3dha2V1cF90aW1lX3VzIDw9 IDEwMCkKPiA+ICAJCXZhbCB8PSBFRFBfUFNSX1RQMl9UUDNfVElNRV8xMDB1czsKPiA+ICAJZWxz ZSBpZiAoZGV2X3ByaXYtPnZidC5wc3IudHAyX3RwM193YWtldXBfdGltZV91cyA8PSA1MDApCj4g PiBAQCAtNDg1LDYgKzQ2NiwzNSBAQCBzdGF0aWMgdm9pZCBoc3dfYWN0aXZhdGVfcHNyMShzdHJ1 Y3QgaW50ZWxfZHAKPiA+ICppbnRlbF9kcCkKPiA+ICAJZWxzZQo+ID4gIAkJdmFsIHw9IEVEUF9Q U1JfVFAxX1RQMl9TRUw7Cj4gPiAgCj4gPiArCXJldHVybiB2YWw7Cj4gPiArfQo+ID4gKwo+ID4g K3N0YXRpYyB2b2lkIGhzd19hY3RpdmF0ZV9wc3IxKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAp Cj4gPiArewo+ID4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkcF90b19p OTE1KGludGVsX2RwKTsKPiA+ICsJdTMyIG1heF9zbGVlcF90aW1lID0gMHgxZjsKPiA+ICsJdTMy IHZhbCA9IEVEUF9QU1JfRU5BQkxFOwo+ID4gKwo+ID4gKwkvKiBMZXQncyB1c2UgNiBhcyB0aGUg bWluaW11bSB0byBjb3ZlciBhbGwga25vd24gY2FzZXMKPiA+IGluY2x1ZGluZyB0aGUKPiA+ICsJ ICogb2ZmLWJ5LW9uZSBpc3N1ZSB0aGF0IEhXIGhhcyBpbiBzb21lIGNhc2VzLgo+ID4gKwkgKi8K PiA+ICsJaW50IGlkbGVfZnJhbWVzID0gbWF4KDYsIGRldl9wcml2LT52YnQucHNyLmlkbGVfZnJh bWVzKTsKPiA+ICsKPiA+ICsJLyogc2lua19zeW5jX2xhdGVuY3kgb2YgOCBtZWFucyBzb3VyY2Ug aGFzIHRvIHdhaXQgZm9yIG1vcmUKPiA+IHRoYW4gOAo+ID4gKwkgKiBmcmFtZXMsIHdlJ2xsIGdv IHdpdGggOSBmcmFtZXMgZm9yIG5vdwo+ID4gKwkgKi8KPiA+ICsJaWRsZV9mcmFtZXMgPSBtYXgo aWRsZV9mcmFtZXMsIGRldl9wcml2LT5wc3Iuc2lua19zeW5jX2xhdGVuY3kKPiA+ICsgMSk7Cj4g PiArCXZhbCB8PSBpZGxlX2ZyYW1lcyA8PCBFRFBfUFNSX0lETEVfRlJBTUVfU0hJRlQ7Cj4gPiAr Cj4gPiArCXZhbCB8PSBtYXhfc2xlZXBfdGltZSA8PCBFRFBfUFNSX01BWF9TTEVFUF9USU1FX1NI SUZUOwo+ID4gKwlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpCj4gPiArCQl2YWwgfD0gRURQX1BT Ul9NSU5fTElOS19FTlRSWV9USU1FXzhfTElORVM7Cj4gPiArCj4gPiArCWlmIChkZXZfcHJpdi0+ cHNyLmxpbmtfc3RhbmRieSkKPiA+ICsJCXZhbCB8PSBFRFBfUFNSX0xJTktfU1RBTkRCWTsKPiA+ ICsKPiA+ICsJdmFsIHw9IHBzcjFfdHBzX3JlZ3NfdmFsX2dldChpbnRlbF9kcCk7Cj4gCj4gSSdk IHByZWZlciBpbnRlbF9wc3IxX3Rwcy4uLgo+IAoKaW50ZWxfcHNyMV9nZXRfdHBfdGltZShpbnRl bF9kcCk/Cgo+IFJldmlld2VkLWJ5OiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5j b20+Cj4gCj4gPiArCj4gPiAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDgpCj4gPiAgCQl2 YWwgfD0gRURQX1BTUl9DUkNfRU5BQkxFOwo+ID4gIAo+ID4gLS0gCj4gPiAyLjIxLjAKPiA+IAo+ ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiA+IElu dGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=