From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 6/6] drm/i915: Add a cursor hack to allow converting legacy page flip to atomic, v3. Date: Tue, 13 Dec 2016 14:52:42 +0100 Message-ID: <8f0817c1-e0b1-ffe5-1eb2-a2e76ac66396@linux.intel.com> References: <1481204729-9058-1-git-send-email-maarten.lankhorst@linux.intel.com> <1481204729-9058-7-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Archit Taneja , Matthew Auld Cc: Intel Graphics Development , ML dri-devel List-Id: intel-gfx@lists.freedesktop.org T3AgMTMtMTItMTYgb20gMTQ6MDEgc2NocmVlZiBBcmNoaXQgVGFuZWphOgo+IEhpLAo+Cj4gT24g MTIvMTIvMjAxNiA0OjA0IFBNLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4gRG8gc29tZXRo aW5nIHNpbWlsYXIgdG8gdmM0LCBvbmx5IGFsbG93IHVwZGF0aW5nIHRoZSBjdXJzb3Igc3RhdGUK Pj4gaW4tcGxhY2UgdGhyb3VnaCBhIGZhc3RwYXRoIHdoZW4gdGhlIHdhdGVybWFya3MgYXJlIHVu YWZmZWN0ZWQuIFRoaXMKPj4gd2lsbCBhbGxvdyBjdXJzb3IgbW92ZW1lbnQgdG8gYmUgc21vb3Ro LCBidXQgY2hhbmdpbmcgY3Vyc29yIHNpemUgb3IKPj4gc2hvd2luZy9oaWRpbmcgY3Vyc29yIHdp bGwgc3RpbGwgZmFsbCBiYWNrIHNvIHdhdGVybWFya3MgY2FuIGJlIHVwZGF0ZWQuCj4+Cj4+IE9u bHkgbW92aW5nIGFuZCBjaGFuZ2luZyBmYiBpcyBhbGxvd2VkLgo+Cj4gSSB3YXMgaW1wbGVtZW50 aW5nIHNvbWV0aGluZyBzaW1pbGFyIGZvciBtc20ga21zLiBJIGhhdmUgYSBjb21tZW50L3F1ZXJ5 Cj4gYmVsb3cuCj4KPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBTZXQgcGFnZSBmbGlwIHRv IGFsd2F5c191bnVzZWQgZm9yIHRyeWJvdC4KPj4gLSBDb3B5IGZlbmNlIGNvcnJlY3RseSwgaWdu b3JlIHBsYW5lX3N0YXRlLT5zdGF0ZSwgc2hvdWxkIGJlIE5VTEwuCj4+IC0gQ2hlY2sgY3J0Y19z dGF0ZSBmb3IgIWFjdGl2ZSBhbmQgbW9kZXNldCwgZ28gdG8gc2xvd3BhdGggaWYgdGhlIGNhc2Uu Cj4+IENoYW5nZXMgc2luY2UgdjI6Cj4+IC0gTWFrZSBlcnJvciBoYW5kbGluZyB3b3JrIGNvcnJl Y3RseS4gKE1hdHRoZXcgQXVsZCkKPj4KPj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9y c3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNfcGxhbmUuYyB8ICA0NyArKysrKysrLS0tLQo+PiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jICAgICAgfCAxMzIgKysrKysrKysr KysrKysrKysrKysrKysrKysrKystCj4+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYu aCAgICAgICAgICB8ICAgMiArCj4+ICAzIGZpbGVzIGNoYW5nZWQsIDE2MyBpbnNlcnRpb25zKCsp LCAxOCBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2F0b21pY19wbGFuZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWlj X3BsYW5lLmMKPj4gaW5kZXggZGJlOWZiNDFhZTUzLi42MGQ3NWNlOGE5ODkgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jCj4+IEBAIC0xMDMsMzYgKzEw MywyNCBAQCBpbnRlbF9wbGFuZV9kZXN0cm95X3N0YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l LAo+PiAgICAgIGRybV9hdG9taWNfaGVscGVyX3BsYW5lX2Rlc3Ryb3lfc3RhdGUocGxhbmUsIHN0 YXRlKTsKPj4gIH0KPj4KPj4gLXN0YXRpYyBpbnQgaW50ZWxfcGxhbmVfYXRvbWljX2NoZWNrKHN0 cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiAtICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgZHJt X3BsYW5lX3N0YXRlICpzdGF0ZSkKPj4gK2ludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2tfd2l0 aF9zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwKPj4gKyAgICAgICAg ICAgICAgICAgICAgc3RydWN0IGludGVsX3BsYW5lX3N0YXRlICppbnRlbF9zdGF0ZSkKPj4gIHsK Pj4gKyAgICBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSA9IGludGVsX3N0YXRlLT5iYXNlLnBsYW5l Owo+PiAgICAgIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocGxh bmUtPmRldik7Cj4+IC0gICAgc3RydWN0IGRybV9jcnRjICpjcnRjID0gc3RhdGUtPmNydGM7Cj4+ IC0gICAgc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGM7Cj4+IC0gICAgc3RydWN0IGludGVs X2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+ICsgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq c3RhdGUgPSAmaW50ZWxfc3RhdGUtPmJhc2U7Cj4+ICAgICAgc3RydWN0IGludGVsX3BsYW5lICpp bnRlbF9wbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lKTsKPj4gLSAgICBzdHJ1Y3QgaW50ZWxf cGxhbmVfc3RhdGUgKmludGVsX3N0YXRlID0gdG9faW50ZWxfcGxhbmVfc3RhdGUoc3RhdGUpOwo+ PiAtICAgIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqZHJtX2NydGNfc3RhdGU7Cj4+ICAgICAgaW50 IHJldDsKPj4KPj4gLSAgICBjcnRjID0gY3J0YyA/IGNydGMgOiBwbGFuZS0+c3RhdGUtPmNydGM7 Cj4+IC0gICAgaW50ZWxfY3J0YyA9IHRvX2ludGVsX2NydGMoY3J0Yyk7Cj4+IC0KPj4gICAgICAv Kgo+PiAgICAgICAqIEJvdGggY3J0YyBhbmQgcGxhbmUtPmNydGMgY291bGQgYmUgTlVMTCBpZiB3 ZSdyZSB1cGRhdGluZyBhCj4+ICAgICAgICogcHJvcGVydHkgd2hpbGUgdGhlIHBsYW5lIGlzIGRp c2FibGVkLiAgV2UgZG9uJ3QgYWN0dWFsbHkgaGF2ZQo+PiAgICAgICAqIGFueXRoaW5nIGRyaXZl ci1zcGVjaWZpYyB3ZSBuZWVkIHRvIHRlc3QgaW4gdGhhdCBjYXNlLCBzbwo+PiAgICAgICAqIGp1 c3QgcmV0dXJuIHN1Y2Nlc3MuCj4+ICAgICAgICovCj4+IC0gICAgaWYgKCFjcnRjKQo+PiArICAg IGlmICghaW50ZWxfc3RhdGUtPmJhc2UuY3J0YyAmJiAhcGxhbmUtPnN0YXRlLT5jcnRjKQo+PiAg ICAgICAgICByZXR1cm4gMDsKPj4KPj4gLSAgICBkcm1fY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNf Z2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RhdGUtPnN0YXRlLCBjcnRjKTsKPj4gLSAgICBpZiAo V0FSTl9PTighZHJtX2NydGNfc3RhdGUpKQo+PiAtICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4g LQo+PiAtICAgIGNydGNfc3RhdGUgPSB0b19pbnRlbF9jcnRjX3N0YXRlKGRybV9jcnRjX3N0YXRl KTsKPj4gLQo+PiAgICAgIC8qIENsaXAgYWxsIHBsYW5lcyB0byBDUlRDIHNpemUsIG9yIDB4MCBp ZiBDUlRDIGlzIGRpc2FibGVkICovCj4+ICAgICAgaW50ZWxfc3RhdGUtPmNsaXAueDEgPSAwOwo+ PiAgICAgIGludGVsX3N0YXRlLT5jbGlwLnkxID0gMDsKPj4gQEAgLTE4NCw2ICsxNzIsMzEgQEAg c3RhdGljIGludCBpbnRlbF9wbGFuZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxh bmUsCj4+ICAgICAgcmV0dXJuIGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMoJmNydGNf c3RhdGUtPmJhc2UsIHN0YXRlKTsKPj4gIH0KPj4KPj4gK3N0YXRpYyBpbnQgaW50ZWxfcGxhbmVf YXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiArICAgICAgICAgICAgICAg ICAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPj4gK3sKPj4gKyAgICBzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMgPSBzdGF0ZS0+Y3J0YzsKPj4gKyAgICBzdHJ1Y3QgZHJtX2NydGNfc3Rh dGUgKmRybV9jcnRjX3N0YXRlOwo+PiArCj4+ICsgICAgY3J0YyA9IGNydGMgPyBjcnRjIDogcGxh bmUtPnN0YXRlLT5jcnRjOwo+PiArCj4+ICsgICAgLyoKPj4gKyAgICAgKiBCb3RoIGNydGMgYW5k IHBsYW5lLT5jcnRjIGNvdWxkIGJlIE5VTEwgaWYgd2UncmUgdXBkYXRpbmcgYQo+PiArICAgICAq IHByb3BlcnR5IHdoaWxlIHRoZSBwbGFuZSBpcyBkaXNhYmxlZC4gIFdlIGRvbid0IGFjdHVhbGx5 IGhhdmUKPj4gKyAgICAgKiBhbnl0aGluZyBkcml2ZXItc3BlY2lmaWMgd2UgbmVlZCB0byB0ZXN0 IGluIHRoYXQgY2FzZSwgc28KPj4gKyAgICAgKiBqdXN0IHJldHVybiBzdWNjZXNzLgo+PiArICAg ICAqLwo+PiArICAgIGlmICghY3J0YykKPj4gKyAgICAgICAgcmV0dXJuIDA7Cj4+ICsKPj4gKyAg ICBkcm1fY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3Rh dGUtPnN0YXRlLCBjcnRjKTsKPj4gKyAgICBpZiAoV0FSTl9PTighZHJtX2NydGNfc3RhdGUpKQo+ PiArICAgICAgICByZXR1cm4gLUVJTlZBTDsKPj4gKwo+PiArICAgIHJldHVybiBpbnRlbF9wbGFu ZV9hdG9taWNfY2hlY2tfd2l0aF9zdGF0ZSh0b19pbnRlbF9jcnRjX3N0YXRlKGRybV9jcnRjX3N0 YXRlKSwKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIHRvX2ludGVsX3BsYW5lX3N0YXRl KHN0YXRlKSk7Cj4+ICt9Cj4+ICsKPj4gIHN0YXRpYyB2b2lkIGludGVsX3BsYW5lX2F0b21pY191 cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4+ICAgICAgICAgICAgICAgICAgICAgICAg c3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqb2xkX3N0YXRlKQo+PiAgewo+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4+IGluZGV4IDllYWYxZTViZGFlOS4uNTU2OGVjYWMyZWRjIDEw MDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4+IEBAIC0xNTAyOCw2ICsx NTAyOCwxMzYgQEAgY29uc3Qgc3RydWN0IGRybV9wbGFuZV9mdW5jcyBpbnRlbF9wbGFuZV9mdW5j cyA9IHsKPj4gICAgICAuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBpbnRlbF9wbGFuZV9kZXN0cm95 X3N0YXRlLAo+PiAgfTsKPj4KPj4gK3N0YXRpYyBpbnQKPj4gK2ludGVsX2xlZ2FjeV9jdXJzb3Jf dXBkYXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+PiArICAgICAgICAgICAgICAgc3RydWN0 IGRybV9jcnRjICpjcnRjLAo+PiArICAgICAgICAgICAgICAgc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmIsCj4+ICsgICAgICAgICAgICAgICBpbnQgY3J0Y194LCBpbnQgY3J0Y195LAo+PiArICAg ICAgICAgICAgICAgdW5zaWduZWQgaW50IGNydGNfdywgdW5zaWduZWQgaW50IGNydGNfaCwKPj4g KyAgICAgICAgICAgICAgIHVpbnQzMl90IHNyY194LCB1aW50MzJfdCBzcmNfeSwKPj4gKyAgICAg ICAgICAgICAgIHVpbnQzMl90IHNyY193LCB1aW50MzJfdCBzcmNfaCkKPj4gK3sKPj4gKyAgICBz dHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmRldik7Cj4+ ICsgICAgaW50IHJldDsKPj4gKyAgICBzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpvbGRfcGxhbmVf c3RhdGUsICpuZXdfcGxhbmVfc3RhdGU7Cj4+ICsgICAgc3RydWN0IGludGVsX3BsYW5lICppbnRl bF9wbGFuZSA9IHRvX2ludGVsX3BsYW5lKHBsYW5lKTsKPj4gKyAgICBzdHJ1Y3QgZHJtX2ZyYW1l YnVmZmVyICpvbGRfZmI7Cj4+ICsgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRl ID0gY3J0Yy0+c3RhdGU7Cj4+ICsKPj4gKyAgICAvKgo+PiArICAgICAqIFdoZW4gY3J0YyBpcyBp bmFjdGl2ZSBvciB0aGVyZSBpcyBhIG1vZGVzZXQgcGVuZGluZywKPj4gKyAgICAgKiB3YWl0IGZv ciBpdCB0byBjb21wbGV0ZSBpbiB0aGUgc2xvd3BhdGgKPj4gKyAgICAgKi8KPj4gKyAgICBpZiAo IWNydGNfc3RhdGUtPmFjdGl2ZSB8fCBuZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpIHx8Cj4+ICsg ICAgICAgIHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Y19zdGF0ZSktPnVwZGF0ZV9waXBlKQo+PiAr ICAgICAgICBnb3RvIHNsb3c7Cj4+ICsKPj4gKyAgICBvbGRfcGxhbmVfc3RhdGUgPSBwbGFuZS0+ c3RhdGU7Cj4+ICsKPj4gKyAgICAvKgo+PiArICAgICAqIElmIGFueSBwYXJhbWV0ZXJzIGNoYW5n ZSB0aGF0IG1heSBhZmZlY3Qgd2F0ZXJtYXJrcywKPj4gKyAgICAgKiB0YWtlIHRoZSBzbG93cGF0 aC4gT25seSBjaGFuZ2luZyBmYiBvciBwb3NpdGlvbiBzaG91bGQgYmUKPj4gKyAgICAgKiBpbiB0 aGUgZmFzdHBhdGguCj4+ICsgICAgICovCj4+ICsgICAgaWYgKG9sZF9wbGFuZV9zdGF0ZS0+Y3J0 YyAhPSBjcnRjIHx8Cj4+ICsgICAgICAgIG9sZF9wbGFuZV9zdGF0ZS0+c3JjX3cgIT0gc3JjX3cg fHwKPj4gKyAgICAgICAgb2xkX3BsYW5lX3N0YXRlLT5zcmNfaCAhPSBzcmNfaCB8fAo+PiArICAg ICAgICBvbGRfcGxhbmVfc3RhdGUtPmNydGNfdyAhPSBjcnRjX3cgfHwKPj4gKyAgICAgICAgb2xk X3BsYW5lX3N0YXRlLT5jcnRjX2ggIT0gY3J0Y19oIHx8Cj4+ICsgICAgICAgICFvbGRfcGxhbmVf c3RhdGUtPnZpc2libGUgfHwKPj4gKyAgICAgICAgb2xkX3BsYW5lX3N0YXRlLT5mYi0+bW9kaWZp ZXIgIT0gZmItPm1vZGlmaWVyKQo+PiArICAgICAgICBnb3RvIHNsb3c7Cj4+ICsKPj4gKyAgICBu ZXdfcGxhbmVfc3RhdGUgPSBpbnRlbF9wbGFuZV9kdXBsaWNhdGVfc3RhdGUocGxhbmUpOwo+PiAr ICAgIGlmICghbmV3X3BsYW5lX3N0YXRlKQo+PiArICAgICAgICByZXR1cm4gLUVOT01FTTsKPgo+ IEFib3V0IGNyZWF0aW5nIGEgbmV3IHBsYW5lIHN0YXRlIGhlcmUgYW5kIHN3YXBwaW5nIGl0IGxh dGVyLCBJIGd1ZXNzCj4gaXQncyBtb3JlIGZvciB0aGUgc2FrZSBvZiBpbnRlbF9wbGFuZV9hdG9t aWNfY2hlY2tfd2l0aF9zdGF0ZSgpIHRvIGdvCj4gdGhyb3VnaCBjbGVhbmx5LCByaWdodD8gUmF0 aGVyIHRoYW4gZGlyZWN0bHkgbW9kaWZ5aW5nIHRoZSBvbGQgcGxhbmUKPiBzdGF0ZT8KaTkxNSBr ZWVwcyBzb21lIGRlcml2ZWQgc3RhdGUgaW4gaW50ZWxfcGxhbmVfc3RhdGUsIHdlIGNvcHkgdGhl IGZ1bGwgc3RhdGUgdG8gbWFrZSBzdXJlIHRoZSBmdWxsIGRlcml2ZWQgc3RhdGUgaXMgdXBkYXRl ZCBhcyB3ZWxsLgoKPiBJIGRpZG4ndCBzZWUgYW55dGhpbmcgZXF1aXZhbGVudCBpbiB2YzQncyBp bXBsZW1lbnRhdGlvbiBvZgo+IHVwZGF0ZV9wbGFuZSwgaGVuY2Ugd2FzIHdvbmRlcmluZyB3aHkg ZXhhY3RseSBpdCBpcyBuZWVkZWQuCj4KPiBBbHNvLCBhYm91dCB1cGRhdGluZyBmYiBpbiB0aGUg ZmFzdCBwYXRoLCBteSBhc3N1bXB0aW9uIHdhcwo+IHRoYXQgaXQgd2FzIG9ubHkgY3J0Y194L3kg d2FzIHRoZSB0aGluZyBtb3N0IGxpa2VseSB0byBiZQo+IGNoYW5nZWQgcmVhbGx5IGZhc3QuIEhh dmUgeW91IHNlZW4gdXNlIGNhc2VzIHdoZXJlIHRoZSBmYgo+IGNoYW5nZXMgYXQgYSBmYXN0ZXIg dGhhbiB2c3luYyByYXRlPyAKSXQgZGlkbid0IGNvc3QgbXVjaCBleHRyYSBlZmZvcnQgdG8gaW1w bGVtZW50IGZiIGNoYW5naW5nIHRvbyBzaW5jZSB0aGF0IGlzIGhhbmRsZWQgaW4KaW50ZWwncyB1 cGRhdGVfcGxhbmUgY2FsbGJhY2sgdG9vLiBUaGlzIGlzIHdoeSBJIGRpZCB0aGF0IGFzIHdlbGwu IEknbSBub3Qgc3VyZSBpdCdzIG5lZWRlZCBpbiBnZW5lcmFsLgpBbnkgY2hhbmdlZCBmYiBzdGls bCBoYXMgdG8gaGF2ZSB0aGUgc2FtZSBzaXplIG9yIHdlIGdvIHRvIHNsb3dwYXRoLgoKfk1hYXJ0 ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==