From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Sharma, Shashank" Subject: Re: [PATCH v3 1/4] drm/edid: Abstract away cea_edid_modes[] Date: Thu, 3 Oct 2019 13:46:16 +0530 Message-ID: <8f5dd796-dff5-bd23-54b3-e7c13f70b6f9@intel.com> References: <20190925135502.24055-1-ville.syrjala@linux.intel.com> <20190925135502.24055-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190925135502.24055-2-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala , dri-devel@lists.freedesktop.org Cc: Hans Verkuil , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org SGVsbG8gVmlsbGUsCgpPbiA5LzI1LzIwMTkgNzoyNCBQTSwgVmlsbGUgU3lyamFsYSB3cm90ZToK PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ Cj4gV2UncmUgZ29pbmcgdG8gbmVlZCB0d28gY2VhIG1vZGUgdGFibGVzIChvbiBmb3IgVklDcyA8 IDEyOCwKPiBhbm90aGVyIG9uZSBmb3IgVklDcyA+PSAxOTMpLiBUbyB0aGF0IGVuZCByZXBsYWNl IHRoZSBkaXJlY3QKPiBlZGlkX2NlYV9tb2Rlc1tdIGxvb2t1cHMgd2l0aCBhIGZ1bmN0aW9uIGNh bGwuIEFuZCB3ZSdsbCByZW5hbWUKPiB0aGUgYXJyYXkgdG8gZWRpZF9jZWFfbW9kZXNfMFtdIHRv IGluZGljYXRoZSBob3cgaXQncyB0byBiZQpTaG91bGQgd2UgY2FsbCBpdCBzb21ldGhpbmcgd2hp Y2ggaW5kaWNhdGVzIHRoZSBzcGVjIHZlcnNpb24sIGluc3RlYWQgb2YgCmEgcmFuZG9tICcwJywg bGlrZSBlZGlkX2NlYV84NjFfRl9tb2Rlc1tdIGFuZCB0aGUgbmV4dCBvbmUgYXMgX0dfbW9kZXMg Cm9yIENUQV8zIG1vZGVzID8KPiBpbmRleGVkLgo+Cj4gQ2M6IEhhbnMgVmVya3VpbCA8aGFuc3Zl cmtAY2lzY28uY29tPgo+IENjOiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRl bC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxp bnV4LmludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIHwgODAg KysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCA1OCBpbnNlcnRpb25zKCspLCAyMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gaW5k ZXggM2M5NzAzYjA4NDkxLi5iNzAwZmMwNzUyNTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2RybV9lZGlkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+IEBAIC03 MDcsMTIgKzcwNywxMSBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IG1pbmltb2RlIGV4dHJhX21vZGVz W10gPSB7Cj4gICB9Owo+ICAgCj4gICAvKgo+IC0gKiBQcm9iYWJseSB0YWtlbiBmcm9tIENFQS04 NjEgc3BlYy4KPiAtICogVGhpcyB0YWJsZSBpcyBjb252ZXJ0ZWQgZnJvbSB4b3JnJ3MgaHcveGZy ZWU4Ni9tb2Rlcy94Zjg2RWRpZE1vZGVzLmMuCj4gKyAqIEZyb20gQ0VBL0NUQS04NjEgc3BlYy4K PiAgICAqCj4gLSAqIEluZGV4IHVzaW5nIHRoZSBWSUMuCj4gKyAqIEluZGV4IHdpdGggVklDLgo+ ICAgICovCj4gLXN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBlZGlkX2NlYV9t b2Rlc1tdID0gewo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGRybV9kaXNwbGF5X21vZGUgZWRpZF9j ZWFfbW9kZXNfMFtdID0gewo+ICAgCS8qIDAgLSBkdW1teSwgVklDcyBzdGFydCBhdCAxICovCj4g ICAJeyB9LAo+ICAgCS8qIDEgLSA2NDB4NDgwQDYwSHogNDozICovCj4gQEAgLTMwNjcsNiArMzA2 NiwyNSBAQCBzdGF0aWMgdTggKmRybV9maW5kX2NlYV9leHRlbnNpb24oY29uc3Qgc3RydWN0IGVk aWQgKmVkaWQpCj4gICAJcmV0dXJuIGNlYTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgY29uc3Qgc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKmNlYV9tb2RlX2Zvcl92aWModTggdmljKQo+ICt7Cj4gKwlp ZiAoIXZpYykKPiArCQlyZXR1cm4gTlVMTDsKPiArCWlmICh2aWMgPCBBUlJBWV9TSVpFKGVkaWRf Y2VhX21vZGVzXzApKQo+ICsJCXJldHVybiAmZWRpZF9jZWFfbW9kZXNfMFt2aWNdOwo+ICsJcmV0 dXJuIE5VTEw7Cj4gK30KPiArCj4gK3N0YXRpYyB1OCBjZWFfbnVtX3ZpY3Modm9pZCkKPiArewo+ ICsJcmV0dXJuIEFSUkFZX1NJWkUoZWRpZF9jZWFfbW9kZXNfMCk7Cj4gK30KPiArCj4gK3N0YXRp YyB1OCBjZWFfbmV4dF92aWModTggdmljKQo+ICt7Cj4gKwlyZXR1cm4gdmljICsgMTsKSXMgdGhl cmUgYW55IHNwZWNpZmljIHJlYXNvbiBmb3IgYWRkaW5nIGEgbmV3IGhlbHBlciBmdW5jdGlvbiwg anVzdCB0byAKcmV0dXJuIHZpYyArIDEgPwo+ICt9Cj4gKwo+ICAgLyoKPiAgICAqIENhbGN1bGF0 ZSB0aGUgYWx0ZXJuYXRlIGNsb2NrIGZvciB0aGUgQ0VBIG1vZGUKPiAgICAqICg2MEh6IHZzLiA1 OS45NEh6IGV0Yy4pCj4gQEAgLTMxMDQsMTQgKzMxMjIsMTQgQEAgY2VhX21vZGVfYWx0ZXJuYXRl X3RpbWluZ3ModTggdmljLCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSkKPiAgIAkgKiBn ZXQgdGhlIG90aGVyIHZhcmlhbnRzIGJ5IHNpbXBseSBpbmNyZWFzaW5nIHRoZQo+ICAgCSAqIHZl cnRpY2FsIGZyb250IHBvcmNoIGxlbmd0aC4KPiAgIAkgKi8KPiAtCUJVSUxEX0JVR19PTihlZGlk X2NlYV9tb2Rlc1s4XS52dG90YWwgIT0gMjYyIHx8Cj4gLQkJICAgICBlZGlkX2NlYV9tb2Rlc1s5 XS52dG90YWwgIT0gMjYyIHx8Cj4gLQkJICAgICBlZGlkX2NlYV9tb2Rlc1sxMl0udnRvdGFsICE9 IDI2MiB8fAo+IC0JCSAgICAgZWRpZF9jZWFfbW9kZXNbMTNdLnZ0b3RhbCAhPSAyNjIgfHwKPiAt CQkgICAgIGVkaWRfY2VhX21vZGVzWzIzXS52dG90YWwgIT0gMzEyIHx8Cj4gLQkJICAgICBlZGlk X2NlYV9tb2Rlc1syNF0udnRvdGFsICE9IDMxMiB8fAo+IC0JCSAgICAgZWRpZF9jZWFfbW9kZXNb MjddLnZ0b3RhbCAhPSAzMTIgfHwKPiAtCQkgICAgIGVkaWRfY2VhX21vZGVzWzI4XS52dG90YWwg IT0gMzEyKTsKPiArCUJVSUxEX0JVR19PTihjZWFfbW9kZV9mb3JfdmljKDgpLT52dG90YWwgIT0g MjYyIHx8Cj4gKwkJICAgICBjZWFfbW9kZV9mb3JfdmljKDkpLT52dG90YWwgIT0gMjYyIHx8Cj4g KwkJICAgICBjZWFfbW9kZV9mb3JfdmljKDEyKS0+dnRvdGFsICE9IDI2MiB8fAo+ICsJCSAgICAg Y2VhX21vZGVfZm9yX3ZpYygxMyktPnZ0b3RhbCAhPSAyNjIgfHwKPiArCQkgICAgIGNlYV9tb2Rl X2Zvcl92aWMoMjMpLT52dG90YWwgIT0gMzEyIHx8Cj4gKwkJICAgICBjZWFfbW9kZV9mb3Jfdmlj KDI0KS0+dnRvdGFsICE9IDMxMiB8fAo+ICsJCSAgICAgY2VhX21vZGVfZm9yX3ZpYygyNyktPnZ0 b3RhbCAhPSAzMTIgfHwKPiArCQkgICAgIGNlYV9tb2RlX2Zvcl92aWMoMjgpLT52dG90YWwgIT0g MzEyKTsKPiAgIAo+ICAgCWlmICgoKHZpYyA9PSA4IHx8IHZpYyA9PSA5IHx8Cj4gICAJICAgICAg dmljID09IDEyIHx8IHZpYyA9PSAxMykgJiYgbW9kZS0+dnRvdGFsIDwgMjYzKSB8fAo+IEBAIC0z MTM5LDEwICszMTU3LDE2IEBAIHN0YXRpYyB1OCBkcm1fbWF0Y2hfY2VhX21vZGVfY2xvY2tfdG9s ZXJhbmNlKGNvbnN0IHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlICp0b19tCj4gICAJaWYgKHRvX21h dGNoLT5waWN0dXJlX2FzcGVjdF9yYXRpbykKPiAgIAkJbWF0Y2hfZmxhZ3MgfD0gRFJNX01PREVf TUFUQ0hfQVNQRUNUX1JBVElPOwo+ICAgCj4gLQlmb3IgKHZpYyA9IDE7IHZpYyA8IEFSUkFZX1NJ WkUoZWRpZF9jZWFfbW9kZXMpOyB2aWMrKykgewo+IC0JCXN0cnVjdCBkcm1fZGlzcGxheV9tb2Rl IGNlYV9tb2RlID0gZWRpZF9jZWFfbW9kZXNbdmljXTsKPiArCWZvciAodmljID0gMTsgdmljIDwg Y2VhX251bV92aWNzKCk7IHZpYyA9IGNlYV9uZXh0X3ZpYyh2aWMpKSB7Cj4gKwkJY29uc3Qgc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGUgPSBjZWFfbW9kZV9mb3JfdmljKHZpYyk7Cj4gKwkJ c3RydWN0IGRybV9kaXNwbGF5X21vZGUgY2VhX21vZGU7Cj4gICAJCXVuc2lnbmVkIGludCBjbG9j azEsIGNsb2NrMjsKPiAgIAo+ICsJCWlmICghbW9kZSkKPiArCQkJY29udGludWU7Cj4gKwo+ICsJ CWNlYV9tb2RlID0gKm1vZGU7Cj4gKwo+ICAgCQkvKiBDaGVjayBib3RoIDYwSHogYW5kIDU5Ljk0 SHogKi8KPiAgIAkJY2xvY2sxID0gY2VhX21vZGUuY2xvY2s7Cj4gICAJCWNsb2NrMiA9IGNlYV9t b2RlX2FsdGVybmF0ZV9jbG9jaygmY2VhX21vZGUpOwo+IEBAIC0zMTc4LDEwICszMjAyLDE2IEBA IHU4IGRybV9tYXRjaF9jZWFfbW9kZShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqdG9f bWF0Y2gpCj4gICAJaWYgKHRvX21hdGNoLT5waWN0dXJlX2FzcGVjdF9yYXRpbykKPiAgIAkJbWF0 Y2hfZmxhZ3MgfD0gRFJNX01PREVfTUFUQ0hfQVNQRUNUX1JBVElPOwo+ICAgCj4gLQlmb3IgKHZp YyA9IDE7IHZpYyA8IEFSUkFZX1NJWkUoZWRpZF9jZWFfbW9kZXMpOyB2aWMrKykgewo+IC0JCXN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlIGNlYV9tb2RlID0gZWRpZF9jZWFfbW9kZXNbdmljXTsKPiAr CWZvciAodmljID0gMTsgdmljIDwgY2VhX251bV92aWNzKCk7IHZpYyA9IGNlYV9uZXh0X3ZpYyh2 aWMpKSB7CkFnYWluLCB3aHkgbm90IGp1c3QgdmljKz0xIDopID8KPiArCQljb25zdCBzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSA9IGNlYV9tb2RlX2Zvcl92aWModmljKTsKPiArCQlzdHJ1 Y3QgZHJtX2Rpc3BsYXlfbW9kZSBjZWFfbW9kZTsKPiAgIAkJdW5zaWduZWQgaW50IGNsb2NrMSwg Y2xvY2syOwo+ICAgCj4gKwkJaWYgKCFtb2RlKQo+ICsJCQljb250aW51ZTsKPiArCj4gKwkJY2Vh X21vZGUgPSAqbW9kZTsKPiArCj4gICAJCS8qIENoZWNrIGJvdGggNjBIeiBhbmQgNTkuOTRIeiAq Lwo+ICAgCQljbG9jazEgPSBjZWFfbW9kZS5jbG9jazsKPiAgIAkJY2xvY2syID0gY2VhX21vZGVf YWx0ZXJuYXRlX2Nsb2NrKCZjZWFfbW9kZSk7Cj4gQEAgLTMyMDIsNyArMzIzMiw3IEBAIEVYUE9S VF9TWU1CT0woZHJtX21hdGNoX2NlYV9tb2RlKTsKPiAgIAo+ICAgc3RhdGljIGJvb2wgZHJtX3Zh bGlkX2NlYV92aWModTggdmljKQo+ICAgewo+IC0JcmV0dXJuIHZpYyA+IDAgJiYgdmljIDwgQVJS QVlfU0laRShlZGlkX2NlYV9tb2Rlcyk7Cj4gKwlyZXR1cm4gY2VhX21vZGVfZm9yX3ZpYyh2aWMp ICE9IE5VTEw7Cj4gICB9Cj4gICAKPiAgIC8qKgo+IEBAIC0zMjE0LDcgKzMyNDQsMTMgQEAgc3Rh dGljIGJvb2wgZHJtX3ZhbGlkX2NlYV92aWModTggdmljKQo+ICAgICovCj4gICBlbnVtIGhkbWlf cGljdHVyZV9hc3BlY3QgZHJtX2dldF9jZWFfYXNwZWN0X3JhdGlvKGNvbnN0IHU4IHZpZGVvX2Nv ZGUpCj4gICB7Cj4gLQlyZXR1cm4gZWRpZF9jZWFfbW9kZXNbdmlkZW9fY29kZV0ucGljdHVyZV9h c3BlY3RfcmF0aW87Cj4gKwljb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZTsKPiAr Cj4gKwltb2RlID0gY2VhX21vZGVfZm9yX3ZpYyh2aWRlb19jb2RlKTsKPiArCWlmIChtb2RlKQo+ ICsJCXJldHVybiBtb2RlLT5waWN0dXJlX2FzcGVjdF9yYXRpbzsKPiArCj4gKwlyZXR1cm4gSERN SV9QSUNUVVJFX0FTUEVDVF9OT05FOwo+ICAgfQo+ICAgRVhQT1JUX1NZTUJPTChkcm1fZ2V0X2Nl YV9hc3BlY3RfcmF0aW8pOwo+ICAgCj4gQEAgLTMzMjMsNyArMzM1OSw3IEBAIGFkZF9hbHRlcm5h dGVfY2VhX21vZGVzKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsIHN0cnVjdCBlZGlk ICplZGlkKQo+ICAgCQl1bnNpZ25lZCBpbnQgY2xvY2sxLCBjbG9jazI7Cj4gICAKPiAgIAkJaWYg KGRybV92YWxpZF9jZWFfdmljKHZpYykpIHsKPiAtCQkJY2VhX21vZGUgPSAmZWRpZF9jZWFfbW9k ZXNbdmljXTsKPiArCQkJY2VhX21vZGUgPSBjZWFfbW9kZV9mb3JfdmljKHZpYyk7Cj4gICAJCQlj bG9jazIgPSBjZWFfbW9kZV9hbHRlcm5hdGVfY2xvY2soY2VhX21vZGUpOwo+ICAgCQl9IGVsc2Ug ewo+ICAgCQkJdmljID0gZHJtX21hdGNoX2hkbWlfbW9kZShtb2RlKTsKPiBAQCAtMzM5OCw3ICsz NDM0LDcgQEAgZHJtX2Rpc3BsYXlfbW9kZV9mcm9tX3ZpY19pbmRleChzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yLAo+ICAgCWlmICghZHJtX3ZhbGlkX2NlYV92aWModmljKSkKPiAgIAkJ cmV0dXJuIE5VTEw7Cj4gICAKPiAtCW5ld21vZGUgPSBkcm1fbW9kZV9kdXBsaWNhdGUoZGV2LCAm ZWRpZF9jZWFfbW9kZXNbdmljXSk7Cj4gKwluZXdtb2RlID0gZHJtX21vZGVfZHVwbGljYXRlKGRl diwgY2VhX21vZGVfZm9yX3ZpYyh2aWMpKTsKPiAgIAlpZiAoIW5ld21vZGUpCj4gICAJCXJldHVy biBOVUxMOwo+ICAgCj4gQEAgLTM0MzIsNyArMzQ2OCw3IEBAIHN0YXRpYyBpbnQgZG9feTQyMHZk Yl9tb2RlcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAgCQlpZiAoIWRybV92 YWxpZF9jZWFfdmljKHZpYykpCj4gICAJCQljb250aW51ZTsKPiAgIAo+IC0JCW5ld21vZGUgPSBk cm1fbW9kZV9kdXBsaWNhdGUoZGV2LCAmZWRpZF9jZWFfbW9kZXNbdmljXSk7Cj4gKwkJbmV3bW9k ZSA9IGRybV9tb2RlX2R1cGxpY2F0ZShkZXYsIGNlYV9tb2RlX2Zvcl92aWModmljKSk7Cj4gICAJ CWlmICghbmV3bW9kZSkKPiAgIAkJCWJyZWFrOwo+ICAgCQliaXRtYXBfc2V0KGhkbWktPnk0MjBf dmRiX21vZGVzLCB2aWMsIDEpOwo+IEBAIC00MDAxLDcgKzQwMzcsNyBAQCBzdGF0aWMgdm9pZCBm aXh1cF9kZXRhaWxlZF9jZWFfbW9kZV9jbG9jayhzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9k ZSkKPiAgIAl2aWMgPSBkcm1fbWF0Y2hfY2VhX21vZGVfY2xvY2tfdG9sZXJhbmNlKG1vZGUsIDUp Owo+ICAgCWlmIChkcm1fdmFsaWRfY2VhX3ZpYyh2aWMpKSB7Cj4gICAJCXR5cGUgPSAiQ0VBIjsK PiAtCQljZWFfbW9kZSA9ICZlZGlkX2NlYV9tb2Rlc1t2aWNdOwo+ICsJCWNlYV9tb2RlID0gY2Vh X21vZGVfZm9yX3ZpYyh2aWMpOwo+ICAgCQljbG9jazEgPSBjZWFfbW9kZS0+Y2xvY2s7Cj4gICAJ CWNsb2NrMiA9IGNlYV9tb2RlX2FsdGVybmF0ZV9jbG9jayhjZWFfbW9kZSk7Cj4gICAJfSBlbHNl IHsKLSBTaGFzaGFuawpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWw=