From mboxrd@z Thu Jan 1 00:00:00 1970 From: "C, Ramalingam" Subject: Re: [PATCH v3 2/4] drm/i915: Fix platform coverage for HDCP1.4 Date: Wed, 5 Dec 2018 17:23:29 +0530 Message-ID: <8f791feb-5415-3fa9-b9bd-0764478d6f96@intel.com> References: <1543946827-31662-1-git-send-email-ramalingam.c@intel.com> <1543946827-31662-3-git-send-email-ramalingam.c@intel.com> <20181204191502.GN9144@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0471581347==" Return-path: In-Reply-To: <20181204191502.GN9144@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org, seanpaul@chromium.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============0471581347== Content-Type: multipart/alternative; boundary="------------70E8A98BD0B4EE2256779098" Content-Language: en-US This is a multi-part message in MIME format. --------------70E8A98BD0B4EE2256779098 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 12/5/2018 12:45 AM, Ville Syrjälä wrote: > On Tue, Dec 04, 2018 at 11:37:05PM +0530, Ramalingam C wrote: >> HDCP1.4 is enabled and validated only on GEN9+ platforms. >> >> Signed-off-by: Ramalingam C >> Reviewed-by: Sean Paul >> --- >> drivers/gpu/drm/i915/intel_hdcp.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c >> index c16bffcce3b0..bccfb001340a 100644 >> --- a/drivers/gpu/drm/i915/intel_hdcp.c >> +++ b/drivers/gpu/drm/i915/intel_hdcp.c >> @@ -769,8 +769,7 @@ static void intel_hdcp_prop_work(struct work_struct *work) >> bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port) >> { >> /* PORT E doesn't have HDCP, and PORT F is disabled */ >> - return ((INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) && >> - !IS_CHERRYVIEW(dev_priv) && port < PORT_E); >> + return ((INTEL_GEN(dev_priv) >= 9) && port < PORT_E); > Drive-by: Lots of pointless parens floating around here. kept it for readability. Perhaps overkill here. Removed them. Thanks, --Ram > >> } >> >> int intel_hdcp_init(struct intel_connector *connector, >> -- >> 2.7.4 --------------70E8A98BD0B4EE2256779098 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit


On 12/5/2018 12:45 AM, Ville Syrjälä wrote:
On Tue, Dec 04, 2018 at 11:37:05PM +0530, Ramalingam C wrote:

HDCP1.4 is enabled and validated only on GEN9+ platforms.

Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
Reviewed-by: Sean Paul <sean@poorly.run>
---
 drivers/gpu/drm/i915/intel_hdcp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_hdcp.c b/drivers/gpu/drm/i915/intel_hdcp.c
index c16bffcce3b0..bccfb001340a 100644
--- a/drivers/gpu/drm/i915/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/intel_hdcp.c
@@ -769,8 +769,7 @@ static void intel_hdcp_prop_work(struct work_struct *work)
 bool is_hdcp_supported(struct drm_i915_private *dev_priv, enum port port)
 {
 	/* PORT E doesn't have HDCP, and PORT F is disabled */
-	return ((INTEL_GEN(dev_priv) >= 8 || IS_HASWELL(dev_priv)) &&
-		!IS_CHERRYVIEW(dev_priv) && port < PORT_E);
+	return ((INTEL_GEN(dev_priv) >= 9) && port < PORT_E);

Drive-by: Lots of pointless parens floating around here.
kept it for readability. Perhaps overkill here. Removed them.

Thanks,
--Ram



 }
 
 int intel_hdcp_init(struct intel_connector *connector,
-- 
2.7.4


    

  


--------------70E8A98BD0B4EE2256779098--

--===============0471581347==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0471581347==--