From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 2/3] drm/i915: Wrap a timer into a i915_sw_fence Date: Wed, 11 Oct 2017 13:20:25 +0100 Message-ID: <8f89be57-053c-78e2-dfed-88d87a03c3f1@linux.intel.com> References: <20171010213809.7752-1-chris@chris-wilson.co.uk> <20171010213809.7752-2-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 395C16E022 for ; Wed, 11 Oct 2017 12:20:29 +0000 (UTC) In-Reply-To: <20171010213809.7752-2-chris@chris-wilson.co.uk> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzEwLzIwMTcgMjI6MzgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBGb3Igc29tZSBzZWxm dGVzdHMsIHdlIHdhbnQgdG8gaXNzdWUgcmVxdWVzdHMgYnV0IGRlbGF5IHRoZW0gZ29pbmcgdG8K PiBoYXJkd2FyZS4gRnVydGhlcm1vcmUsIHdlIGRvbid0IHdhbnQgdGhvc2UgcmVxdWVzdHMgdG8g YmxvY2sKPiBpbmRlZmluaXRlbHkgKG9yIGVsc2Ugd2UgbWF5IGhhbmcgdGhlIGRyaXZlciBhbmQg YmxvY2sgdGVzdGluZykgc28gd2UKPiB3YW50IHRvIGVtcGxveSBhIHRpbWVvdXQuIFNvIG5hdHVy YWxseSB3ZSB3YW50IGEgZmVuY2UgdGhhdCBpcwo+IGF1dG9tYXRpY2FsbHkgc2lnbmFsZWQgYnkg YSB0aW1lci4KPiAKPiB2MjogQWRkIGtzZWxmdGVzdHMuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hy aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X3N3X2ZlbmNlLmMgICAgICAgICAgIHwgNjQgKysrKysrKysrKysrKysr KysrKysrKysrKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3dfZmVuY2UuaCAgICAg ICAgICAgfCAgMyArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfc3df ZmVuY2UuYyB8IDQzICsrKysrKysrKysrKysrKysrCj4gICAzIGZpbGVzIGNoYW5nZWQsIDExMCBp bnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf c3dfZmVuY2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfc3dfZmVuY2UuYwo+IGluZGV4 IDgwOGVhNGQ1Yjk2Mi4uMzg4NDI0YTk1YWM5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfc3dfZmVuY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf c3dfZmVuY2UuYwo+IEBAIC01MDYsNiArNTA2LDcwIEBAIGludCBpOTE1X3N3X2ZlbmNlX2F3YWl0 X3Jlc2VydmF0aW9uKHN0cnVjdCBpOTE1X3N3X2ZlbmNlICpmZW5jZSwKPiAgIAlyZXR1cm4gcmV0 Owo+ICAgfQo+ICAgCj4gK3N0cnVjdCB0aW1lcl9mZW5jZSB7Cgp0aW1lZCBmZW5jZT8KCj4gKwlz dHJ1Y3QgaTkxNV9zd19mZW5jZSBiYXNlOwo+ICsJc3RydWN0IHRpbWVyX2xpc3QgdGltZXI7Cj4g KwlzdHJ1Y3Qga3JlZiByZWY7Cj4gK307Cj4gKwo+ICtzdGF0aWMgdm9pZCB0aW1lcl9mZW5jZV93 YWtlKHVuc2lnbmVkIGxvbmcgZGF0YSkKPiArewo+ICsJc3RydWN0IHRpbWVyX2ZlbmNlICp0ZiA9 IChzdHJ1Y3QgdGltZXJfZmVuY2UgKilkYXRhOwo+ICsKPiArCWk5MTVfc3dfZmVuY2VfY29tcGxl dGUoJnRmLT5iYXNlKTsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgaTkxNV9zd19mZW5jZV90aW1l cl9mcmVlKHN0cnVjdCBrcmVmICpyZWYpCj4gK3sKPiArCXN0cnVjdCB0aW1lcl9mZW5jZSAqdGYg PSBjb250YWluZXJfb2YocmVmLCB0eXBlb2YoKnRmKSwgcmVmKTsKPiArCj4gKwlrZnJlZSh0Zik7 Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGk5MTVfc3dfZmVuY2VfdGltZXJfcHV0KHN0cnVjdCBp OTE1X3N3X2ZlbmNlICpmZW5jZSkKPiArewo+ICsJc3RydWN0IHRpbWVyX2ZlbmNlICp0ZiA9IGNv bnRhaW5lcl9vZihmZW5jZSwgdHlwZW9mKCp0ZiksIGJhc2UpOwo+ICsKPiArCWtyZWZfcHV0KCZ0 Zi0+cmVmLCBpOTE1X3N3X2ZlbmNlX3RpbWVyX2ZyZWUpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW50 IF9faTkxNV9zd19mZW5jZV9jYWxsCj4gK3RpbWVyX2ZlbmNlX25vdGlmeShzdHJ1Y3QgaTkxNV9z d19mZW5jZSAqZmVuY2UsIGVudW0gaTkxNV9zd19mZW5jZV9ub3RpZnkgc3RhdGUpCj4gK3sKPiAr CWlmIChzdGF0ZSA9PSBGRU5DRV9GUkVFKQo+ICsJCWk5MTVfc3dfZmVuY2VfdGltZXJfcHV0KGZl bmNlKTsKPiArCj4gKwlyZXR1cm4gTk9USUZZX0RPTkU7Cj4gK30KPiArCj4gK3N0cnVjdCBpOTE1 X3N3X2ZlbmNlICppOTE1X3N3X2ZlbmNlX2NyZWF0ZV90aW1lcihsb25nIHRpbWVvdXQsIGdmcF90 IGdmcCkKCkRlcGVuZGluZyBvbiB0aGUgb3V0Y29tZSBvZiB0aGUgcHVibGljIHZzIHRlc3QgcHJp dmF0ZSBxdWVzdGlvbiAoc2VlIApiZWxvdyksIHlvdSBtaWdodCB3YW50IHRvIHJlbmFtZSB0aW1l b3V0IHRvIGV4cGlyZWQgdG8gc2lnbmlmeSBpdCBpcyBpbiAKYWJzb2x1dGUgamlmZmllcy4gQW5k IGFsc28gYWRkIGtlcm5lbCBkb2MgaWYgaXQgd2lsbCBiZSBwdWJsaWMuCgo+ICt7Cj4gKwlzdHJ1 Y3QgdGltZXJfZmVuY2UgKnRmOwo+ICsKPiArCXRmID0ga21hbGxvYyhzaXplb2YoKnRmKSwgZ2Zw KTsKPiArCWlmICghdGYpCj4gKwkJcmV0dXJuIEVSUl9QVFIoLUVOT01FTSk7Cj4gKwo+ICsJaTkx NV9zd19mZW5jZV9pbml0KCZ0Zi0+YmFzZSwgdGltZXJfZmVuY2Vfbm90aWZ5KTsKPiArCWtyZWZf aW5pdCgmdGYtPnJlZik7Cj4gKwo+ICsJc2V0dXBfdGltZXIoJnRmLT50aW1lciwgdGltZXJfZmVu Y2Vfd2FrZSwgKHVuc2lnbmVkIGxvbmcpdGYpOwo+ICsJbW9kX3RpbWVyKCZ0Zi0+dGltZXIsIHRp bWVvdXQpOwo+ICsKPiArCWtyZWZfZ2V0KCZ0Zi0+cmVmKTsKPiArCXJldHVybiAmdGYtPmJhc2U7 Cj4gK30KPiArCj4gK3ZvaWQgaTkxNV9zd19mZW5jZV90aW1lcl9mbHVzaChzdHJ1Y3QgaTkxNV9z d19mZW5jZSAqZmVuY2UpCj4gK3sKPiArCXN0cnVjdCB0aW1lcl9mZW5jZSAqdGYgPSBjb250YWlu ZXJfb2YoZmVuY2UsIHR5cGVvZigqdGYpLCBiYXNlKTsKPiArCj4gKwlpZiAoZGVsX3RpbWVyX3N5 bmMoJnRmLT50aW1lcikpCj4gKwkJaTkxNV9zd19mZW5jZV9jb21wbGV0ZSgmdGYtPmJhc2UpOwo+ ICsKPiArCWk5MTVfc3dfZmVuY2VfdGltZXJfcHV0KGZlbmNlKTsKCkEgYml0IHVudXN1YWwgdGhh dCBmbHVzaCBkZXN0cm95cyBhbiBvYmplY3Q/IFNob3VsZCBpOTE1X3N3X2ZlbmNlX2ZpbmkgCmp1 c3QgYmUgbWFkZSB3b3JrIG9uIHRoZXNlIHRvIGNvbWUgY2xvc2UgdG8gT08gZGVzaWduIGl0IHBh cnRpYWxseSB0cmllcyAKdG8gZG8/Cgo+ICt9Cj4gKwoKSSByZWNrb24gdGhlcmUgYXJlIHNvbWUg cHJpdmF0ZSBmdW5jdGlvbnMgaXQgdXNlcyBzbyBpdCBoYXMgdG8gbGl2ZSBpbiAKaTkxNV9zd19m ZW5jZS5jIG9yIGl0IGNvdWxkIGJlIG1vdmVkIHVuZGVyIHNlbGZ0ZXN0cyBjb21wbGV0ZWx5PwoK UXVpY2sgZ2xhbmNlIC0gb25seSBpOTE1X3N3X2ZlbmNlX2NvbXBsZXRlIGl0IHNlZW1zPyBDb3Vs ZCB5b3UgdXNlIAppOTE1X3N3X2ZlbmNlX2NvbW1pdCBpbnN0ZWFkPyBObyBpZGVhIHdoYXQgdGhl IGludGVyYWN0aW9uIHdpdGggZGVidWcgCm9iamVjdHMgdGhlcmUgd291bGQgbWVhbi4KCkJ1dCBJ IHRoaW5rIGl0IHdvdWxkIGJlIG11Y2ggYmV0dGVyIHRvIG1vdmUgaXQgdW5kZXIgc2VsZnRlc3Rz LyBpZiBwb3NzaWJsZS4KClJlZ2FyZHMsCgpUdnJ0a28KCj4gICAjaWYgSVNfRU5BQkxFRChDT05G SUdfRFJNX0k5MTVfU0VMRlRFU1QpCj4gICAjaW5jbHVkZSAic2VsZnRlc3RzL2k5MTVfc3dfZmVu Y2UuYyIKPiAgICNlbmRpZgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3N3X2ZlbmNlLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3N3X2ZlbmNlLmgKPiBpbmRl eCBmZTJlZjRkYWRmYzYuLmMxMTFhODlhOTI3YSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3N3X2ZlbmNlLmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X3N3X2ZlbmNlLmgKPiBAQCAtNjEsNiArNjEsOSBAQCB2b2lkIGk5MTVfc3dfZmVuY2VfZmluaShz dHJ1Y3QgaTkxNV9zd19mZW5jZSAqZmVuY2UpOwo+ICAgc3RhdGljIGlubGluZSB2b2lkIGk5MTVf c3dfZmVuY2VfZmluaShzdHJ1Y3QgaTkxNV9zd19mZW5jZSAqZmVuY2UpIHt9Cj4gICAjZW5kaWYK PiAgIAo+ICtzdHJ1Y3QgaTkxNV9zd19mZW5jZSAqaTkxNV9zd19mZW5jZV9jcmVhdGVfdGltZXIo bG9uZyB0aW1lb3V0LCBnZnBfdCBnZnApOwo+ICt2b2lkIGk5MTVfc3dfZmVuY2VfdGltZXJfZmx1 c2goc3RydWN0IGk5MTVfc3dfZmVuY2UgKmZlbmNlKTsKPiArCj4gICB2b2lkIGk5MTVfc3dfZmVu Y2VfY29tbWl0KHN0cnVjdCBpOTE1X3N3X2ZlbmNlICpmZW5jZSk7Cj4gICAKPiAgIGludCBpOTE1 X3N3X2ZlbmNlX2F3YWl0X3N3X2ZlbmNlKHN0cnVjdCBpOTE1X3N3X2ZlbmNlICpmZW5jZSwKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL2k5MTVfc3dfZmVuY2Uu YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9pOTE1X3N3X2ZlbmNlLmMKPiBpbmRl eCAxOWQxNDVkNmJmNTIuLmU1MWFiNDMxMGUxZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9zZWxmdGVzdHMvaTkxNV9zd19mZW5jZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvc2VsZnRlc3RzL2k5MTVfc3dfZmVuY2UuYwo+IEBAIC0yNCw2ICsyNCw3IEBACj4gICAK PiAgICNpbmNsdWRlIDxsaW51eC9jb21wbGV0aW9uLmg+Cj4gICAjaW5jbHVkZSA8bGludXgvZGVs YXkuaD4KPiArI2luY2x1ZGUgPGxpbnV4L3ByaW1lX251bWJlcnMuaD4KPiAgIAo+ICAgI2luY2x1 ZGUgIi4uL2k5MTVfc2VsZnRlc3QuaCIKPiAgIAo+IEBAIC01NjUsNiArNTY2LDQ3IEBAIHN0YXRp YyBpbnQgdGVzdF9pcGModm9pZCAqYXJnKQo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiAr c3RhdGljIGludCB0ZXN0X3RpbWVyKHZvaWQgKmFyZykKPiArewo+ICsJc3RydWN0IGk5MTVfc3df ZmVuY2UgKmZlbmNlOwo+ICsJdW5zaWduZWQgbG9uZyB0YXJnZXQsIGRlbGF5Owo+ICsKPiArCWZl bmNlID0gaTkxNV9zd19mZW5jZV9jcmVhdGVfdGltZXIodGFyZ2V0ID0gamlmZmllcywgR0ZQX0tF Uk5FTCk7Cj4gKwlpZiAoIWk5MTVfc3dfZmVuY2VfZG9uZShmZW5jZSkpIHsKPiArCQlwcl9lcnIo IkZlbmNlIHdpdGggaW1tZWRpYXRlIGV4cGlyYXRpb24gbm90IHNpZ25hbGVkXG4iKTsKPiArCQln b3RvIGVycjsKPiArCX0KPiArCWk5MTVfc3dfZmVuY2VfdGltZXJfZmx1c2goZmVuY2UpOwo+ICsK PiArCWZvcl9lYWNoX3ByaW1lX251bWJlcihkZWxheSwgSFovMikgewo+ICsJCWZlbmNlID0gaTkx NV9zd19mZW5jZV9jcmVhdGVfdGltZXIodGFyZ2V0ID0gamlmZmllcyArIGRlbGF5LAo+ICsJCQkJ CQkgICBHRlBfS0VSTkVMKTsKPiArCQlpZiAoaTkxNV9zd19mZW5jZV9kb25lKGZlbmNlKSkgewo+ ICsJCQlwcl9lcnIoIkZlbmNlIHdpdGggZnV0dXJlIGV4cGlyYXRpb24gKCVsdSBqaWZmaWVzKSBh bHJlYWR5IHNpZ25hbGVkXG4iLCBkZWxheSk7Cj4gKwkJCWdvdG8gZXJyOwo+ICsJCX0KPiArCj4g KwkJaTkxNV9zd19mZW5jZV93YWl0KGZlbmNlKTsKPiArCQlpZiAoIWk5MTVfc3dfZmVuY2VfZG9u ZShmZW5jZSkpIHsKPiArCQkJcHJfZXJyKCJGZW5jZSBub3Qgc2lnbmFsZWQgYWZ0ZXIgd2FpdFxu Iik7Cj4gKwkJCWdvdG8gZXJyOwo+ICsJCX0KPiArCQlpZiAodGltZV9iZWZvcmUoamlmZmllcywg dGFyZ2V0KSkgewo+ICsJCQlwcl9lcnIoIkZlbmNlIHNpZ25hbGVkIHRvbyBlYXJseSwgdGFyZ2V0 PSVsdSwgbm93PSVsdVxuIiwKPiArCQkJICAgICAgIHRhcmdldCwgamlmZmllcyk7Cj4gKwkJCWdv dG8gZXJyOwo+ICsJCX0KPiArCj4gKwkJaTkxNV9zd19mZW5jZV90aW1lcl9mbHVzaChmZW5jZSk7 Cj4gKwl9Cj4gKwo+ICsJcmV0dXJuIDA7Cj4gKwo+ICtlcnI6Cj4gKwlpOTE1X3N3X2ZlbmNlX3Rp bWVyX2ZsdXNoKGZlbmNlKTsKPiArCXJldHVybiAtRUlOVkFMOwo+ICt9Cj4gKwo+ICAgaW50IGk5 MTVfc3dfZmVuY2VfbW9ja19zZWxmdGVzdHModm9pZCkKPiAgIHsKPiAgIAlzdGF0aWMgY29uc3Qg c3RydWN0IGk5MTVfc3VidGVzdCB0ZXN0c1tdID0gewo+IEBAIC01NzYsNiArNjE4LDcgQEAgaW50 IGk5MTVfc3dfZmVuY2VfbW9ja19zZWxmdGVzdHModm9pZCkKPiAgIAkJU1VCVEVTVCh0ZXN0X0Nf QUIpLAo+ICAgCQlTVUJURVNUKHRlc3RfY2hhaW4pLAo+ICAgCQlTVUJURVNUKHRlc3RfaXBjKSwK PiArCQlTVUJURVNUKHRlc3RfdGltZXIpLAo+ICAgCX07Cj4gICAKPiAgIAlyZXR1cm4gaTkxNV9z dWJ0ZXN0cyh0ZXN0cywgTlVMTCk7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=