From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH v2 3/7] drm/i915/execlists: Make submission
 tasklet hardirq safe
Date: Tue, 8 May 2018 18:45:44 +0100
Message-ID: <90c47ef0-7206-60fa-5103-396c78686bdb@linux.intel.com>
References: <20180507135731.10587-1-chris@chris-wilson.co.uk>
 <20180507135731.10587-3-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id CEC376EB0D
 for <intel-gfx@lists.freedesktop.org>; Tue,  8 May 2018 17:45:46 +0000 (UTC)
In-Reply-To: <20180507135731.10587-3-chris@chris-wilson.co.uk>
Content-Language: en-GB
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDA3LzA1LzIwMTggMTQ6NTcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBQcmVwYXJlIHRvIGFs
bG93IHRoZSBleGVjbGlzdHMgc3VibWlzc2lvbiB0byBiZSBydW4gZnJvbSB1bmRlcm5lYXRoIGEK
PiBoYXJkaXJxIHRpbWVyIGNvbnRleHQgKGFuZCBub3QganVzdCB0aGUgY3VycmVudCBzb2Z0aXJx
IGNvbnRleHQpIGFzIGlzCj4gcmVxdWlyZWQgZm9yIGZhc3QgcHJlZW1wdGlvbiByZXNldHMgYW5k
IGNvbnRleHQgc3dpdGNoZXMuCj4gCj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29uIDxjaHJp
c0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl
bF9scmMuYyB8IDQyICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gICAxIGZpbGUg
Y2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2xyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5
MTUvaW50ZWxfbHJjLmMKPiBpbmRleCBmOWY0MDY0ZGVjMGUuLjE1YzM3M2VhNWI3ZSAxMDA2NDQK
PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+ICsrKyBiL2RyaXZlcnMv
Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gQEAgLTM1NywxMCArMzU3LDEzIEBAIGV4ZWNsaXN0
c191bndpbmRfaW5jb21wbGV0ZV9yZXF1ZXN0cyhzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0
cyAqZXhlY2xpc3RzKQo+ICAgewo+ICAgCXN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSA9
Cj4gICAJCWNvbnRhaW5lcl9vZihleGVjbGlzdHMsIHR5cGVvZigqZW5naW5lKSwgZXhlY2xpc3Rz
KTsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwo+ICsJc3Bpbl9sb2NrX2lycXNhdmUoJmVu
Z2luZS0+dGltZWxpbmUubG9jaywgZmxhZ3MpOwo+ICAgCj4gLQlzcGluX2xvY2tfaXJxKCZlbmdp
bmUtPnRpbWVsaW5lLmxvY2spOwo+ICAgCV9fdW53aW5kX2luY29tcGxldGVfcmVxdWVzdHMoZW5n
aW5lKTsKPiAtCXNwaW5fdW5sb2NrX2lycSgmZW5naW5lLT50aW1lbGluZS5sb2NrKTsKPiArCj4g
KwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsK
PiAgIH0KPiAgIAo+ICAgc3RhdGljIGlubGluZSB2b2lkCj4gQEAgLTU1NCw3ICs1NTcsNyBAQCBz
dGF0aWMgdm9pZCBpbmplY3RfcHJlZW1wdF9jb250ZXh0KHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg
KmVuZ2luZSkKPiAgIAlleGVjbGlzdHNfc2V0X2FjdGl2ZSgmZW5naW5lLT5leGVjbGlzdHMsIEVY
RUNMSVNUU19BQ1RJVkVfUFJFRU1QVCk7Cj4gICB9Cj4gICAKPiAtc3RhdGljIHZvaWQgZXhlY2xp
c3RzX2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICtzdGF0aWMgYm9v
bCBfX2V4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAg
IHsKPiAgIAlzdHJ1Y3QgaW50ZWxfZW5naW5lX2V4ZWNsaXN0cyAqIGNvbnN0IGV4ZWNsaXN0cyA9
ICZlbmdpbmUtPmV4ZWNsaXN0czsKPiAgIAlzdHJ1Y3QgZXhlY2xpc3RfcG9ydCAqcG9ydCA9IGV4
ZWNsaXN0cy0+cG9ydDsKPiBAQCAtNTY0LDYgKzU2Nyw4IEBAIHN0YXRpYyB2b2lkIGV4ZWNsaXN0
c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAlzdHJ1Y3QgcmJf
bm9kZSAqcmI7Cj4gICAJYm9vbCBzdWJtaXQgPSBmYWxzZTsKPiAgIAo+ICsJbG9ja2RlcF9hc3Nl
cnRfaGVsZCgmZW5naW5lLT50aW1lbGluZS5sb2NrKTsKPiArCj4gICAJLyogSGFyZHdhcmUgc3Vi
bWlzc2lvbiBpcyB0aHJvdWdoIDIgcG9ydHMuIENvbmNlcHR1YWxseSBlYWNoIHBvcnQKPiAgIAkg
KiBoYXMgYSAoUklOR19TVEFSVCwgUklOR19IRUFELCBSSU5HX1RBSUwpIHR1cGxlLiBSSU5HX1NU
QVJUIGlzCj4gICAJICogc3RhdGljIGZvciBhIGNvbnRleHQsIGFuZCB1bmlxdWUgdG8gZWFjaCwg
c28gd2Ugb25seSBleGVjdXRlCj4gQEAgLTU4NSw3ICs1OTAsNiBAQCBzdGF0aWMgdm9pZCBleGVj
bGlzdHNfZGVxdWV1ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJICogYW5k
IGNvbnRleHQgc3dpdGNoZXMpIHN1Ym1pc3Npb24uCj4gICAJICovCj4gICAKPiAtCXNwaW5fbG9j
a19pcnEoJmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gICAJcmIgPSBleGVjbGlzdHMtPmZpcnN0
Owo+ICAgCUdFTV9CVUdfT04ocmJfZmlyc3QoJmV4ZWNsaXN0cy0+cXVldWUpICE9IHJiKTsKPiAg
IAo+IEBAIC02MDAsNyArNjA0LDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3Ry
dWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQkJCQkJRVhFQ0xJU1RTX0FDVElWRV9V
U0VSKSk7Cj4gICAJCUdFTV9CVUdfT04oIXBvcnRfY291bnQoJnBvcnRbMF0pKTsKPiAgIAkJaWYg
KHBvcnRfY291bnQoJnBvcnRbMF0pID4gMSkKPiAtCQkJZ290byB1bmxvY2s7Cj4gKwkJCXJldHVy
biBmYWxzZTsKPiAgIAo+ICAgCQkvKgo+ICAgCQkgKiBJZiB3ZSB3cml0ZSB0byBFTFNQIGEgc2Vj
b25kIHRpbWUgYmVmb3JlIHRoZSBIVyBoYXMgaGFkCj4gQEAgLTYxMCwxMSArNjE0LDExIEBAIHN0
YXRpYyB2b2lkIGV4ZWNsaXN0c19kZXF1ZXVlKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2lu
ZSkKPiAgIAkJICogdGhlIEhXIHRvIGluZGljYXRlIHRoYXQgaXQgaGFzIGhhZCBhIGNoYW5jZSB0
byByZXNwb25kLgo+ICAgCQkgKi8KPiAgIAkJaWYgKCFleGVjbGlzdHNfaXNfYWN0aXZlKGV4ZWNs
aXN0cywgRVhFQ0xJU1RTX0FDVElWRV9IV0FDSykpCj4gLQkJCWdvdG8gdW5sb2NrOwo+ICsJCQly
ZXR1cm4gZmFsc2U7Cj4gICAKPiAgIAkJaWYgKG5lZWRfcHJlZW1wdChlbmdpbmUsIGxhc3QsIGV4
ZWNsaXN0cy0+cXVldWVfcHJpb3JpdHkpKSB7Cj4gICAJCQlpbmplY3RfcHJlZW1wdF9jb250ZXh0
KGVuZ2luZSk7Cj4gLQkJCWdvdG8gdW5sb2NrOwo+ICsJCQlyZXR1cm4gZmFsc2U7Cj4gICAJCX0K
PiAgIAo+ICAgCQkvKgo+IEBAIC02MzksNyArNjQzLDcgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3Rz
X2RlcXVldWUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCQkgKiBwcmlvcml0
aWVzIG9mIHRoZSBwb3J0cyBoYXZlbid0IGJlZW4gc3dpdGNoLgo+ICAgCQkgKi8KPiAgIAkJaWYg
KHBvcnRfY291bnQoJnBvcnRbMV0pKQo+IC0JCQlnb3RvIHVubG9jazsKPiArCQkJcmV0dXJuIGZh
bHNlOwo+ICAgCj4gICAJCS8qCj4gICAJCSAqIFdhSWRsZUxpdGVSZXN0b3JlOmJkdyxza2wKPiBA
QCAtNzQ0LDEzICs3NDgsMjUgQEAgc3RhdGljIHZvaWQgZXhlY2xpc3RzX2RlcXVldWUoc3RydWN0
IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCS8qIFdlIG11c3QgYWx3YXlzIGtlZXAgdGhl
IGJlYXN0IGZlZCBpZiB3ZSBoYXZlIHdvcmsgcGlsZWQgdXAgKi8KPiAgIAlHRU1fQlVHX09OKGV4
ZWNsaXN0cy0+Zmlyc3QgJiYgIXBvcnRfaXNzZXQoZXhlY2xpc3RzLT5wb3J0KSk7Cj4gICAKPiAt
dW5sb2NrOgo+IC0Jc3Bpbl91bmxvY2tfaXJxKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+IC0K
PiAtCWlmIChzdWJtaXQpIHsKPiArCS8qIFJlLWV2YWx1YXRlIHRoZSBleGVjdXRpbmcgY29udGV4
dCBzZXR1cCBhZnRlciBlYWNoIHByZWVtcHRpdmUga2ljayAqLwo+ICsJaWYgKGxhc3QpCj4gICAJ
CWV4ZWNsaXN0c191c2VyX2JlZ2luKGV4ZWNsaXN0cywgZXhlY2xpc3RzLT5wb3J0KTsKPiArCj4g
KwlyZXR1cm4gc3VibWl0Owo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZCBleGVjbGlzdHNfZGVxdWV1
ZShzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9l
bmdpbmVfZXhlY2xpc3RzICogY29uc3QgZXhlY2xpc3RzID0gJmVuZ2luZS0+ZXhlY2xpc3RzOwo+
ICsJdW5zaWduZWQgbG9uZyBmbGFnczsKPiArCWJvb2wgc3VibWl0Owo+ICsKPiArCXNwaW5fbG9j
a19pcnFzYXZlKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2ssIGZsYWdzKTsKPiArCXN1Ym1pdCA9IF9f
ZXhlY2xpc3RzX2RlcXVldWUoZW5naW5lKTsKPiArCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmVu
Z2luZS0+dGltZWxpbmUubG9jaywgZmxhZ3MpOwo+ICsKPiArCWlmIChzdWJtaXQpCj4gICAJCWV4
ZWNsaXN0c19zdWJtaXRfcG9ydHMoZW5naW5lKTsKPiAtCX0KCkFjdHVhbGx5LCBoYXZpbmcgcmVh
ZCB0aGUgZ3VjIHZlcnNpb24sIHdoeSBkb2Vzbid0IApleGVjbGlzdHNfc3VibWl0X3BvcnRzIG5l
ZWQgdG8gYmUgaGFyZGlycSBzYWZlPwoKUmVnYXJkcywKClR2cnRrbwoKPiAgIAo+ICAgCUdFTV9C
VUdfT04ocG9ydF9pc3NldChleGVjbGlzdHMtPnBvcnQpICYmCj4gICAJCSAgICFleGVjbGlzdHNf
aXNfYWN0aXZlKGV4ZWNsaXN0cywgRVhFQ0xJU1RTX0FDVElWRV9VU0VSKSk7Cj4gCl9fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n
IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk
ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=