From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 03/11] drm/i915/execlists: Suppress redundant preemption Date: Thu, 28 Feb 2019 13:11:48 +0000 Message-ID: <917f2c43-3322-4e28-b020-cfc82ff9ea4e@linux.intel.com> References: <20190226102404.29153-1-chris@chris-wilson.co.uk> <20190226102404.29153-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id B7AEE6E14D for ; Thu, 28 Feb 2019 13:11:49 +0000 (UTC) In-Reply-To: <20190226102404.29153-3-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI2LzAyLzIwMTkgMTA6MjMsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiB1bndpbmRpbmcg dGhlIGFjdGl2ZSByZXF1ZXN0IHdlIGdpdmUgaXQgYSBzbWFsbCAobGltaXRlZCB0byBpbnRlcm5h bAo+IHByaW9yaXR5IGxldmVscykgYm9vc3QgdG8gcHJldmVudCBpdCBmcm9tIGJlaW5nIGdhenVt cGVkIGEgc2Vjb25kIHRpbWUuCj4gSG93ZXZlciwgdGhpcyBtZWFucyB0aGF0IGl0IGNhbiBiZSBw cm9tb3RlZCB0byBhYm92ZSB0aGUgcmVxdWVzdCB0aGF0Cj4gdHJpZ2dlcmVkIHRoZSBwcmVlbXB0 aW9uIHJlcXVlc3QsIGNhdXNpbmcgYSBwcmVlbXB0LXRvLWlkbGUgY3ljbGUgZm9yIG5vCj4gY2hh bmdlLiBXZSBjYW4gYXZvaWQgdGhpcyBpZiB3ZSB0YWtlIHRoZSBib29zdCBpbnRvIGFjY291bnQg d2hlbgo+IGNoZWNraW5nIGlmIHRoZSBwcmVlbXB0aW9uIHJlcXVlc3QgaXMgdmFsaWQuCj4gCj4g djI6IEFmdGVyIHByZWVtcHRpb24gdGhlIGFjdGl2ZSByZXF1ZXN0IHdpbGwgYmUgYWZ0ZXIgdGhl IHByZWVtcHRlZSBpZgo+IHRoZXkgZW5kIHVwIHdpdGggZXF1YWwgcHJpb3JpdHkuCj4gCj4gdjM6 IFR2cnRrbyBwb2ludGVkIG91dCB0aGF0IHRoaXMsIHRoZSBleGlzdGluZyBsb2dpYywgbWFrZXMK PiBJOTE1X1BSSU9SSVRZX1dBSVQgbm9uLXByZWVtcHRpYmxlLiBEb2N1bWVudCB0aGlzIGludGVy ZXN0aW5nIHF1aXJrIQo+IAo+IHY0OiBQcm92ZSBUdnJ0a28gd2FzIHJpZ2h0IGFib3V0IFdBSVQg YmVpbmcgbm9uLXByZWVtcHRpYmxlIGFuZCB0ZXN0IGl0Lgo+IHY1OiBFeGNlcHQgbm90IGFsbCBw cmlvcml0aWVzIHdlcmUgbWFkZSBlcXVhbCwgYW5kIHRoZSBXQUlUIG5vdCBwcmVlbXB0aW5nCj4g aXMgb25seSBpZiB3ZSBzdGFydCBvZmYgYXMgIU5FV0NMSUVOVC4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVHZydGtvIFVy c3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jIHwgMzggKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0K PiAgIDEgZmlsZSBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggMGUyMGYzYmM4MjEwLi5kYmExOWJhZjY4 MDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xNjQsNiArMTY0LDggQEAK PiAgICNkZWZpbmUgV0FfVEFJTF9EV09SRFMgMgo+ICAgI2RlZmluZSBXQV9UQUlMX0JZVEVTIChz aXplb2YodTMyKSAqIFdBX1RBSUxfRFdPUkRTKQo+ICAgCj4gKyNkZWZpbmUgQUNUSVZFX1BSSU9S SVRZIChJOTE1X1BSSU9SSVRZX05FV0NMSUVOVCkKPiArCj4gICBzdGF0aWMgaW50IGV4ZWNsaXN0 c19jb250ZXh0X2RlZmVycmVkX2FsbG9jKHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4g ICAJCQkJCSAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJCQkJCSAgICBz dHJ1Y3QgaW50ZWxfY29udGV4dCAqY2UpOwo+IEBAIC0xOTAsOCArMTkyLDMwIEBAIHN0YXRpYyBp bmxpbmUgaW50IHJxX3ByaW8oY29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICAKPiAg IHN0YXRpYyBpbnQgZWZmZWN0aXZlX3ByaW8oY29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEp Cj4gICB7Cj4gKwlpbnQgcHJpbyA9IHJxX3ByaW8ocnEpOwo+ICsKPiArCS8qCj4gKwkgKiBPbiB1 bndpbmRpbmcgdGhlIGFjdGl2ZSByZXF1ZXN0LCB3ZSBnaXZlIGl0IGEgcHJpb3JpdHkgYnVtcAo+ ICsJICogZXF1aXZhbGVudCB0byBhIGZyZXNobHkgc3VibWl0dGVkIHJlcXVlc3QuIFRoaXMgcHJv dGVjdHMgaXQgZnJvbQo+ICsJICogYmVpbmcgZ2F6dW1wZWQgYWdhaW4sIGJ1dCBpdCB3b3VsZCBi ZSBwcmVmZXJhYmxlIGlmIHdlIGRpZG4ndAo+ICsJICogbGV0IGl0IGJlIGdhenVtcGVkIGluIHRo ZSBmaXJzdCBwbGFjZSEKPiArCSAqCj4gKwkgKiBTZWUgX191bndpbmRfaW5jb21wbGV0ZV9yZXF1 ZXN0cygpCj4gKwkgKi8KPiArCWlmICh+cHJpbyAmIEFDVElWRV9QUklPUklUWSAmJiBfX2k5MTVf cmVxdWVzdF9oYXNfc3RhcnRlZChycSkpIHsKPiArCQkvKgo+ICsJCSAqIEFmdGVyIHByZWVtcHRp b24sIHdlIGluc2VydCB0aGUgYWN0aXZlIHJlcXVlc3QgYXQgdGhlCj4gKwkJICogZW5kIG9mIHRo ZSBuZXcgcHJpb3JpdHkgbGV2ZWwuIFRoaXMgbWVhbnMgdGhhdCB3ZSB3aWxsIGJlCj4gKwkJICog X2xvd2VyXyBwcmlvcml0eSB0aGFuIHRoZSBwcmVlbXB0ZWUgYWxsIHRoaW5ncyBlcXVhbCAoYW5k Cj4gKwkJICogc28gdGhlIHByZWVtcHRpb24gaXMgdmFsaWQpLCBzbyBhZGp1c3Qgb3VyIGNvbXBh cmlzb24KPiArCQkgKiBhY2NvcmRpbmdseS4KPiArCQkgKi8KPiArCQlwcmlvIHw9IEFDVElWRV9Q UklPUklUWTsKPiArCQlwcmlvLS07Cj4gKwl9Cj4gKwo+ICAgCS8qIFJlc3RyaWN0IG1lcmUgV0FJ VCBib29zdHMgZnJvbSB0cmlnZ2VyaW5nIHByZWVtcHRpb24gKi8KPiAtCXJldHVybiBycV9wcmlv KHJxKSB8IF9fTk9fUFJFRU1QVElPTjsKPiArCXJldHVybiBwcmlvIHwgX19OT19QUkVFTVBUSU9O Owo+ICAgfQo+ICAgCj4gICBzdGF0aWMgaW50IHF1ZXVlX3ByaW8oY29uc3Qgc3RydWN0IGludGVs X2VuZ2luZV9leGVjbGlzdHMgKmV4ZWNsaXN0cykKPiBAQCAtMzU5LDcgKzM4Myw3IEBAIF9fdW53 aW5kX2luY29tcGxldGVfcmVxdWVzdHMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ ICAgewo+ICAgCXN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxLCAqcm4sICphY3RpdmUgPSBOVUxMOwo+ ICAgCXN0cnVjdCBsaXN0X2hlYWQgKnVuaW5pdGlhbGl6ZWRfdmFyKHBsKTsKPiAtCWludCBwcmlv ID0gSTkxNV9QUklPUklUWV9JTlZBTElEIHwgSTkxNV9QUklPUklUWV9ORVdDTElFTlQ7Cj4gKwlp bnQgcHJpbyA9IEk5MTVfUFJJT1JJVFlfSU5WQUxJRCB8IEFDVElWRV9QUklPUklUWTsKPiAgIAo+ ICAgCWxvY2tkZXBfYXNzZXJ0X2hlbGQoJmVuZ2luZS0+dGltZWxpbmUubG9jayk7Cj4gICAKPiBA QCAtMzkwLDkgKzQxNCwxNSBAQCBfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKHN0cnVjdCBp bnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIAkgKiBUaGUgYWN0aXZlIHJlcXVlc3QgaXMgbm93 IGVmZmVjdGl2ZWx5IHRoZSBzdGFydCBvZiBhIG5ldyBjbGllbnQKPiAgIAkgKiBzdHJlYW0sIHNv IGdpdmUgaXQgdGhlIGVxdWl2YWxlbnQgc21hbGwgcHJpb3JpdHkgYnVtcCB0byBwcmV2ZW50Cj4g ICAJICogaXQgYmVpbmcgZ2F6dW1wZWQgYSBzZWNvbmQgdGltZSBieSBhbm90aGVyIHBlZXIuCj4g KwkgKgo+ICsJICogT25lIGNvbnNlcXVlbmNlIG9mIHRoaXMgcHJlZW1wdGlvbiBib29zdCBpcyB0 aGF0IHdlIG1heSBqdW1wCj4gKwkgKiBvdmVyIGxlc3NlciBwcmlvcml0aWVzIChzdWNoIGFzIEk5 MTVfUFJJT1JJVFlfV0FJVCksIGVmZmVjdGl2ZWx5Cj4gKwkgKiBtYWtpbmcgdGhvc2UgcHJpb3Jp dGllcyBub24tcHJlZW1wdGlibGUuIFRoZXkgd2lsbCBiZSBtb3ZlZCBmb3J3YXJkCgpBZnRlciB0 aGUgcHJldmlvdXMgcGF0Y2ggd2FpdCBwcmlvcml0eSBpcyBub24tcHJlZW1wdGlibGUgYnkgZGVm aW5pdGlvbiAKbWFraW5nIHRoaXMgc3VnZ2VzdGlvbiBwcmVlbXB0aW9uIGJvb3N0IGlzIG1ha2lu ZyBpdCBzbyBub3QgYWNjdXJhdGUuCgo+ICsJICogaW4gdGhlIHByaW9yaXR5IHF1ZXVlLCBidXQg dGhleSB3aWxsIG5vdCBnYWluIGltbWVkaWF0ZSBhY2Nlc3MgdG8KPiArCSAqIHRoZSBHUFUuCj4g ICAJICovCj4gLQlpZiAoIShwcmlvICYgSTkxNV9QUklPUklUWV9ORVdDTElFTlQpKSB7Cj4gLQkJ cHJpbyB8PSBJOTE1X1BSSU9SSVRZX05FV0NMSUVOVDsKPiArCWlmICh+cHJpbyAmIEFDVElWRV9Q UklPUklUWSAmJiBfX2k5MTVfcmVxdWVzdF9oYXNfc3RhcnRlZChhY3RpdmUpKSB7CgpXaGF0IGlz IHRoZSBpbXBvcnRhbmNlIG9mIHRoZSBoYXNfc3RhcnRlZCBjaGVjaz8gSGFzbid0IHRoZSBhY3Rp dmUgCnJlcXVlc3QgYmVlbiBydW5uaW5nIGJ5IGRlZmluaXRpb24/Cgo+ICsJCXByaW8gfD0gQUNU SVZFX1BSSU9SSVRZOwo+ICAgCQlhY3RpdmUtPnNjaGVkLmF0dHIucHJpb3JpdHkgPSBwcmlvOwo+ ICAgCQlsaXN0X21vdmVfdGFpbCgmYWN0aXZlLT5zY2hlZC5saW5rLAo+ICAgCQkJICAgICAgIGk5 MTVfc2NoZWRfbG9va3VwX3ByaW9saXN0KGVuZ2luZSwgcHJpbykpOwo+IAoKUmVnYXJkcywKClR2 cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=