From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 08/11] drm/i915/uc: Simplify firmware path
 handling
Date: Mon, 13 Mar 2017 13:39:45 +0000
Message-ID: <923708c1-6574-fdbc-ad63-2be0eb21845d@linux.intel.com>
References: <20170313131508.24439-1-arkadiusz.hiler@intel.com>
 <20170313131508.24439-9-arkadiusz.hiler@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 062FB6E514
 for <intel-gfx@lists.freedesktop.org>; Mon, 13 Mar 2017 13:39:52 +0000 (UTC)
In-Reply-To: <20170313131508.24439-9-arkadiusz.hiler@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDEzLzAzLzIwMTcgMTM6MTUsIEFya2FkaXVzeiBIaWxlciB3cm90ZToKPiBDdXJyZW50bHkg
ZnctPnBhdGggdmFsdWVzIGNhbiByZXByZXNlbnQgb25lIG9mIHRocmVlIHBvc3NpYmxlIHN0YXRl
czoKPgo+ICAxKSBOVUxMIC0gZGV2aWNlIHdpdGhvdXQgdGhlIHVDCj4gIDIpICdcMCcgLSBkZXZp
Y2Ugd2l0aCB0aGUgdUMgYnV0IGhhdmUgbm8gZmlybXdhcmUKPiAgMykgZWxzZSAtIGRldmljZSB3
aXRoIHRoZSB1QyBhbmQgd2UgaGF2ZSBmaXJtd2FyZQo+Cj4gU2Vjb25kIGNhc2UgaXMgdXNlZCBv
bmx5IHRvIFdBUk4gYXQgYSBsYXRlciBzdGFnZS4KPgo+IFdlIGNhbiBXQVJOIHJpZ2h0IGF3YXkg
YW5kIG1lcmdlIGNhc2VzIDEgYW5kIDIuCj4KPiBDb2RlIGNhbiBiZSBldmVuIGZ1cnRoZXIgc2lt
cGxpZmllZCBhbmQgY29tbW9uIChIdUMvR3VDIGxvZ2ljKSBoYXBwZW5pbmcKPiByaWdodCBiZWZv
cmUgdGhlIGZldGNoIGNhbiBiZSBvZmZsb2FkZWQgdG8gdGhlIGNvbW1vbiBmdW5jdGlvbi4KPgo+
IHYyOiBmZXdlciB0ZW1wb3JhcnkgdmFyaWFibGVzLCBtb3JlIHN0cmFpZ2h0Zm9yd2FyZCBmbG93
IChNLiBXYWpkZWN6a28pCj4gdjM6IERSTV9FUlJPUiBpbnN0ZWFkIG9mIFdBUk4gKE0uIFdhamRl
Y3prbykKPiB2NDogY29kaW5nIHN0YW5kYXJkIChKLiBMYWh0aW5lbikKPiB2NTogbm9uLXRyaXZp
YWwgcmViYXNlCj4gdjY6IHJlbW92ZSBwYXRoIGNoZWNrLCB3ZSBhcmUgY2hlY2tpbmcgZmV0Y2gg
c3RhdHVzIChNLiBXYWpkZWN6a28pCj4KPiBDYzogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEuc3Jp
dmF0c2FAaW50ZWwuY29tPgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50
ZWwuY29tPgo+IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVsLmNv
bT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4g
Q2M6IEpvb25hcyBMYWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBT
aWduZWQtb2ZmLWJ5OiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+
Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYyB8IDM2ICsr
KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9odWMuYyAgICAgICAgfCAyMSArKysrKystLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3VjLmMgICAgICAgICB8ICA0ICsrKy0KPiAgMyBmaWxlcyBjaGFuZ2Vk
LCAyMCBpbnNlcnRpb25zKCspLCA0MSBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2
ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfbG9hZGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9ndWNfbG9hZGVyLmMKPiBpbmRleCAwYTI5YzFiLi5kNzMxZjY4IDEwMDY0NAo+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+ICsrKyBiL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2FkZXIuYwo+IEBAIC0zNjgsMTMgKzM2OCw2IEBA
IGludCBpbnRlbF9ndWNfaW5pdF9odyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gIAkJaW50ZWxf
dWNfZndfc3RhdHVzX3JlcHIoZ3VjLT5mdy5mZXRjaF9zdGF0dXMpLAo+ICAJCWludGVsX3VjX2Z3
X3N0YXR1c19yZXByKGd1Yy0+ZncubG9hZF9zdGF0dXMpKTsKPgo+IC0JaWYgKCFmd19wYXRoKSB7
Cj4gLQkJcmV0dXJuIC1FTlhJTzsKPiAtCX0gZWxzZSBpZiAoKmZ3X3BhdGggPT0gJ1wwJykgewo+
IC0JCVdBUk4oMSwgIk5vIEd1QyBmaXJtd2FyZSBrbm93biBmb3IgdGhpcyBwbGF0Zm9ybSFcbiIp
Owo+IC0JCXJldHVybiAtRU5PREVWOwo+IC0JfQo+IC0KPiAgCWlmIChndWMtPmZ3LmZldGNoX3N0
YXR1cyAhPSBJTlRFTF9VQ19GSVJNV0FSRV9TVUNDRVNTKQo+ICAJCXJldHVybiAtRUlPOwo+Cj4g
QEAgLTM5OSw3ICszOTIsNiBAQCBpbnQgaW50ZWxfZ3VjX2luaXRfaHcoc3RydWN0IGludGVsX2d1
YyAqZ3VjKQo+ICAJcmV0dXJuIDA7Cj4gIH0KPgo+IC0KPiAgLyoqCj4gICAqIGludGVsX2d1Y19p
bml0X2Z3KCkgLSBzZWxlY3QgYW5kIHByZXBhcmUgZmlybXdhcmUgZm9yIGxvYWRpbmcKPiAgICog
QGd1YzoJaW50ZWxfZ3VjIHN0cnVjdAo+IEBAIC00MTIsMzcgKzQwNCwzMSBAQCBpbnQgaW50ZWxf
Z3VjX2luaXRfaHcoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ICB2b2lkIGludGVsX2d1Y19pbml0
X2Z3KHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZh
dGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiAtCWNvbnN0IGNoYXIgKmZ3X3BhdGg7
Cj4gKwo+ICsJZ3VjLT5mdy5wYXRoID0gTlVMTDsKPiArCWd1Yy0+ZncuZmV0Y2hfc3RhdHVzID0g
SU5URUxfVUNfRklSTVdBUkVfTk9ORTsKPiArCWd1Yy0+ZncubG9hZF9zdGF0dXMgPSBJTlRFTF9V
Q19GSVJNV0FSRV9OT05FOwo+ICsJZ3VjLT5mdy5mdyA9IElOVEVMX1VDX0ZXX1RZUEVfR1VDOwoK
SWYgbm90IHRvbyBoYXJkIG9uIHRoZSBzZXJpZXMgYW5kIGFsbCwgbWF5YmUgYmlrZXNoZWQgdGhp
cyBmaWVsZCB0byAidHlwZSIuCgpNb3JlIGltcG9ydGFudGx5LCB0aGlzIGZpZWxkIHdhc24ndCBn
ZXR0aW5nIHNldCBiZWZvcmU/IEkgZG9uJ3Qgc2VlIHRoYXQgCml0IGdvdCBtb3ZlZCBpbiB0aGlz
IGRpZmYuCgo+Cj4gIAlpZiAoSVNfU0tZTEFLRShkZXZfcHJpdikpIHsKPiAtCQlmd19wYXRoID0g
STkxNV9TS0xfR1VDX1VDT0RFOwo+ICsJCWd1Yy0+ZncucGF0aCA9IEk5MTVfU0tMX0dVQ19VQ09E
RTsKPiAgCQlndWMtPmZ3Lm1ham9yX3Zlcl93YW50ZWQgPSBTS0xfRldfTUFKT1I7Cj4gIAkJZ3Vj
LT5mdy5taW5vcl92ZXJfd2FudGVkID0gU0tMX0ZXX01JTk9SOwo+ICAJfSBlbHNlIGlmIChJU19C
Uk9YVE9OKGRldl9wcml2KSkgewo+IC0JCWZ3X3BhdGggPSBJOTE1X0JYVF9HVUNfVUNPREU7Cj4g
KwkJZ3VjLT5mdy5wYXRoID0gSTkxNV9CWFRfR1VDX1VDT0RFOwo+ICAJCWd1Yy0+ZncubWFqb3Jf
dmVyX3dhbnRlZCA9IEJYVF9GV19NQUpPUjsKPiAgCQlndWMtPmZ3Lm1pbm9yX3Zlcl93YW50ZWQg
PSBCWFRfRldfTUlOT1I7Cj4gIAl9IGVsc2UgaWYgKElTX0tBQllMQUtFKGRldl9wcml2KSkgewo+
IC0JCWZ3X3BhdGggPSBJOTE1X0tCTF9HVUNfVUNPREU7Cj4gKwkJZ3VjLT5mdy5wYXRoID0gSTkx
NV9LQkxfR1VDX1VDT0RFOwo+ICAJCWd1Yy0+ZncubWFqb3JfdmVyX3dhbnRlZCA9IEtCTF9GV19N
QUpPUjsKPiAgCQlndWMtPmZ3Lm1pbm9yX3Zlcl93YW50ZWQgPSBLQkxfRldfTUlOT1I7Cj4gIAl9
IGVsc2Ugewo+IC0JCWZ3X3BhdGggPSAiIjsJLyogdW5rbm93biBkZXZpY2UgKi8KPiArCQlEUk1f
RVJST1IoIk5vIEd1QyBmaXJtd2FyZSBrbm93biBmb3IgcGxhdGZvcm0gd2l0aCBHdUMhXG4iKTsK
ClF1aWNrIGdsYW5jZSBvdmVyIHRoZSBzZXJpZXMgc3VnZ2VzdHMgaW50ZWxfZ3VjX2luaXRfZncg
aXMgY2FsbGVkIAp1bmNvbmRpdGlvbmFsbHkgZnJvbSBpOTE1X2xvYWRfbW9kZXNldF9pbml0IG1l
YW5pbmcgdGhpcyBlcnJvciBnZXRzIApsb2dnZWQgb24gYWxsIG5vbi1HdUMgcGxhdGZvcm1zPyBJ
IG11c3QgYmUgbWlzc2luZyBzb21ldGhpbmcuLgoKUmVnYXJkcywKClR2cnRrbwoKPiArCQlpOTE1
LmVuYWJsZV9ndWNfbG9hZGluZyA9IDA7Cj4gKwkJcmV0dXJuOwo+ICAJfQo+Cj4gLQlndWMtPmZ3
LnBhdGggPSBmd19wYXRoOwo+IC0JZ3VjLT5mdy5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJN
V0FSRV9OT05FOwo+IC0JZ3VjLT5mdy5sb2FkX3N0YXR1cyA9IElOVEVMX1VDX0ZJUk1XQVJFX05P
TkU7Cj4gLQo+IC0JaWYgKGZ3X3BhdGggPT0gTlVMTCkKPiAtCQlyZXR1cm47Cj4gLQlpZiAoKmZ3
X3BhdGggPT0gJ1wwJykKPiAtCQlyZXR1cm47Cj4gLQo+IC0JZ3VjLT5mdy5mZXRjaF9zdGF0dXMg
PSBJTlRFTF9VQ19GSVJNV0FSRV9QRU5ESU5HOwo+IC0JRFJNX0RFQlVHX0RSSVZFUigiR3VDIGZp
cm13YXJlIHBlbmRpbmcsIHBhdGggJXNcbiIsIGZ3X3BhdGgpOwo+ICAJaW50ZWxfdWNfcHJlcGFy
ZV9mdyhkZXZfcHJpdiwgJmd1Yy0+ZncpOwo+IC0JLyogc3RhdHVzIG11c3Qgbm93IGJlIEZBSUwg
b3IgU1VDQ0VTUyAqLwo+ICB9Cj4KPiAgLyoqCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2h1Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMKPiBp
bmRleCAxNjhhYWIxLi41ZmFkZDU1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2h1Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMKPiBA
QCAtMTU1LDcgKzE1NSw2IEBAIHN0YXRpYyBpbnQgaHVjX3Vjb2RlX3hmZXIoc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICB2b2lkIGludGVsX2h1Y19pbml0X2Z3KHN0cnVjdCBp
bnRlbF9odWMgKmh1YykKPiAgewo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2
ID0gaHVjX3RvX2k5MTUoaHVjKTsKPiAtCWNvbnN0IGNoYXIgKmZ3X3BhdGggPSBOVUxMOwo+Cj4g
IAlodWMtPmZ3LnBhdGggPSBOVUxMOwo+ICAJaHVjLT5mdy5mZXRjaF9zdGF0dXMgPSBJTlRFTF9V
Q19GSVJNV0FSRV9OT05FOwo+IEBAIC0xNjMsMjkgKzE2MiwyMSBAQCB2b2lkIGludGVsX2h1Y19p
bml0X2Z3KHN0cnVjdCBpbnRlbF9odWMgKmh1YykKPiAgCWh1Yy0+ZncuZncgPSBJTlRFTF9VQ19G
V19UWVBFX0hVQzsKPgo+ICAJaWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJZndfcGF0
aCA9IEk5MTVfU0tMX0hVQ19VQ09ERTsKPiArCQlodWMtPmZ3LnBhdGggPSBJOTE1X1NLTF9IVUNf
VUNPREU7Cj4gIAkJaHVjLT5mdy5tYWpvcl92ZXJfd2FudGVkID0gU0tMX0hVQ19GV19NQUpPUjsK
PiAgCQlodWMtPmZ3Lm1pbm9yX3Zlcl93YW50ZWQgPSBTS0xfSFVDX0ZXX01JTk9SOwo+ICAJfSBl
bHNlIGlmIChJU19CUk9YVE9OKGRldl9wcml2KSkgewo+IC0JCWZ3X3BhdGggPSBJOTE1X0JYVF9I
VUNfVUNPREU7Cj4gKwkJaHVjLT5mdy5wYXRoID0gSTkxNV9CWFRfSFVDX1VDT0RFOwo+ICAJCWh1
Yy0+ZncubWFqb3JfdmVyX3dhbnRlZCA9IEJYVF9IVUNfRldfTUFKT1I7Cj4gIAkJaHVjLT5mdy5t
aW5vcl92ZXJfd2FudGVkID0gQlhUX0hVQ19GV19NSU5PUjsKPiAgCX0gZWxzZSBpZiAoSVNfS0FC
WUxBS0UoZGV2X3ByaXYpKSB7Cj4gLQkJZndfcGF0aCA9IEk5MTVfS0JMX0hVQ19VQ09ERTsKPiAr
CQlodWMtPmZ3LnBhdGggPSBJOTE1X0tCTF9IVUNfVUNPREU7Cj4gIAkJaHVjLT5mdy5tYWpvcl92
ZXJfd2FudGVkID0gS0JMX0hVQ19GV19NQUpPUjsKPiAgCQlodWMtPmZ3Lm1pbm9yX3Zlcl93YW50
ZWQgPSBLQkxfSFVDX0ZXX01JTk9SOwo+IC0JfQo+IC0KPiAtCWh1Yy0+ZncucGF0aCA9IGZ3X3Bh
dGg7Cj4gLQo+IC0JaWYgKGZ3X3BhdGggPT0gTlVMTCkKPiArCX0gZWxzZSB7Cj4gKwkJRFJNX0VS
Uk9SKCJObyBIdUMgZmlybXdhcmUga25vd24gZm9yIHBsYXRmb3JtIHdpdGggSHVDIVxuIik7Cj4g
IAkJcmV0dXJuOwo+IC0KPiAtCWh1Yy0+ZncuZmV0Y2hfc3RhdHVzID0gSU5URUxfVUNfRklSTVdB
UkVfUEVORElORzsKPiAtCj4gLQlEUk1fREVCVUdfRFJJVkVSKCJIdUMgZmlybXdhcmUgcGVuZGlu
ZywgcGF0aCAlc1xuIiwgZndfcGF0aCk7Cj4gLQo+IC0JV0FSTihodWMtPmZ3LnBhdGggPT0gTlVM
TCwgIkh1QyBwcmVzZW50IGJ1dCBubyBmdyBwYXRoXG4iKTsKPiArCX0KPgo+ICAJaW50ZWxfdWNf
cHJlcGFyZV9mdyhkZXZfcHJpdiwgJmh1Yy0+ZncpOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91
Yy5jCj4gaW5kZXggNjlmMjFjYy4uNGI4NWEwZiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k
cm0vaTkxNS9pbnRlbF91Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMu
Ywo+IEBAIC0yNjgsOCArMjY4LDEwIEBAIHZvaWQgaW50ZWxfdWNfcHJlcGFyZV9mdyhzdHJ1Y3Qg
ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAlzaXplX3Qgc2l6ZTsKPiAgCWludCBlcnI7
Cj4KPiArCXVjX2Z3LT5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19GSVJNV0FSRV9QRU5ESU5HOwo+
ICsKPiAgCURSTV9ERUJVR19EUklWRVIoImJlZm9yZSByZXF1ZXN0aW5nIGZpcm13YXJlOiB1QyBm
dyBmZXRjaCBzdGF0dXMgJXNcbiIsCj4gLQkJaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIodWNfZnct
PmZldGNoX3N0YXR1cykpOwo+ICsJCQkgaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIodWNfZnctPmZl
dGNoX3N0YXR1cykpOwo+Cj4gIAllcnIgPSByZXF1ZXN0X2Zpcm13YXJlKCZmdywgdWNfZnctPnBh
dGgsICZwZGV2LT5kZXYpOwo+ICAJaWYgKGVycikKPgpfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK