From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 13/13] drm/i915: Update DSPCNTR gamma/csc bits during crtc_enable() Date: Thu, 7 Feb 2019 16:58:22 +0100 Message-ID: <925fef79-d9ce-c22d-2478-a27c9736dd90@linux.intel.com> References: <20190205160848.24662-1-ville.syrjala@linux.intel.com> <20190205160848.24662-14-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id A55996EC89 for ; Thu, 7 Feb 2019 15:58:24 +0000 (UTC) In-Reply-To: <20190205160848.24662-14-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMDUtMDItMjAxOSBvbSAxNzowOCBzY2hyZWVmIFZpbGxlIFN5cmphbGE6Cj4gRnJvbTogVmls bGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPgo+IE9uIGc0eCsg d2UgZGVwZW5kIG9uIHRoZSBwcmltYXJ5IHBsYW5lIERTUENOVFIgZ2FtbWEvY3NjIGVuYWJsZQo+ IGJpdHMgZm9yIHRoZSBwaXBlIGJvdHRvbSBjb2xvci4gVG8gZ3VhcmFudGVlIHRoYXQgdGhvc2Ug YXJlCj4gY29ycmVjdCBhbHJlYWR5IHdoZW4gZW5hYmxpbmcgdGhlIGNydGMgbGV0J3MgZG8gYW4g ZXhwbGljaXQKPiAtPmRpc2FibGVfcGxhbmUoKSBjYWxsIGJlZm9yZSBlbmFibGluZyB0aGUgcGlw ZS4KPgo+IE9uIHNrbCsgdGhpcyB3aWxsIGJlIGhhbmRsZWQgYnkgdGhlIGV4cGxpY2l0IFBJUEVf Qk9UVE9NX0NPTE9SCj4gcmVnaXN0ZXIgd2hpY2ggaXMgYWxyZWFkeSBwYXJ0IG9mIHRoZSBub3Jt YWwgY29sb3IgY29tbWl0IHdlCj4gZG8gZHVyaWduIGNydGMgZW5hYmxlLgo+Cj4gU2lnbmVkLW9m Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAt LS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyAgIHwgIDQgKysrKwo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgfCAxNyArKysrKysrKysrKysrKysr Kwo+ICAyIGZpbGVzIGNoYW5nZWQsIDIxIGluc2VydGlvbnMoKykKPgo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfY29sb3IuYwo+IGluZGV4IDVjNzc4OWU5ZmVkNS4uNzljM2FkYWVmYWRjIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NvbG9yLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9jb2xvci5jCj4gQEAgLTY2Myw2ICs2NjMsMTAgQEAgaW50ZWxf Y29sb3JfYWRkX2FmZmVjdGVkX3BsYW5lcyhzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X2Ny dGNfc3RhdGUpCj4gIAkJaW50ZWxfYXRvbWljX2dldF9vbGRfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0 Yyk7Cj4gIAlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+ICAKPiArCWlmICghbmV3X2NydGNf c3RhdGUtPmJhc2UuYWN0aXZlIHx8Cj4gKwkgICAgZHJtX2F0b21pY19jcnRjX25lZWRzX21vZGVz ZXQoJm5ld19jcnRjX3N0YXRlLT5iYXNlKSkKPiArCQlyZXR1cm4gMDsKCldoeSB0aGUgbmVlZHNf bW9kZXNldCBza2lwPyBXZSB3aWxsIGhhdmUgYWxyZWFkeSBhZGRlZCBhbGwgcGxhbmVzIGFueXdh eSwgYnV0IHN0aWxsLgoKCk9oIHdlbGwsIGFzc3VtaW5nIGl0J3MgZm9yIGEgZ29vZCByZWFzb24K ClJldmlld2VkLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXgu aW50ZWwuY29tPgoKPiAgCWlmIChuZXdfY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlID09IG9sZF9j cnRjX3N0YXRlLT5nYW1tYV9lbmFibGUgJiYKPiAgCSAgICBuZXdfY3J0Y19zdGF0ZS0+Y3NjX2Vu YWJsZSA9PSBvbGRfY3J0Y19zdGF0ZS0+Y3NjX2VuYWJsZSkKPiAgCQlyZXR1cm4gMDsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggYzgwMjA1NWQyM2E2Li5mMzZhYzIz ZjcxOTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTU3MTUs NiArNTcxNSwxNCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9lbmNvZGVyc191cGRhdGVfcGlwZShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gIAl9Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGludGVsX2Rp c2FibGVfcHJpbWFyeV9wbGFuZShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19z dGF0ZSkKPiArewo+ICsJc3RydWN0IGludGVsX2NydGMgKmNydGMgPSB0b19pbnRlbF9jcnRjKGNy dGNfc3RhdGUtPmJhc2UuY3J0Yyk7Cj4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lID0gdG9f aW50ZWxfcGxhbmUoY3J0Yy0+YmFzZS5wcmltYXJ5KTsKPiArCj4gKwlwbGFuZS0+ZGlzYWJsZV9w bGFuZShwbGFuZSwgY3J0Y19zdGF0ZSk7Cj4gK30KPiArCj4gIHN0YXRpYyB2b2lkIGlyb25sYWtl X2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCQkJ CSBzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqb2xkX3N0YXRlKQo+ICB7Cj4gQEAgLTU3ODAsNiAr NTc4OCw4IEBAIHN0YXRpYyB2b2lkIGlyb25sYWtlX2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9j cnRjX3N0YXRlICpwaXBlX2NvbmZpZywKPiAgCSAqLwo+ICAJaW50ZWxfY29sb3JfbG9hZF9sdXRz KHBpcGVfY29uZmlnKTsKPiAgCWludGVsX2NvbG9yX2NvbW1pdChwaXBlX2NvbmZpZyk7Cj4gKwkv KiB1cGRhdGUgRFNQQ05UUiB0byBjb25maWd1cmUgZ2FtbWEgZm9yIHBpcGUgYm90dG9tIGNvbG9y ICovCj4gKwlpbnRlbF9kaXNhYmxlX3ByaW1hcnlfcGxhbmUocGlwZV9jb25maWcpOwo+ICAKPiAg CWlmIChkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MgIT0gTlVMTCkKPiAgCQlk ZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3Mob2xkX2ludGVsX3N0YXRlLCBwaXBl X2NvbmZpZyk7Cj4gQEAgLTU5MDksNiArNTkxOSw5IEBAIHN0YXRpYyB2b2lkIGhhc3dlbGxfY3J0 Y19lbmFibGUoc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnLAo+ICAJICovCj4g IAlpbnRlbF9jb2xvcl9sb2FkX2x1dHMocGlwZV9jb25maWcpOwo+ICAJaW50ZWxfY29sb3JfY29t bWl0KHBpcGVfY29uZmlnKTsKPiArCS8qIHVwZGF0ZSBEU1BDTlRSIHRvIGNvbmZpZ3VyZSBnYW1t YS9jc2MgZm9yIHBpcGUgYm90dG9tIGNvbG9yICovCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2 KSA8IDkpCj4gKwkJaW50ZWxfZGlzYWJsZV9wcmltYXJ5X3BsYW5lKHBpcGVfY29uZmlnKTsKPiAg Cj4gIAkvKgo+ICAJICogRGlzcGxheSBXQSAjMTE1MzogZW5hYmxlIGhhcmR3YXJlIHRvIGJ5cGFz cyB0aGUgYWxwaGEgbWF0aAo+IEBAIC02Mjc0LDYgKzYyODcsOCBAQCBzdGF0aWMgdm9pZCB2YWxs ZXl2aWV3X2NydGNfZW5hYmxlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBlX2NvbmZpZywK PiAgCj4gIAlpbnRlbF9jb2xvcl9sb2FkX2x1dHMocGlwZV9jb25maWcpOwo+ICAJaW50ZWxfY29s b3JfY29tbWl0KHBpcGVfY29uZmlnKTsKPiArCS8qIHVwZGF0ZSBEU1BDTlRSIHRvIGNvbmZpZ3Vy ZSBnYW1tYSBmb3IgcGlwZSBib3R0b20gY29sb3IgKi8KPiArCWludGVsX2Rpc2FibGVfcHJpbWFy eV9wbGFuZShwaXBlX2NvbmZpZyk7Cj4gIAo+ICAJZGV2X3ByaXYtPmRpc3BsYXkuaW5pdGlhbF93 YXRlcm1hcmtzKG9sZF9pbnRlbF9zdGF0ZSwKPiAgCQkJCQkgICAgIHBpcGVfY29uZmlnKTsKPiBA QCAtNjMzMSw2ICs2MzQ2LDggQEAgc3RhdGljIHZvaWQgaTl4eF9jcnRjX2VuYWJsZShzdHJ1Y3Qg aW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gIAo+ICAJaW50ZWxfY29sb3JfbG9hZF9s dXRzKHBpcGVfY29uZmlnKTsKPiAgCWludGVsX2NvbG9yX2NvbW1pdChwaXBlX2NvbmZpZyk7Cj4g KwkvKiB1cGRhdGUgRFNQQ05UUiB0byBjb25maWd1cmUgZ2FtbWEgZm9yIHBpcGUgYm90dG9tIGNv bG9yICovCj4gKwlpbnRlbF9kaXNhYmxlX3ByaW1hcnlfcGxhbmUocGlwZV9jb25maWcpOwo+ICAK PiAgCWlmIChkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3MgIT0gTlVMTCkKPiAg CQlkZXZfcHJpdi0+ZGlzcGxheS5pbml0aWFsX3dhdGVybWFya3Mob2xkX2ludGVsX3N0YXRlLAoK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=