From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2E51FE51E4 for ; Fri, 24 Apr 2026 08:45:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 564AC10F433; Fri, 24 Apr 2026 08:45:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="V6syd4k4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3EBB410F433; Fri, 24 Apr 2026 08:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777020302; x=1808556302; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=cZvEbggjbPZeYWZ/aFLsclmbJZceWnJ/7CRUiqlzOxk=; b=V6syd4k4ehj3Rp20I+/XKyRsmX7JP0PsCmYRZJuviTfuY7TT1hOOX1Hv TlcmVzH5Jp8II5GLbiWnEKyZQjBmGINh9FGgcOCz1xG1m7wkfYcdZtf5r GCbnwbvh45h5GbjTIdoTCdcS2+qS4THvyV86wjUhOgsZAnA3AP+dUlpPL kgzz/v5hU8wBDBU2Lb/KMP0IvOWumo8HAUPDUEFqy16n7RPJPZ201isov Fs6f2G9e131Y1Knhm2I41C8cg1QXvbOOx3rKjnk7pc/6x+lDuNLQvuufO 8Wk7Y4Du6YEfGI7DyZJxi8fCZw1PJYd3N+pj9BaCYQ5pKgnAwy0Y/mzaB g==; X-CSE-ConnectionGUID: 9n8br+TVTg+s7Ob5+wKikA== X-CSE-MsgGUID: UguR9n0eTkq/xpEDZsvZpQ== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="89381495" X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="89381495" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 01:45:02 -0700 X-CSE-ConnectionGUID: V5dybjsTSESpw8XcfVRs3g== X-CSE-MsgGUID: ZaW30ywUT3GM865MPqK90Q== X-ExtLoop1: 1 Received: from smoticic-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.89]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2026 01:45:00 -0700 From: Jani Nikula To: Juha-Pekka Heikkila , intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Cc: Juha-Pekka Heikkila , Tvrtko Ursulin , Ville =?utf-8?B?U3lyasOkbMOk?= Subject: Re: [PATCH v2] drm/i915/display: enable ccs modifiers on dg2 In-Reply-To: <20260423141148.3145665-1-juhapekka.heikkila@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260423141148.3145665-1-juhapekka.heikkila@gmail.com> Date: Fri, 24 Apr 2026 11:44:57 +0300 Message-ID: <92d121173a3e42ef91274f9fa810e47d71b8dd70@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 23 Apr 2026, Juha-Pekka Heikkila wrote: > Since Xe driver aux ccs enablement dg2 ccs modifiers have been > disabled on both Xe and i915 drivers. Here allow dg2 to use > ccs again for framebuffers. > > Fixes: 6a99e91a6ca8fec5882450128fb128265f86b32a ("drm/i915/display: Detect AuxCCS support via display parent interface") In kernel, there should be 12 characters of sha1. 'dim fixes ' gives you the correct format, and suggests Cc's (though you probably shouldn't actually Cc all of them). For referencing commits in general, I have this handy alias in my .gitconfig: [alias] cite = log -1 --abbrev=12 '--format=%h (\"%s\")' $ git cite 6a99e91a6ca8fec5882450128fb128265f86b32a 6a99e91a6ca8 ("drm/i915/display: Detect AuxCCS support via display parent interface") BR, Jani. > Signed-off-by: Juha-Pekka Heikkila > --- > drivers/gpu/drm/i915/i915_driver.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index d31819758f3d..a4bd4f8e18b2 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -750,9 +750,8 @@ static bool has_auxccs(struct drm_device *drm) > { > struct drm_i915_private *i915 = to_i915(drm); > > - return IS_GRAPHICS_VER(i915, 9, 12) || > - IS_ALDERLAKE_P(i915) || > - IS_METEORLAKE(i915); > + return IS_GRAPHICS_VER(i915, 9, 12) && > + !HAS_FLAT_CCS(i915); > } > > static bool has_fenced_regions(struct drm_device *drm) -- Jani Nikula, Intel