From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH v2 16/22] drm/i915/guc: Create vfuncs for the GuC interrupts control functions Date: Mon, 15 Apr 2019 10:51:33 -0700 Message-ID: <938197d9-3cc7-0e3a-c784-79133dddcde9@intel.com> References: <20190411084436.24384-1-michal.wajdeczko@intel.com> <20190411084436.24384-17-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F891898C2 for ; Mon, 15 Apr 2019 17:51:36 +0000 (UTC) In-Reply-To: <20190411084436.24384-17-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiA0LzExLzE5IDE6NDQgQU0sIE1pY2hhbCBXYWpkZWN6a28gd3JvdGU6Cj4gRnJvbTogT3Nj YXIgTWF0ZW8gPG9zY2FyLm1hdGVvQGludGVsLmNvbT4KPiAKPiBDb250cm9sbGluZyBhbmQgaGFu ZGxpbmcgb2YgdGhlIEd1QyBpbnRlcnJ1cHRzIGlzIEdlbiBzcGVjaWZpYy4KPiBDcmVhdGUgdmly dHVhbCBmdW5jdGlvbnMgdG8gYXZvaWQgcmVkdW5kYW50IHJ1bnRpbWUgR2VuIGNoZWNrcy4KPiBH ZW4tc3BlY2lmaWMgdmVyc2lvbnMgb2YgdGhlc2UgZnVuY3Rpb25zIHdpbGwgZm9sbG93Lgo+IAo+ IFNpZ25lZC1vZmYtYnk6IE9zY2FyIE1hdGVvIDxvc2Nhci5tYXRlb0BpbnRlbC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+ Cj4gQ2M6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KPiBDYzogVHZydGtv IFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogRGFuaWVsZSBDZXJhb2xv IFNwdXJpbyA8ZGFuaWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExh aHRpbmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCAgfCAyMiArKysrKysrKysrKysrKysrKysrKysrCj4g ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jICB8IDE4ICsrKysrKysrKysrKy0tLS0t LQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggfCAgMyAtLS0KPiAgIGRyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oIHwgIDEgLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfdWMuYyAgfCAgNiArKystLS0KPiAgIDUgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0 aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gaW5k ZXggMzVkMDc4MmMwNzdlLi42YzUyNjBkOTFiYzEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiBAQCAtMTU3NCw2ICsxNTc0LDEzIEBAIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlIHsKPiAg IAl1MzIgcG1fZ3VjX2V2ZW50czsKPiAgIAl1MzIgcGlwZXN0YXRfaXJxX21hc2tbSTkxNV9NQVhf UElQRVNdOwo+ICAgCj4gKwlzdHJ1Y3Qgewo+ICsJCWJvb2wgZW5hYmxlZDsKPiArCQl2b2lkICgq cmVzZXQpKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KTsKPiArCQl2b2lkICgqZW5hYmxl KShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSk7Cj4gKwkJdm9pZCAoKmRpc2FibGUpKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KTsKPiArCX0gZ3VjX2ludGVycnVwdHM7Cj4gKwoK SSB3b3VsZCBwdXQgdGhvc2UgdW5kZXIgdGhlIGd1YyBzdHJ1Y3R1cmUgc2luY2UgdGhleSdyZSBn dWMtc3BlY2lmaWMgCmZ1bmN0aW9ucy4gV2l0aCB0aGF0OgoKUmV2aWV3ZWQtYnk6IERhbmllbGUg Q2VyYW9sbyBTcHVyaW8gPGRhbmllbGUuY2VyYW9sb3NwdXJpb0BpbnRlbC5jb20+CgpEYW5pZWxl Cgo+ICAgCXN0cnVjdCBpOTE1X2hvdHBsdWcgaG90cGx1ZzsKPiAgIAlzdHJ1Y3QgaW50ZWxfZmJj IGZiYzsKPiAgIAlzdHJ1Y3QgaTkxNV9kcnJzIGRycnM7Cj4gQEAgLTI3NTMsNiArMjc2MCwyMSBA QCBleHRlcm4gdm9pZCBpbnRlbF9pcnFfZmluaShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2 X3ByaXYpOwo+ICAgaW50IGludGVsX2lycV9pbnN0YWxsKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl ICpkZXZfcHJpdik7Cj4gICB2b2lkIGludGVsX2lycV91bmluc3RhbGwoc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2KTsKPiAgIAo+ICtzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfcmVz ZXRfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gK3sKPiAr CWk5MTUtPmd1Y19pbnRlcnJ1cHRzLnJlc2V0KGk5MTUpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaW5s aW5lIHZvaWQgaW50ZWxfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICppOTE1KQo+ICt7Cj4gKwlpOTE1LT5ndWNfaW50ZXJydXB0cy5lbmFibGUoaTkxNSk7Cj4g K30KPiArCj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBpbnRlbF9kaXNhYmxlX2d1Y19pbnRlcnJ1cHRz KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICt7Cj4gKwlpOTE1LT5ndWNfaW50ZXJy dXB0cy5kaXNhYmxlKGk5MTUpOwo+ICt9Cj4gKwo+ICAgc3RhdGljIGlubGluZSBib29sIGludGVs X2d2dF9hY3RpdmUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAgewo+ICAg CXJldHVybiBkZXZfcHJpdi0+Z3Z0Owo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2lycS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IGQ5 MzQ1NDU0NDVlMS4uZTJmMGNiZWU5MzQ1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfaXJxLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4g QEAgLTU1NCw3ICs1NTQsNyBAQCB2b2lkIGdlbjZfZGlzYWJsZV9ycHNfaW50ZXJydXB0cyhzdHJ1 Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJCWdlbjZfcmVzZXRfcnBzX2ludGVy cnVwdHMoZGV2X3ByaXYpOwo+ICAgfQo+ICAgCj4gLXZvaWQgZ2VuOV9yZXNldF9ndWNfaW50ZXJy dXB0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyB2b2lkIGdl bjlfcmVzZXRfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAgewo+ICAgCWFzc2VydF9ycG1fd2FrZWxvY2tfaGVsZChkZXZfcHJpdik7Cj4gICAKPiBA QCAtNTYzLDI2ICs1NjMsMjYgQEAgdm9pZCBnZW45X3Jlc2V0X2d1Y19pbnRlcnJ1cHRzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgIAlzcGluX3VubG9ja19pcnEoJmRldl9w cml2LT5pcnFfbG9jayk7Cj4gICB9Cj4gICAKPiAtdm9pZCBnZW45X2VuYWJsZV9ndWNfaW50ZXJy dXB0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3N0YXRpYyB2b2lkIGdl bjlfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp dikKPiAgIHsKPiAgIAlhc3NlcnRfcnBtX3dha2Vsb2NrX2hlbGQoZGV2X3ByaXYpOwo+ICAgCj4g ICAJc3Bpbl9sb2NrX2lycSgmZGV2X3ByaXYtPmlycV9sb2NrKTsKPiAtCWlmICghZGV2X3ByaXYt Pmd1Yy5pbnRlcnJ1cHRzX2VuYWJsZWQpIHsKPiArCWlmICghZGV2X3ByaXYtPmd1Y19pbnRlcnJ1 cHRzLmVuYWJsZWQpIHsKPiAgIAkJV0FSTl9PTl9PTkNFKEk5MTVfUkVBRChnZW42X3BtX2lpcihk ZXZfcHJpdikpICYKPiAgIAkJCQkgICAgICAgZGV2X3ByaXYtPnBtX2d1Y19ldmVudHMpOwo+IC0J CWRldl9wcml2LT5ndWMuaW50ZXJydXB0c19lbmFibGVkID0gdHJ1ZTsKPiArCQlkZXZfcHJpdi0+ Z3VjX2ludGVycnVwdHMuZW5hYmxlZCA9IHRydWU7Cj4gICAJCWdlbjZfZW5hYmxlX3BtX2lycShk ZXZfcHJpdiwgZGV2X3ByaXYtPnBtX2d1Y19ldmVudHMpOwo+ICAgCX0KPiAgIAlzcGluX3VubG9j a19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gICB9Cj4gICAKPiAtdm9pZCBnZW45X2Rpc2Fi bGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICtz dGF0aWMgdm9pZCBnZW45X2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoc3RydWN0IGRybV9pOTE1X3By aXZhdGUgKmRldl9wcml2KQo+ICAgewo+ICAgCWFzc2VydF9ycG1fd2FrZWxvY2tfaGVsZChkZXZf cHJpdik7Cj4gICAKPiAgIAlzcGluX2xvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+IC0J ZGV2X3ByaXYtPmd1Yy5pbnRlcnJ1cHRzX2VuYWJsZWQgPSBmYWxzZTsKPiArCWRldl9wcml2LT5n dWNfaW50ZXJydXB0cy5lbmFibGVkID0gZmFsc2U7Cj4gICAKPiAgIAlnZW42X2Rpc2FibGVfcG1f aXJxKGRldl9wcml2LCBkZXZfcHJpdi0+cG1fZ3VjX2V2ZW50cyk7Cj4gICAKPiBAQCAtNDY3Myw2 ICs0NjczLDEyIEBAIHZvaWQgaW50ZWxfaXJxX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUg KmRldl9wcml2KQo+ICAgCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDgpCj4gICAJCXJwcy0+ cG1faW50cm1za19tYnogfD0gR0VOOF9QTUlOVFJfRElTQUJMRV9SRURJUkVDVF9UT19HVUM7Cj4g ICAKPiArCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsKPiArCQlkZXZfcHJpdi0+Z3Vj X2ludGVycnVwdHMucmVzZXQgPSBnZW45X3Jlc2V0X2d1Y19pbnRlcnJ1cHRzOwo+ICsJCWRldl9w cml2LT5ndWNfaW50ZXJydXB0cy5lbmFibGUgPSBnZW45X2VuYWJsZV9ndWNfaW50ZXJydXB0czsK PiArCQlkZXZfcHJpdi0+Z3VjX2ludGVycnVwdHMuZGlzYWJsZSA9IGdlbjlfZGlzYWJsZV9ndWNf aW50ZXJydXB0czsKPiArCX0KPiArCj4gICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gNSB8 fCBJU19HNFgoZGV2X3ByaXYpKQo+ICAgCQlkZXYtPmRyaXZlci0+Z2V0X3ZibGFua19jb3VudGVy ID0gZzR4X2dldF92YmxhbmtfY291bnRlcjsKPiAgIAllbHNlIGlmIChJTlRFTF9HRU4oZGV2X3By aXYpID49IDMpCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBhMzhiOWNmZjVjZDAu LjliNmNhYzkwZTg5MSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTE2Mjcs OSArMTYyNyw2IEBAIHZvaWQgZ2VuOF9pcnFfcG93ZXJfd2VsbF9wb3N0X2VuYWJsZShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gICAJCQkJICAgICB1OCBwaXBlX21hc2spOwo+ ICAgdm9pZCBnZW44X2lycV9wb3dlcl93ZWxsX3ByZV9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgIAkJCQkgICAgIHU4IHBpcGVfbWFzayk7Cj4gLXZvaWQgZ2Vu OV9yZXNldF9ndWNfaW50ZXJydXB0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+IC12b2lkIGdlbjlfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdik7Cj4gLXZvaWQgZ2VuOV9kaXNhYmxlX2d1Y19pbnRlcnJ1cHRzKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdik7Cj4gICAKPiAgIC8qIGludGVsX2Rpc3BsYXku YyAqLwo+ICAgdm9pZCBpbnRlbF9wbGFuZV9kZXN0cm95KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5l KTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmggYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuaAo+IGluZGV4IDRmM2NmOGVkZGZlNi4uMDM3MWI4 ZjMwOTMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmgKPiBAQCAtNTYsNyArNTYsNiBA QCBzdHJ1Y3QgaW50ZWxfZ3VjIHsKPiAgIAo+ICAgCS8qIGludGVsX2d1Y19yZWN2IGludGVycnVw dCByZWxhdGVkIHN0YXRlICovCj4gICAJc3BpbmxvY2tfdCBpcnFfbG9jazsKPiAtCWJvb2wgaW50 ZXJydXB0c19lbmFibGVkOwo+ICAgCXVuc2lnbmVkIGludCBtc2dfZW5hYmxlZF9tYXNrOwo+ICAg Cj4gICAJc3RydWN0IGk5MTVfdm1hICphZHNfdm1hOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF91Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+ IGluZGV4IDAzYmMyYTBlZTM0Yi4uYTFhMDY4NTExZmQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3VjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91Yy5jCj4gQEAgLTIxOSw3ICsyMTksNyBAQCBzdGF0aWMgaW50IGd1Y19lbmFibGVfY29tbXVu aWNhdGlvbihzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICB7Cj4gICAJc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmk5MTUgPSBndWNfdG9faTkxNShndWMpOwo+ICAgCj4gLQlnZW45X2VuYWJsZV9n dWNfaW50ZXJydXB0cyhpOTE1KTsKPiArCWludGVsX2VuYWJsZV9ndWNfaW50ZXJydXB0cyhpOTE1 KTsKPiAgIAo+ICAgCWlmIChIQVNfR1VDX0NUKGk5MTUpKQo+ICAgCQlyZXR1cm4gaW50ZWxfZ3Vj X2N0X2VuYWJsZSgmZ3VjLT5jdCk7Cj4gQEAgLTIzNiw3ICsyMzYsNyBAQCBzdGF0aWMgdm9pZCBn dWNfZGlzYWJsZV9jb21tdW5pY2F0aW9uKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAlpZiAo SEFTX0dVQ19DVChpOTE1KSkKPiAgIAkJaW50ZWxfZ3VjX2N0X2Rpc2FibGUoJmd1Yy0+Y3QpOwo+ ICAgCj4gLQlnZW45X2Rpc2FibGVfZ3VjX2ludGVycnVwdHMoaTkxNSk7Cj4gKwlpbnRlbF9kaXNh YmxlX2d1Y19pbnRlcnJ1cHRzKGk5MTUpOwo+ICAgCj4gICAJZ3VjLT5zZW5kID0gaW50ZWxfZ3Vj X3NlbmRfbm9wOwo+ICAgCWd1Yy0+aGFuZGxlciA9IGludGVsX2d1Y190b19ob3N0X2V2ZW50X2hh bmRsZXJfbm9wOwo+IEBAIC0zNTgsNyArMzU4LDcgQEAgaW50IGludGVsX3VjX2luaXRfaHcoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUpCj4gICAKPiAgIAlHRU1fQlVHX09OKCFIQVNfR1VD KGk5MTUpKTsKPiAgIAo+IC0JZ2VuOV9yZXNldF9ndWNfaW50ZXJydXB0cyhpOTE1KTsKPiArCWlu dGVsX3Jlc2V0X2d1Y19pbnRlcnJ1cHRzKGk5MTUpOwo+ICAgCj4gICAJLyogV2FFbmFibGV1S2Vy bmVsSGVhZGVyVmFsaWRGaXg6c2tsICovCj4gICAJLyogV2FFbmFibGVHdUNCb290SGFzaENoZWNr Tm90U2V0OnNrbCxieHQsa2JsICovCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeA==