From mboxrd@z Thu Jan 1 00:00:00 1970 From: david may Subject: Re: patches for occlusion query fix on sandybridge Date: Tue, 14 Dec 2010 20:59:09 +0000 Message-ID: <944877732.20101214205909@ntlworld.com> References: <1292302562-5800-1-git-send-email-zhenyuw@linux.intel.com> <877hfcgrrx.fsf@pollan.anholt.net> Reply-To: david may Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from queueout04-winn.ispmail.ntl.com (queueout04-winn.ispmail.ntl.com [81.103.221.58]) by gabe.freedesktop.org (Postfix) with ESMTP id 9210C9EED3 for ; Tue, 14 Dec 2010 13:09:18 -0800 (PST) In-Reply-To: <877hfcgrrx.fsf@pollan.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Zhenyu Wang , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Hello Eric, Tuesday, December 14, 2010, 5:58:58 PM, you wrote: > On Tue, 14 Dec 2010 12:55:59 +0800, Zhenyu Wang wrote: >> It appears Sandybridge PIPE_CONTROL write out buffer need >> to be set as cached, currently LLC cached, in order to read >> back correct counter. Otherwise I can always be possible to >> get corrupted 64-bit PS_DEPTH_COUNT from PIPE_CONTROL write. >> >> So below patches try to add new flag during bo create with >> cacheable type, to be sure that GTT entry's cache bits would >> be setup for that. >> >> This fixes occlusion query piglit test and mesa demos on my >> sandybridge. Note that below patches don't include necessary >> component version check changes. > Why don't we just keep all of our BOs LLC cached? This was supposed to > be a big win of the new chipset, as it means we don't need to clflush. Ohh,the implication here is that people are/have been writing the code,But Not bothering Actually benching/Profiling it to see if it actually is faster and better throughput than before, that seems wrong, especially given sandy bridge is supposed to be better, i Do Hope you are/will be testing/benching/Profiling to see if it/all SB Code is actually "a big win" one way or the other before passing for release. -- Best regards, david mailto:david.may10@ntlworld.com