From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06523C433FE for ; Tue, 11 Oct 2022 08:35:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CDFE910E7DF; Tue, 11 Oct 2022 08:35:50 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBDB510E534 for ; Tue, 11 Oct 2022 08:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665477347; x=1697013347; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=n+Rj0crdmYuGaVhxDulJOeXVv+pdBkglTwNs/mFcIk8=; b=YBrtNq6HuNHd590BMQ0SiVixbeovxdUqj1uFhcsZ0rt1nmoMb5GURlJK Dck2T9Yv0PjJMXDRLR9lYvafLNyfFM5HA1oDL6P6905mN06ZTKyKARz1n VN8EkW4Pdun10JuzWg+Ifd4yE6mMjfWzcITkBfLp1UqkBIpU36+PCNWCG WKZ0dq81LNYcXQO0TNJdgJOz476O8rIOjwNAUXAhrpKO0lIX+pNV5UGEz sj0AYhb/Io3opitLqIGEjL/krD/8hZTLL4Fm01m7tBUja/G6I64y05b5Z gmQcxeLxiuRnTs3FwhkeDn12xofDdLQRARPTWt07ZZArk0TCJcStqveQg Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="305499741" X-IronPort-AV: E=Sophos;i="5.95,175,1661842800"; d="scan'208";a="305499741" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 01:35:47 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10496"; a="955253546" X-IronPort-AV: E=Sophos;i="5.95,175,1661842800"; d="scan'208";a="955253546" Received: from mhartiga-mobl.ger.corp.intel.com (HELO [10.213.228.219]) ([10.213.228.219]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 01:35:46 -0700 Message-ID: <94c0d0c1-4d14-b175-52a6-44de04961eaa@linux.intel.com> Date: Tue, 11 Oct 2022 09:35:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Content-Language: en-US To: "Dixit, Ashutosh" , intel-gfx@lists.freedesktop.org References: <87pmey29es.wl-ashutosh.dixit@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <87pmey29es.wl-ashutosh.dixit@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Warn if not in RC6 when GT is parked X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 11/10/2022 06:53, Dixit, Ashutosh wrote: > On Mon, 10 Oct 2022 20:29:23 -0700, Ashutosh Dixit wrote: >> >> Some i915 modules implicitly assume that there is no user, kernel or >> firmware activity after GT is parked. For example, PMU calculations are >> incorrect if GT is not in RC6 when GT is parked (outside of the GT >> wakeref). Therefore check and warn if GT is not in RC6 at the time of >> parking the GT. > > This patch has cause widespread dmesg_warn's in premerge CI so there is no > intention of merging this. It just proves that these assumptions in PMU > (for quantities such as frequency and RC6 residency) are incorrect and need > to be addressed. Yeah this probably does not make sense since I am not sure if driver actually controls when hardware goes into RC6. Regards, Tvrtko > > Thanks. > -- > Ashutosh > > >> @@ -123,6 +125,10 @@ static int __gt_park(struct intel_wakeref *wf) >> intel_display_power_put_async(i915, POWER_DOMAIN_GT_IRQ, wakeref); >> } >> >> + ret = intel_rc6_in_rc6(>->rc6, &in_rc6); >> + if (!ret && !in_rc6) >> + drm_warn_once(&i915->drm, "Parking, but GT is not in RC6!\n"); >> + >> return 0; >> }