From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re:
 =?utf-8?q?=5BPATCH_intel-gpu-tools=5D_tools=3A_Added_?=
 =?utf-8?q?intel=5Fdpio=5Fread_and_intel=5Fdpio=5Fwrite?=
Date: Mon, 06 Aug 2012 14:21:17 -0700
Message-ID: <95ccd39fcb0204058c18f497b88781ee@bwidawsk.net>
References: <1343909236-17870-1-git-send-email-vijay.a.purushothaman@intel.com>
	<25e00d42d0c3a1f04db332d79a69b63d@bwidawsk.net>
	<20120806071652.GE5502@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 19CC49E75F
	for <intel-gfx@lists.freedesktop.org>;
	Mon,  6 Aug 2012 14:21:17 -0700 (PDT)
In-Reply-To: <20120806071652.GE5502@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 2012-08-06 00:16, Daniel Vetter wrote:
> On Thu, Aug 02, 2012 at 09:06:48AM -0700, Ben Widawsky wrote:
>> On 2012-08-02 05:07, Vijay Purushothaman wrote:
>> >In Valleyview the DPLL and lane control registers are accessible 
>> only
>> >through side band fabric called DPIO. Added two tools to read and
>> >write
>> >registers residing in this space.
>>
>> Could I convince you to use the centralized read/write mmio 
>> functions?
>> Otherwise, everything seems fine to me here.
>
> I wonder whether we need some kernel interface for this, after all if 
> the
> kernel touches this, too, things will blow up. Otoh the kernel only 
> uses
> the dpio sideband regs at modeset time, so I guess the risk is 
> minimal.
> -Daniel

It's the same as any register. As long as it's root only, bullets, gun, 
and
target for foot are provided for free. Though I would like to converge 
on
central API for register read and right.

-- 
Ben Widawsky, Intel Open Source Technology Center