From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 3/8] drm/i915/execlists: Suppress redundant preemption Date: Tue, 29 Jan 2019 11:15:35 +0000 Message-ID: <96d3e40b-a276-01ff-e260-e878ff4ac6d4@linux.intel.com> References: <20190129085824.12620-1-chris@chris-wilson.co.uk> <20190129085824.12620-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9EDF66E2CD for ; Tue, 29 Jan 2019 11:15:30 +0000 (UTC) In-Reply-To: <20190129085824.12620-3-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI5LzAxLzIwMTkgMDg6NTgsIENocmlzIFdpbHNvbiB3cm90ZToKPiBPbiB1bndpbmRpbmcg dGhlIGFjdGl2ZSByZXF1ZXN0IHdlIGdpdmUgaXQgYSBzbWFsbCAobGltaXRlZCB0byBpbnRlcm5h bAo+IHByaW9yaXR5IGxldmVscykgYm9vc3QgdG8gcHJldmVudCBpdCBmcm9tIGJlaW5nIGdhenVt cGVkIGEgc2Vjb25kIHRpbWUuCj4gSG93ZXZlciwgdGhpcyBtZWFucyB0aGF0IGl0IGNhbiBiZSBw cm9tb3RlZCB0byBhYm92ZSB0aGUgcmVxdWVzdCB0aGF0Cj4gdHJpZ2dlcmVkIHRoZSBwcmVlbXB0 aW9uIHJlcXVlc3QsIGNhdXNpbmcgYSBwcmVlbXB0LXRvLWlkbGUgY3ljbGUgZm9yIG5vCgpIb3cg Y2FuIGl0IGdvIGhpZ2hlcj8gT25seSBiZWNhdXNlIEk5MTVfUFJJT1JJVFlfTkVXQ0xJRU5UIGlz IGhpZ2hlciAKdGhhbiBJOTE1X1BSSU9SSVRZX1dBSVQ/IEluIHRoYXQgY2FzZSB3b3VsZCByZS1v cmRlcmluZyB0aG9zZSBoZWxwPyBJIApkb24ndCByZW1lbWJlciBpZiB0aGVyZSB3YXMgYSByZWFz b24gZm9yIHRoZSBjdXJyZW50IG9yZGVyLgoKPiBjaGFuZ2UuIFdlIGNhbiBhdm9pZCB0aGlzIGlm IHdlIHRha2UgdGhlIGJvb3N0IGludG8gYWNjb3VudCB3aGVuCj4gY2hlY2tpbmcgaWYgdGhlIHBy ZWVtcHRpb24gcmVxdWVzdCBpcyB2YWxpZC4KPiAKPiB2MjogQWZ0ZXIgcHJlZW1wdGlvbiB0aGUg YWN0aXZlIHJlcXVlc3Qgd2lsbCBiZSBhZnRlciB0aGUgcHJlZW1wdGVlIGlmCj4gdGhleSBlbmQg dXAgd2l0aCBlcXVhbCBwcmlvcml0eS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2xyYy5jIHwgMzkgKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0KPiAgIDEg ZmlsZSBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2xyYy5jCj4gaW5kZXggYjhjZGRlZjVhZWQ4Li5mNGIwYmU4MWM2ZGIgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJjLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9scmMuYwo+IEBAIC0xNjQsNiArMTY0LDggQEAKPiAgICNk ZWZpbmUgV0FfVEFJTF9EV09SRFMgMgo+ICAgI2RlZmluZSBXQV9UQUlMX0JZVEVTIChzaXplb2Yo dTMyKSAqIFdBX1RBSUxfRFdPUkRTKQo+ICAgCj4gKyNkZWZpbmUgQUNUSVZFX1BSSU9SSVRZIChJ OTE1X1BSSU9SSVRZX05FV0NMSUVOVCkKPiArCj4gICBzdGF0aWMgaW50IGV4ZWNsaXN0c19jb250 ZXh0X2RlZmVycmVkX2FsbG9jKHN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHgsCj4gICAJCQkJ CSAgICBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJCQkJCSAgICBzdHJ1Y3Qg aW50ZWxfY29udGV4dCAqY2UpOwo+IEBAIC0xODgsNiArMTkwLDM0IEBAIHN0YXRpYyBpbmxpbmUg aW50IHJxX3ByaW8oY29uc3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICAJcmV0dXJuIHJx LT5zY2hlZC5hdHRyLnByaW9yaXR5Owo+ICAgfQo+ICAgCj4gK3N0YXRpYyBpbmxpbmUgaW50IGFj dGl2ZV9wcmlvKGNvbnN0IHN0cnVjdCBpOTE1X3JlcXVlc3QgKnJxKQo+ICt7Cj4gKwlpbnQgcHJp byA9IHJxX3ByaW8ocnEpOwo+ICsKPiArCS8qCj4gKwkgKiBPbiB1bndpbmRpbmcgdGhlIGFjdGl2 ZSByZXF1ZXN0LCB3ZSBnaXZlIGl0IGEgcHJpb3JpdHkgYnVtcAo+ICsJICogZXF1aXZhbGVudCB0 byBhIGZyZXNobHkgc3VibWl0dGVkIHJlcXVlc3QuIFRoaXMgcHJvdGVjdHMgaXQgZnJvbQo+ICsJ ICogYmVpbmcgZ2F6dW1wZWQgYWdhaW4sIGJ1dCBpdCB3b3VsZCBiZSBwcmVmZXJhYmxlIGlmIHdl IGRpZG4ndAo+ICsJICogbGV0IGl0IGJlIGdhenVtcGVkIGluIHRoZSBmaXJzdCBwbGFjZSEKPiAr CSAqCj4gKwkgKiBTZWUgX191bndpbmRfaW5jb21wbGV0ZV9yZXF1ZXN0cygpCj4gKwkgKi8KPiAr CWlmICgocHJpbyAmIEFDVElWRV9QUklPUklUWSkgIT0gQUNUSVZFX1BSSU9SSVRZICYmCgppZiAo IShwcmlvICYgQUNUSVZFX1BSSU9SSVRZKSAmJiA/IEl0IGlzIGEgc2luZ2xlIGJpdC4KCj4gKwkg ICAgaTkxNV9yZXF1ZXN0X3N0YXJ0ZWQocnEpKSB7Cj4gKwkJLyoKPiArCQkgKiBBZnRlciBwcmVl bXB0aW9uLCB3ZSBpbnNlcnQgdGhlIGFjdGl2ZSByZXF1ZXN0IGF0IHRoZQo+ICsJCSAqIGVuZCBv ZiB0aGUgbmV3IHByaW9yaXR5IGxldmVsLiBUaGlzIG1lYW5zIHRoYXQgd2Ugd2lsbCBiZQoKU2lk ZSBxdWVzdGlvbiAtIHdoeSBkbyB3ZSBub3QgbW92ZSBpdCB0byB0aGUgaGVhZCBvZiB0aGUgbmV3 IHByaW9yaXR5IApsZXZlbD8gSXQgd2FzIHByZWVtcHRlZCwgc28gaXQgc291bmRzIGZhaXIgdGhh dCBpdCB3b3VsZCBnbyB0byB0aGUgaGVhZC4KCj4gKwkJICogX2xvd2VyXyBwcmlvcml0eSB0aGFu IHRoZSBwcmVlbXB0ZWUgYWxsIHRoaW5ncyBlcXVhbCAoYW5kCj4gKwkJICogc28gdGhlIHByZWVt cHRpb24gaXMgdmFsaWQpLCBzbyBhZGp1c3Qgb3VyIGNvbXBhcmlzb24KPiArCQkgKiBhY2NvcmRp bmdseS4KPiArCQkgKi8KPiArCQlwcmlvIHw9IEFDVElWRV9QUklPUklUWTsKPiArCQlwcmlvLS07 CgpTbyBhbnkgcnVubmluZyByZXF1ZXN0IG5vdCBtYXJrZWQgd2l0aCBORVdDTElFTlQvQUNUSVZF X1BSSU9SSVRZIHdpbGwgCmdldCBpdCBoZXJlLCBtaW51cyBvbmUsIHdoaWNoIGVmZmVjdGl2ZWx5 IG1lYW5zIGFwcGx5aW5nIApJOTE1X1BSSU9SSVRZX1dBSVQgdG8gaXQuIE9yIGp1c3Qga2VlcGlu ZyBORVdDTElFTlQgaWYgaXQgaGFkIFdBSVQgYWxyZWFkeS4KClNvIGtpbmQgb2YgbGlrZSBhIG1p Y3JvIHByaW9yaXR5IGJ1bXAsIG9ubHkgaWYgdGhlIHJlcXVlc3QgaXMgcnVubmluZy4gCkRvIHlv dSB2aWV3IGl0IGFzIGVuZCBvZiB0aGUgY29udGV4dCBzdHJlYW0gc28gbWFrZSBwcmVlbXB0aW9u IGxlc3MgCmxpa2VseSBvbiB0aGUgdmVyeSBlbmQgb2YgdGhlIHN0cmVhbT8gQnV0IHdoYXQgaWYg aXQgaXMgYSBsb25nIGJhdGNoLCAKd2h5IHdlIHdvdWxkbid0IHdhbnQgdG8gcHJlZW1wdCBpdD8K ClJlZ2FyZHMsCgpUdnJ0a28KCj4gKwl9Cj4gKwo+ICsJcmV0dXJuIHByaW87Cj4gK30KPiArCj4g ICBzdGF0aWMgaW50IHF1ZXVlX3ByaW8oY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9leGVjbGlz dHMgKmV4ZWNsaXN0cykKPiAgIHsKPiAgIAlzdHJ1Y3QgaTkxNV9wcmlvbGlzdCAqcDsKPiBAQCAt MjA4LDcgKzIzOCw3IEBAIHN0YXRpYyBpbnQgcXVldWVfcHJpbyhjb25zdCBzdHJ1Y3QgaW50ZWxf ZW5naW5lX2V4ZWNsaXN0cyAqZXhlY2xpc3RzKQo+ICAgc3RhdGljIGlubGluZSBib29sIG5lZWRf cHJlZW1wdChjb25zdCBzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJCQkJY29u c3Qgc3RydWN0IGk5MTVfcmVxdWVzdCAqcnEpCj4gICB7Cj4gLQljb25zdCBpbnQgbGFzdF9wcmlv ID0gcnFfcHJpbyhycSk7Cj4gKwlpbnQgbGFzdF9wcmlvOwo+ICAgCj4gICAJaWYgKCFpbnRlbF9l bmdpbmVfaGFzX3ByZWVtcHRpb24oZW5naW5lKSkKPiAgIAkJcmV0dXJuIGZhbHNlOwo+IEBAIC0y MjgsNiArMjU4LDcgQEAgc3RhdGljIGlubGluZSBib29sIG5lZWRfcHJlZW1wdChjb25zdCBzdHJ1 Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUsCj4gICAJICogcHJlZW1wdC4gSWYgdGhhdCBoaW50 IGlzIHN0YWxlIG9yIHdlIG1heSBiZSB0cnlpbmcgdG8gcHJlZW1wdAo+ICAgCSAqIG91cnNlbHZl cywgaWdub3JlIHRoZSByZXF1ZXN0Lgo+ICAgCSAqLwo+ICsJbGFzdF9wcmlvID0gYWN0aXZlX3By aW8ocnEpOwo+ICAgCWlmICghX19leGVjbGlzdHNfbmVlZF9wcmVlbXB0KGVuZ2luZS0+ZXhlY2xp c3RzLnByZWVtcHRfcHJpb3JpdHlfaGludCwKPiAgIAkJCQkgICAgICBsYXN0X3ByaW8pKQo+ICAg CQlyZXR1cm4gZmFsc2U7Cj4gQEAgLTM1Myw3ICszODQsNyBAQCBfX3Vud2luZF9pbmNvbXBsZXRl X3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAgIHsKPiAgIAlzdHJ1 Y3QgaTkxNV9yZXF1ZXN0ICpycSwgKnJuLCAqYWN0aXZlID0gTlVMTDsKPiAgIAlzdHJ1Y3QgbGlz dF9oZWFkICp1bmluaXRpYWxpemVkX3ZhcihwbCk7Cj4gLQlpbnQgcHJpbyA9IEk5MTVfUFJJT1JJ VFlfSU5WQUxJRCB8IEk5MTVfUFJJT1JJVFlfTkVXQ0xJRU5UOwo+ICsJaW50IHByaW8gPSBJOTE1 X1BSSU9SSVRZX0lOVkFMSUQgfCBBQ1RJVkVfUFJJT1JJVFk7Cj4gICAKPiAgIAlsb2NrZGVwX2Fz c2VydF9oZWxkKCZlbmdpbmUtPnRpbWVsaW5lLmxvY2spOwo+ICAgCj4gQEAgLTM4NSw4ICs0MTYs OCBAQCBfX3Vud2luZF9pbmNvbXBsZXRlX3JlcXVlc3RzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3Mg KmVuZ2luZSkKPiAgIAkgKiBzdHJlYW0sIHNvIGdpdmUgaXQgdGhlIGVxdWl2YWxlbnQgc21hbGwg cHJpb3JpdHkgYnVtcCB0byBwcmV2ZW50Cj4gICAJICogaXQgYmVpbmcgZ2F6dW1wZWQgYSBzZWNv bmQgdGltZSBieSBhbm90aGVyIHBlZXIuCj4gICAJICovCj4gLQlpZiAoIShwcmlvICYgSTkxNV9Q UklPUklUWV9ORVdDTElFTlQpKSB7Cj4gLQkJcHJpbyB8PSBJOTE1X1BSSU9SSVRZX05FV0NMSUVO VDsKPiArCWlmICgocHJpbyAmIEFDVElWRV9QUklPUklUWSkgIT0gQUNUSVZFX1BSSU9SSVRZKSB7 Cj4gKwkJcHJpbyB8PSBBQ1RJVkVfUFJJT1JJVFk7Cj4gICAJCWFjdGl2ZS0+c2NoZWQuYXR0ci5w cmlvcml0eSA9IHByaW87Cj4gICAJCWxpc3RfbW92ZV90YWlsKCZhY3RpdmUtPnNjaGVkLmxpbmss Cj4gICAJCQkgICAgICAgaTkxNV9zY2hlZF9sb29rdXBfcHJpb2xpc3QoZW5naW5lLCBwcmlvKSk7 Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVs LWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=