Re: [PATCH igt 05/10] igt/drv_hangman: Skip if resets are disallowed

Michał Winiarski
2017-07-28T13:53:44Z

On Fri, Jul 28, 2017 at 01:08:03PM +0100, Chris Wilson wrote:
> If we tell the machine to reset but they are disallowed, we will leave
> the system in a wedged state, preventing the majority of subsequent
> tests.
> ---
> tests/drv_hangman.c | 3 +++
> 1 file changed, 3 insertions(+)

Missed sign-off.

>
> diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> index 0551ec16..de57e128 100644
> --- a/tests/drv_hangman.c
> +++ b/tests/drv_hangman.c
> @@ -30,6 +30,7 @@
> #include <limits.h>
> #include <sys/types.h>
> #include <sys/stat.h>
> +#include <sys/ioctl.h>
> #include <fcntl.h>
>
> #include "igt_sysfs.h"
> @@ -239,7 +240,9 @@ igt_main
> int idx;
>
> device = drm_open_driver(DRIVER_INTEL);
> + igt_allow_hang(device, 0, 0);

Umm... That's not skipping.
That's enabling reset, right?

-Michał

> igt_require_gem(device);
> +
> sysfs = igt_sysfs_open(device, &idx);
> igt_assert(sysfs != -1);
> }
> --
> 2.13.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx