Re: [PATCH igt 08/10] igt/gem_exec_fence: Exercise merging fences

Chris Wilson
2017-07-31T09:19:40Z

Quoting Michał Winiarski (2017-07-31 09:26:44)
> On Fri, Jul 28, 2017 at 01:08:06PM +0100, Chris Wilson wrote:
> > + for_each_engine(fd, engine) {
> > + int fence, new;
> > +
> > + execbuf.flags = engine | LOCAL_EXEC_FENCE_OUT;
> > + execbuf.rsvd2 = -1;
> > + gem_execbuf_wr(fd, &execbuf);
> > + fence = execbuf.rsvd2 >> 32;
> > + igt_assert(fence != -1);
> > +
> > + if (all < 0) {
> > + all = fence;
> > + break;
> > + }
>
> So... In case we're getting an error from previous sync_file_merge, we'll just
> silently continue rather than fail? Or am I missing something here?

No, just used to the idiom that the basic igt libraries do the error
checking and you have to use the __func to obtain the error for oneself.
-Chris