From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E613C433EF for ; Tue, 15 Feb 2022 15:55:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE27010E50C; Tue, 15 Feb 2022 15:55:10 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15B6F10E4C0 for ; Tue, 15 Feb 2022 15:55:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644940510; x=1676476510; h=message-id:date:mime-version:subject:to:references:from: in-reply-to:content-transfer-encoding; bh=G9awELaZH1SRs2WP2H3VfB9kJIuzStlFPK6KZH4NE6U=; b=QRMEGnkUmNHHw5h3b2l5YO4h820ANRVVlzI53amUFGr28ChByztKr1Bq DWgsDTkGt0jial5g/rw/ZokKbcjLxNuLSUaMcsBiyduDx6EweHZiOSJSW ioH/kjnnXqEedIPqwOPuHQ6j5uMKaPdbBLBUep/I0GLm96rQ/qQ+kMgG1 39VXn0rb4O2Dv7iHLtzloCKRnIhaK6McQgJLhjZ/fwdFEIUdFDQ3FKHg4 bwFtrMPTNF6KHx5PixfSKnvW7m1sTwBpY0BaE3AwY+Dbz/JTmp0Z1B6gD wMiapjiois5R+dqP16AuCHvEHlNwiND+4hvxciUuFzCmQgU+i/luMkC2V A==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="250581942" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="250581942" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 07:55:09 -0800 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="624869372" Received: from jkoratik-mobl2.amr.corp.intel.com (HELO [10.212.80.80]) ([10.212.80.80]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 07:55:08 -0800 Message-ID: <98517720-4542-b6ff-88fa-582eedc80c3f@linux.intel.com> Date: Tue, 15 Feb 2022 15:55:07 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: Jani Nikula , intel-gfx@lists.freedesktop.org References: <20220214173810.2108975-1-jani.nikula@intel.com> <20220214173810.2108975-2-jani.nikula@intel.com> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc In-Reply-To: <20220214173810.2108975-2-jani.nikula@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/lrc: replace include with forward declarations X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 14/02/2022 17:38, Jani Nikula wrote: > Prefer forward declarations over includes if possible. > > Signed-off-by: Jani Nikula Reviewed-by: Tvrtko Ursulin Regards, Tvrtko > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 2 ++ > drivers/gpu/drm/i915/gt/intel_lrc.h | 5 +++-- > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c > index 5b107b698b65..004e1216e654 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.c > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.c > @@ -8,6 +8,8 @@ > #include "gen8_engine_cs.h" > #include "i915_drv.h" > #include "i915_perf.h" > +#include "i915_reg.h" > +#include "intel_context.h" > #include "intel_engine.h" > #include "intel_engine_regs.h" > #include "intel_gpu_commands.h" > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.h b/drivers/gpu/drm/i915/gt/intel_lrc.h > index 2af85a15a370..0b76f096b559 100644 > --- a/drivers/gpu/drm/i915/gt/intel_lrc.h > +++ b/drivers/gpu/drm/i915/gt/intel_lrc.h > @@ -8,11 +8,12 @@ > > #include > > -#include "intel_context.h" > - > struct drm_i915_gem_object; > +struct i915_gem_ww_ctx; > +struct intel_context; > struct intel_engine_cs; > struct intel_ring; > +struct kref; > > /* At the start of the context image is its per-process HWS page */ > #define LRC_PPHWSP_PN (0)