From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FB0FC433DB for ; Thu, 28 Jan 2021 09:00:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2884064DD1 for ; Thu, 28 Jan 2021 09:00:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2884064DD1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E6BD6E946; Thu, 28 Jan 2021 09:00:52 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3822F6E946 for ; Thu, 28 Jan 2021 09:00:52 +0000 (UTC) IronPort-SDR: N4/SowwvFO6Fdi9H8IxNFaX9/NwxOnVWiaFoGFXS2lLB6zZYR+mUBHqgaeVw5vtFL89+leeMWt 5RxkMMb3SzNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9877"; a="199033697" X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="199033697" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 01:00:51 -0800 IronPort-SDR: FTZCcSOYzHdD26Owyj04QwlkErjBZcoe0e22sc8cWQmqh0izW7eFYzKnWQ8wYDEoH81QIcqiV3 frBzc9a3+TPw== X-IronPort-AV: E=Sophos;i="5.79,381,1602572400"; d="scan'208";a="362786169" Received: from nkaspi-mobl.ger.corp.intel.com (HELO [10.214.246.60]) ([10.214.246.60]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 01:00:50 -0800 To: Chris Wilson , intel-gfx@lists.freedesktop.org References: <20210127090608.16925-1-chris@chris-wilson.co.uk> From: Tvrtko Ursulin Organization: Intel Corporation UK Plc Message-ID: <98cfaefe-16b4-4b34-62d8-abf2ff559396@linux.intel.com> Date: Thu, 28 Jan 2021 09:00:46 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20210127090608.16925-1-chris@chris-wilson.co.uk> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Prefer local execution_mask for determing viable engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 27/01/2021 09:06, Chris Wilson wrote: > In gen8_emit_flush_xcs, we have to look at all the engines the request > may execute on, and emit an aux-invalidate for each. Currently, we > handle the virtual engine by looking at its engine mask, but that is > copied and refined as the request->execution_mask. If we prefer the > local mask, this is one fewer rq->engine pointer chasing we have to > eliminate later when we remove rq->engine. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/gt/gen8_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > index 07ba524da90b..cac80af7ad1c 100644 > --- a/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > +++ b/drivers/gpu/drm/i915/gt/gen8_engine_cs.c > @@ -277,7 +277,7 @@ int gen12_emit_flush_xcs(struct i915_request *rq, u32 mode) > if (mode & EMIT_INVALIDATE) > cmd += 2; > if (mode & EMIT_INVALIDATE) > - aux_inv = rq->engine->mask & ~BIT(BCS0); > + aux_inv = rq->execution_mask & ~BIT(BCS0); > if (aux_inv) > cmd += 2 * hweight8(aux_inv) + 2; > > Reviewed-by: Tvrtko Ursulin Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx