From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH] dma-fence: Use non-atomic bitops while under the lock Date: Thu, 3 Oct 2019 13:20:05 +0100 Message-ID: <994d2663-65d7-3351-3997-5a995e27d9f4@linux.intel.com> References: <20191003101247.809-1-tvrtko.ursulin@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191003101247.809-1-tvrtko.ursulin@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Intel-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAzLzEwLzIwMTkgMTE6MTIsIFR2cnRrbyBVcnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRr byBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4gCj4gV2UgZG8gbm90IGhhdmUg dG8gdXNlIGF0b21pYyBiaXRvcHMgd2hlbiBhbHJlYWR5IHVuZGVyIHRoZSBzcGlubG9jay4KPiAK PiBTYXZlcyBvbiBhIGhhbmRmdWwgb2YgbG9jayBpbnN0cnVjdGlvbiBwcmVmaXhlcywgb24geDg2 IGF0IGxlYXN0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz dWxpbkBpbnRlbC5jb20+Cj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBD YzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gLS0tCj4gICBkcml2 ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMgfCAxNCArKysrKysrLS0tLS0tLQo+ICAgMSBmaWxlIGNo YW5nZWQsIDcgaW5zZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5jIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5j Cj4gaW5kZXggMmMxMzZhZWUzZTc5Li5mMGI0ODAwNDJlMmYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9kbWEtYnVmL2RtYS1mZW5jZS5jCj4gKysrIGIvZHJpdmVycy9kbWEtYnVmL2RtYS1mZW5jZS5j Cj4gQEAgLTEzMywxNSArMTMzLDE1IEBAIGludCBkbWFfZmVuY2Vfc2lnbmFsX2xvY2tlZChzdHJ1 Y3QgZG1hX2ZlbmNlICpmZW5jZSkKPiAgIAo+ICAgCWxvY2tkZXBfYXNzZXJ0X2hlbGQoZmVuY2Ut PmxvY2spOwo+ICAgCj4gLQlpZiAodW5saWtlbHkodGVzdF9hbmRfc2V0X2JpdChETUFfRkVOQ0Vf RkxBR19TSUdOQUxFRF9CSVQsCj4gLQkJCQkgICAgICAmZmVuY2UtPmZsYWdzKSkpCj4gKwlpZiAo dW5saWtlbHkoX190ZXN0X2FuZF9zZXRfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwK PiArCQkJCQkmZmVuY2UtPmZsYWdzKSkpCgpUaGlzIGJyZWFrcyBsZWZ0IHJpZ2h0IGFuZCBjZW50 ZXIgc28gSSBndWVzcyBpdCBpcyBtb3JlIHN1YnRsZSB0aGFuIHRoaXMhCgpSZWdhcmRzLAoKVHZy dGtvCgo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAgIAo+ICAgCS8qIFN0YXNoIHRoZSBjYl9saXN0 IGJlZm9yZSByZXBsYWNpbmcgaXQgd2l0aCB0aGUgdGltZXN0YW1wICovCj4gICAJbGlzdF9yZXBs YWNlKCZmZW5jZS0+Y2JfbGlzdCwgJmNiX2xpc3QpOwo+ICAgCj4gICAJZmVuY2UtPnRpbWVzdGFt cCA9IGt0aW1lX2dldCgpOwo+IC0Jc2V0X2JpdChETUFfRkVOQ0VfRkxBR19USU1FU1RBTVBfQklU LCAmZmVuY2UtPmZsYWdzKTsKPiArCV9fc2V0X2JpdChETUFfRkVOQ0VfRkxBR19USU1FU1RBTVBf QklULCAmZmVuY2UtPmZsYWdzKTsKPiAgIAl0cmFjZV9kbWFfZmVuY2Vfc2lnbmFsZWQoZmVuY2Up Owo+ICAgCj4gICAJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKGN1ciwgdG1wLCAmY2JfbGlzdCwg bm9kZSkgewo+IEBAIC0zNDMsOCArMzQzLDggQEAgaW50IGRtYV9mZW5jZV9hZGRfY2FsbGJhY2so c3RydWN0IGRtYV9mZW5jZSAqZmVuY2UsIHN0cnVjdCBkbWFfZmVuY2VfY2IgKmNiLAo+ICAgCj4g ICAJc3Bpbl9sb2NrX2lycXNhdmUoZmVuY2UtPmxvY2ssIGZsYWdzKTsKPiAgIAo+IC0Jd2FzX3Nl dCA9IHRlc3RfYW5kX3NldF9iaXQoRE1BX0ZFTkNFX0ZMQUdfRU5BQkxFX1NJR05BTF9CSVQsCj4g LQkJCQkgICAmZmVuY2UtPmZsYWdzKTsKPiArCXdhc19zZXQgPSBfX3Rlc3RfYW5kX3NldF9iaXQo RE1BX0ZFTkNFX0ZMQUdfRU5BQkxFX1NJR05BTF9CSVQsCj4gKwkJCQkgICAgICZmZW5jZS0+Zmxh Z3MpOwo+ICAgCj4gICAJaWYgKHRlc3RfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwg JmZlbmNlLT5mbGFncykpCj4gICAJCXJldCA9IC1FTk9FTlQ7Cj4gQEAgLTQ3Myw4ICs0NzMsOCBA QCBkbWFfZmVuY2VfZGVmYXVsdF93YWl0KHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLCBib29sIGlu dHIsIHNpZ25lZCBsb25nIHRpbWVvdXQpCj4gICAJCWdvdG8gb3V0Owo+ICAgCX0KPiAgIAo+IC0J d2FzX3NldCA9IHRlc3RfYW5kX3NldF9iaXQoRE1BX0ZFTkNFX0ZMQUdfRU5BQkxFX1NJR05BTF9C SVQsCj4gLQkJCQkgICAmZmVuY2UtPmZsYWdzKTsKPiArCXdhc19zZXQgPSBfX3Rlc3RfYW5kX3Nl dF9iaXQoRE1BX0ZFTkNFX0ZMQUdfRU5BQkxFX1NJR05BTF9CSVQsCj4gKwkJCQkgICAgICZmZW5j ZS0+ZmxhZ3MpOwo+ICAgCj4gICAJaWYgKHRlc3RfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVE X0JJVCwgJmZlbmNlLT5mbGFncykpCj4gICAJCWdvdG8gb3V0Owo+IApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=