Re: [Intel-gfx] [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks

Hans de Goede
2022-07-14T19:43:26Z

Hi,

On 7/13/22 19:21, Limonciello, Mario wrote:
> [Public]
>
>
>
>> -----Original Message-----
>> From: Werner Sembach <wse@tuxedocomputers.com>
>> Sent: Wednesday, July 13, 2022 12:08
>> To: Hans de Goede <hdegoede@redhat.com>; Ben Skeggs
>> <bskeggs@redhat.com>; Karol Herbst <kherbst@redhat.com>; Lyude
>> <lyude@redhat.com>; Daniel Dadap <ddadap@nvidia.com>; Maarten
>> Lankhorst <maarten.lankhorst@linux.intel.com>; Maxime Ripard
>> <mripard@kernel.org>; Thomas Zimmermann <tzimmermann@suse.de>;
>> Jani Nikula <jani.nikula@linux.intel.com>; Joonas Lahtinen
>> <joonas.lahtinen@linux.intel.com>; Rodrigo Vivi <rodrigo.vivi@intel.com>;
>> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Deucher, Alexander
>> <Alexander.Deucher@amd.com>; Koenig, Christian
>> <Christian.Koenig@amd.com>; Pan@vger.kernel.org; Pan, Xinhui
>> <Xinhui.Pan@amd.com>; Rafael J . Wysocki <rafael@kernel.org>; Mika
>> Westerberg <mika.westerberg@linux.intel.com>; Lukas Wunner
>> <lukas@wunner.de>; Mark Gross <markgross@kernel.org>; Andy
>> Shevchenko <andy@kernel.org>
>> Cc: nouveau@lists.freedesktop.org; Daniel Vetter <daniel@ffwll.ch>; David
>> Airlie <airlied@linux.ie>; intel-gfx <intel-gfx@lists.freedesktop.org>; dri-
>> devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; Len Brown
>> <lenb@kernel.org>; linux-acpi@vger.kernel.org; platform-driver-
>> x86@vger.kernel.org
>> Subject: Re: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and
>> NL5xNU acpi_backlight=native quirks
>>
>> Hi,
>>
>> On 7/12/22 21:39, Hans de Goede wrote:
>>> acpi_backlight=native is the default for these, but as the comment
>>> explains the quirk was still necessary because even briefly registering
>>> the acpi_video0 backlight; and then unregistering it once the native
>>> driver showed up, was leading to issues.
>>>
>>> After the "ACPI: video: Make backlight class device registration
>>> a separate step" patch from earlier in this patch-series, we no
>>> longer briefly register the acpi_video0 backlight on systems where
>>> the native driver should be used.
>>>
>>> So this is no longer an issue an the quirks are no longer needed.
>>>
>>> Cc: Werner Sembach <wse@tuxedocomputers.com>
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Tested and can confirm: The quirks are no longer needed with this Patchset.
>>
>> Tested-by: Werner Sembach <wse@tuxedocomputers.com>
>
> Probably should include this link tag in this commit too then as it fixes
> the Tong Fang systems too.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683

Good point, I've added this to the version in my personal tree.

Regards,

Hans

>
>>
>> Kind Regards,
>>
>> Werner Sembach
>>
>>> ---
>>> drivers/acpi/video_detect.c | 75 -------------------------------------
>>> 1 file changed, 75 deletions(-)
>>>
>>> diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c
>>> index 2a4d376a703e..4b9395d1bda7 100644
>>> --- a/drivers/acpi/video_detect.c
>>> +++ b/drivers/acpi/video_detect.c
>>> @@ -599,81 +599,6 @@ static const struct dmi_system_id
>> video_detect_dmi_table[] = {
>>> DMI_MATCH(DMI_BOARD_NAME, "N250P"),
>>> },
>>> },
>>> - /*
>>> - * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have
>> both a
>>> - * working native and video interface. However the default detection
>>> - * mechanism first registers the video interface before unregistering
>>> - * it again and switching to the native interface during boot. This
>>> - * results in a dangling SBIOS request for backlight change for some
>>> - * reason, causing the backlight to switch to ~2% once per boot on
>> the
>>> - * first power cord connect or disconnect event. Setting the native
>>> - * interface explicitly circumvents this buggy behaviour, by avoiding
>>> - * the unregistering process.
>>> - */
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xRU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xRU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR,
>> "SchenkerTechnologiesGmbH"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xRU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xRU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "AURA1501"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xRU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xNU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xNU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR,
>> "SchenkerTechnologiesGmbH"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
>>> - },
>>> - },
>>> - {
>>> - .callback = video_detect_force_native,
>>> - .ident = "Clevo NL5xNU",
>>> - .matches = {
>>> - DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
>>> - DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),
>>> - },
>>> - },
>>>
>>> /*
>>> * Desktops which falsely report a backlight and which our heuristics