From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH 1/8] drm/omap: Simplify the rotation-on-crtc hack Date: Tue, 25 Jul 2017 10:47:04 +0200 Message-ID: <9a42cbd2-70e1-0654-2146-6cc4c8e058aa@linux.intel.com> References: <20170725080122.20548-1-daniel.vetter@ffwll.ch> <20170725080122.20548-2-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170725080122.20548-2-daniel.vetter@ffwll.ch> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , Intel Graphics Development Cc: Daniel Vetter , Tomi Valkeinen , Laurent Pinchart , DRI Development List-Id: intel-gfx@lists.freedesktop.org T3AgMjUtMDctMTcgb20gMTA6MDEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IEkgd2FudC9uZWVk IHRvIHJld29yayB0aGUgY29yZSBwcm9wZXJ0eSBoYW5kbGluZywgYW5kIHRoaXMgaGFjayBpcwo+ IGdldHRpbmcgaW4gdGhlIHdheS4gQnV0IHNpbmNlIGl0J3MgYSBub24tc3RhbmRhcmQgcHJvcGV0 eSBvbmx5IHVzZWQgYnkKPiBsZWdhY3kgdXNlcnNwYWNlIHdlIGtub3cgdGhhdCB0aGlzIHdpbGwg b25seSBldmVyeSBiZSBjYWxsZWQgZnJvbQo+IGlvY3RsIGNvZGUuIEFuZCBuZXZlciBvbiBzb21l IG90aGVyIGZyZWUtc3RhbmRpbmcgc3RhdGUgc3RydWN0LCB3aGVyZQo+IHRoaXMgb2xkIGhhY2sg d291bGRuJ3Qgd29yayBlaXRoZXIuCj4KPiB2MjogZG9uJ3QgZm9yZ2V0IHpvcmRlciBhbmQgZ2V0 X3Byb3BlcnR5IQo+Cj4gQ2M6IFRvbWkgVmFsa2VpbmVuIDx0b21pLnZhbGtlaW5lbkB0aS5jb20K PiBDYzogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29t Pgo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYyB8IDY0ICsrKysr KysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI4IGlu c2VydGlvbnMoKyksIDM2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9vbWFwZHJtL29tYXBfY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vb21hcF9j cnRjLmMKPiBpbmRleCAxNGU4YTc3MzhiMDYuLmVmYTUyNTQ0MmU3ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9vbWFwZHJtL29tYXBfY3J0Yy5jCj4gQEAgLTQ5OCwzOSArNDk4LDMwIEBAIHN0YXRpYyB2b2lk IG9tYXBfY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICAJc3Bpbl91 bmxvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOwo+ICB9Cj4gIAo+IC1zdGF0aWMgYm9v bCBvbWFwX2NydGNfaXNfcGxhbmVfcHJvcChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gLQlzdHJ1 Y3QgZHJtX3Byb3BlcnR5ICpwcm9wZXJ0eSkKPiAtewo+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGNydGMtPmRldjsKPiAtCXN0cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2ID0gZGV2LT5k ZXZfcHJpdmF0ZTsKPiAtCj4gLQlyZXR1cm4gcHJvcGVydHkgPT0gcHJpdi0+em9yZGVyX3Byb3Ag fHwKPiAtCQlwcm9wZXJ0eSA9PSBjcnRjLT5wcmltYXJ5LT5yb3RhdGlvbl9wcm9wZXJ0eTsKPiAt fQo+IC0KPiAgc3RhdGljIGludCBvbWFwX2NydGNfYXRvbWljX3NldF9wcm9wZXJ0eShzdHJ1Y3Qg ZHJtX2NydGMgKmNydGMsCj4gIAkJCQkJIHN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqc3RhdGUsCj4g IAkJCQkJIHN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5LAo+ICAJCQkJCSB1aW50NjRfdCB2 YWwpCj4gIHsKPiAtCWlmIChvbWFwX2NydGNfaXNfcGxhbmVfcHJvcChjcnRjLCBwcm9wZXJ0eSkp IHsKPiAtCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiAtCQlzdHJ1Y3Qg ZHJtX3BsYW5lICpwbGFuZSA9IGNydGMtPnByaW1hcnk7Cj4gLQo+IC0JCS8qCj4gLQkJICogRGVs ZWdhdGUgcHJvcGVydHkgc2V0IHRvIHRoZSBwcmltYXJ5IHBsYW5lLiBHZXQgdGhlIHBsYW5lCj4g LQkJICogc3RhdGUgYW5kIHNldCB0aGUgcHJvcGVydHkgZGlyZWN0bHkuCj4gLQkJICovCj4gLQo+ IC0JCXBsYW5lX3N0YXRlID0gZHJtX2F0b21pY19nZXRfcGxhbmVfc3RhdGUoc3RhdGUtPnN0YXRl LCBwbGFuZSk7Cj4gLQkJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkpCj4gLQkJCXJldHVybiBQVFJf RVJSKHBsYW5lX3N0YXRlKTsKPiArCXN0cnVjdCBvbWFwX2RybV9wcml2YXRlICpwcml2ID0gY3J0 Yy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5lX3N0 YXRlOwo+ICAKPiAtCQlyZXR1cm4gZHJtX2F0b21pY19wbGFuZV9zZXRfcHJvcGVydHkocGxhbmUs IHBsYW5lX3N0YXRlLAo+IC0JCQkJcHJvcGVydHksIHZhbCk7Cj4gLQl9Cj4gKwkvKgo+ICsJICog RGVsZWdhdGUgcHJvcGVydHkgc2V0IHRvIHRoZSBwcmltYXJ5IHBsYW5lLiBHZXQgdGhlIHBsYW5l Cj4gKwkgKiBzdGF0ZSBhbmQgc2V0IHRoZSBwcm9wZXJ0eSBkaXJlY3RseS4KPiArCSAqLwo+ICsJ cGxhbmVfc3RhdGUgPSBkcm1fYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZS0+c3RhdGUsIGNy dGMtPnByaW1hcnkpOwo+ICsJaWYgKElTX0VSUihwbGFuZV9zdGF0ZSkpCj4gKwkJcmV0dXJuIFBU Ul9FUlIocGxhbmVfc3RhdGUpOwo+ICsKPiArCWlmIChwcm9wZXJ0eSA9PSBjcnRjLT5wcmltYXJ5 LT5yb3RhdGlvbl9wcm9wZXJ0eSkKPiArCQlwbGFuZV9zdGF0ZS0+cm90YXRpb24gPSB2YWw7Cj4g KwllbHNlIGlmIChwcm9wZXJ0eSA9PSBwcml2LT56b3JkZXJfcHJvcCkKPiArCQlwbGFuZV9zdGF0 ZS0+enBvcyA9IHZhbDsKPiArCWVsc2UKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiAgCj4gLQlyZXR1 cm4gLUVJTlZBTDsKPiArCXJldHVybiAwOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50IG9tYXBfY3J0 Y19hdG9taWNfZ2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiBAQCAtNTM4LDE2 ICs1MjksMTcgQEAgc3RhdGljIGludCBvbWFwX2NydGNfYXRvbWljX2dldF9wcm9wZXJ0eShzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQkJIHN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3BlcnR5 LAo+ICAJCQkJCSB1aW50NjRfdCAqdmFsKQo+ICB7Cj4gLQlpZiAob21hcF9jcnRjX2lzX3BsYW5l X3Byb3AoY3J0YywgcHJvcGVydHkpKSB7Cj4gLQkJLyoKPiAtCQkgKiBEZWxlZ2F0ZSBwcm9wZXJ0 eSBnZXQgdG8gdGhlIHByaW1hcnkgcGxhbmUuIFRoZQo+IC0JCSAqIGRybV9hdG9taWNfcGxhbmVf Z2V0X3Byb3BlcnR5KCkgZnVuY3Rpb24gaXNuJ3QgZXhwb3J0ZWQsIGJ1dAo+IC0JCSAqIGNhbiBi ZSBjYWxsZWQgdGhyb3VnaCBkcm1fb2JqZWN0X3Byb3BlcnR5X2dldF92YWx1ZSgpIGFzIHRoYXQK PiAtCQkgKiB3aWxsIGNhbGwgZHJtX2F0b21pY19nZXRfcHJvcGVydHkoKSBmb3IgYXRvbWljIGRy aXZlcnMuCj4gLQkJICovCj4gLQkJcmV0dXJuIGRybV9vYmplY3RfcHJvcGVydHlfZ2V0X3ZhbHVl KCZjcnRjLT5wcmltYXJ5LT5iYXNlLAo+IC0JCQkJcHJvcGVydHksIHZhbCk7Cj4gLQl9Cj4gKwlz dHJ1Y3Qgb21hcF9kcm1fcHJpdmF0ZSAqcHJpdiA9IGNydGMtPmRldi0+ZGV2X3ByaXZhdGU7Cj4g Kwo+ICsJLyoKPiArCSAqIFJlbWFwIHRvIHRoZSBwbGFuZSByb3RhdGlvbi96b3JkZXIgcHJvcGVy dHkuIFdlIGNhbiBwZWVrIGF0IHRoZSBwbGFuZQo+ICsJICogc3RhdGUgZGlyZWN0bHkgc2luY2Ug aG9sZGluZyB0aGUgY3J0YyBsb2NrcyBnaXZlcyB5b3UgYSByZWFkLWxvY2sgb24KPiArCSAqIHRo ZSBwbGFuZSBzdGF0ZS4KPiArCSAqLwo+ICsJaWYgKHByb3BlcnR5ID09IGNydGMtPnByaW1hcnkt PnJvdGF0aW9uX3Byb3BlcnR5KQo+ICsJCXJldHVybiBjcnRjLT5wcmltYXJ5LT5zdGF0ZS0+cm90 YXRpb247Cj4gKwllbHNlIGlmIChwcm9wZXJ0eSA9PSBwcml2LT56b3JkZXJfcHJvcCkKPiArCQly ZXR1cm4gY3J0Yy0+cHJpbWFyeS0+c3RhdGUtPnpwb3M7Cj4gIAo+ICAJcmV0dXJuIC1FSU5WQUw7 Cj4gIH0KCmFjcXVpcmVfY3R4IGZvciBjcnRjJ3MgZ2V0cHJvcCB0b28gdGhlbj8KClRoZSBjb21t ZW50IGFib3V0IHJlYWQgbG9jayBpcyBvbmx5IHZhbGlkIHdoZW4gdGhlIHBsYW5lIGlzIGJvdW5k IHRvIHRoZSBjcnRjLiBJbiBnZW5lcmFsIHRoaXMgaXMgbm90IGFsd2F5cyB0aGUgY2FzZS4KWW91 IGNhbiBvbmx5IHBlYWsgYXQgcGxhbmUtPnN0YXRlIHdoZW4gY3J0Yy0+c3RhdGUtPnBsYW5lX21h c2sgJiBCSVQoZHJtX3BsYW5lX2luZGV4KHBsYW5lKSkgaXMgdHJ1ZS4KCkkgdGhpbmsgd2UgbWln aHQgbmVlZCAtRURFQURMSyBoYW5kbGluZyBmb3IgZ2V0cHJvcCB0aGVuLCBldmVuIHRob3VnaCBp dCdzIG5vdCBvcHRpbWFsLiA6KAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4Cg==