public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: Dongwon Kim <dongwon.kim@intel.com>
Subject: Re: [PATCH] drm/i915: Split obj->cache_coherent to track r/w
Date: Fri, 11 Aug 2017 09:26:10 +0200	[thread overview]
Message-ID: <9b99c42c-e883-9f00-af92-73d8a8b79551@linux.intel.com> (raw)
In-Reply-To: <20170810162035.30547-1-chris@chris-wilson.co.uk>

Op 10-08-17 om 18:20 schreef Chris Wilson:
> Another month, another story in the cache coherency saga. This time, we
> come to the realisation that i915_gem_object_is_coherent() has been
> reporting whether we can read from the target without requiring a cache
> invalidate; but we were using it in places for testing whether we could
> write into the object without requiring a cache flush. So split the
> tracking into two, one to decide before reads, one after writes.
>
> See commit e27ab73d17ef ("drm/i915: Mark CPU cache as dirty on every
> transition for CPU writes") for the previous step in this saga.
>
> Testcase: igt/kms_mmap_write_crc
> Testcase: igt/kms_pwrite_crc
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Dongwon Kim <dongwon.kim@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101109
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101555

Tested-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2017-08-11  7:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 16:20 [PATCH] drm/i915: Split obj->cache_coherent to track r/w Chris Wilson
2017-08-10 16:53 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-08-11  7:26 ` Maarten Lankhorst [this message]
2017-08-11  8:08 ` [PATCH] " Joonas Lahtinen
2017-08-11 10:11 ` [PATCH v2] " Chris Wilson
2017-08-11 11:12   ` Chris Wilson
2017-08-11 10:23 ` [PATCH v3] " Chris Wilson
2017-08-11 10:55 ` ✗ Fi.CI.BAT: failure for drm/i915: Split obj->cache_coherent to track r/w (rev3) Patchwork
2017-08-11 11:11 ` [PATCH v4] drm/i915: Split obj->cache_coherent to track r/w Chris Wilson
2017-08-15 14:34   ` Joonas Lahtinen
2017-08-15 14:51     ` Chris Wilson
2017-08-11 11:44 ` ✓ Fi.CI.BAT: success for drm/i915: Split obj->cache_coherent to track r/w (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b99c42c-e883-9f00-af92-73d8a8b79551@linux.intel.com \
    --to=maarten.lankhorst@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=dongwon.kim@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox