From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F12DC433EF for ; Thu, 7 Oct 2021 18:24:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA9CE61260 for ; Thu, 7 Oct 2021 18:24:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA9CE61260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 554EE6F3F9; Thu, 7 Oct 2021 18:24:09 +0000 (UTC) Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by gabe.freedesktop.org (Postfix) with ESMTPS id C47FE6F402 for ; Thu, 7 Oct 2021 18:18:35 +0000 (UTC) Received: by mail-lf1-x134.google.com with SMTP id u18so28314994lfd.12 for ; Thu, 07 Oct 2021 11:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=GaaoQU4RwWjB9gMX0zTayj8arHYS00z7YQ4ZBG1QPj8=; b=HIbTcZTNjTYjFUaPveRX/q3EXkuRArzsYTOXTKc5c5bYjxiScr1eEwGrBe4Bb8/pmD URH8XGjdGoO1FEstMb40qi5tSSvPPM4U0ZNCiZtFbEge+h6Isa+fkBbemljdMVB8C5Iw NmecAtBYYsKhVQE6Uio6TEdCNaNlegyDlNai/1FplQUaF+O2NRbAvJDAbTkI2Jq+D4Ls ro+sCIPI4o/i8Xv4Zy6ZX6lJ/3Z6fL7hAQ+InVbEIkZPLPc4oE3OTnirA1NjGoboKw7o tgermBz7KLOdiS5/5Ulbm87Py3qpYJVReh2AeAAQHAivY9xkgbJJ2Yk04J8z1C3EhMov AzEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=GaaoQU4RwWjB9gMX0zTayj8arHYS00z7YQ4ZBG1QPj8=; b=lOHdKQJzRxOP/P12T5KE/feLHMkcT+//brjweZPPkgzeC7EGuqi1AQO818ZuRLQ8ZA SxRGU5Vchf/wUqBPsoSekOkKb0ynt87QU30ux5W+aZNEODBfI24Yx+ojRSc24RaWyfqj l9wwue+1L9XjS+acfmS/y7d8ddqfOd+ChRUgduARR7jPB/bpOhowLZX3BqKuiEHGGE+S l4e99K1bY6ujIWdpRpYunEQeIN/htpR1mdWSZKwRXfwFRWQxRv5JwwFqD53iD2bOe3Xg wRuw0bX4FsLxWVBc3x6YM3nuZ4QlV6qO1h0Qr32EiAe9vvSPo0/l6jL2d973Pwub4/gM jUaw== X-Gm-Message-State: AOAM532PiCvAUdklGv32lnEr6qCBHd+ceojjsqIEdRbTzbvulvdgLEOP qwMJ43Q2Ja9BwS88u2DMvCeuZl1kV2A= X-Google-Smtp-Source: ABdhPJwg7a/dEMfnCDHLPNTVAQHzl+Qvs60nO9B3KsBPa0UkDx7JxdScHxS+2hGk/jwcEcFv/FCD8A== X-Received: by 2002:a19:c10d:: with SMTP id r13mr6053718lff.339.1633630714116; Thu, 07 Oct 2021 11:18:34 -0700 (PDT) Received: from ?IPv6:2a02:908:1252:fb60:31d2:f7ff:65ef:5cb3? ([2a02:908:1252:fb60:31d2:f7ff:65ef:5cb3]) by smtp.gmail.com with ESMTPSA id f21sm7539ljn.94.2021.10.07.11.18.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Oct 2021 11:18:33 -0700 (PDT) To: Tvrtko Ursulin , "Vudum, Lakshminarayana" , "intel-gfx@lists.freedesktop.org" References: <20211006091614.970596-1-matthew.auld@intel.com> <163353397200.5959.9158572900274841139@emeril.freedesktop.org> <37de5d6f8af149d2be998a3991c8ef4d@intel.com> <64167c40-1d54-735e-89cf-4df9d95d5a97@linux.intel.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <9bcbf976-532c-29fc-6292-281de8cea1ba@gmail.com> Date: Thu, 7 Oct 2021 20:18:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <64167c40-1d54-735e-89cf-4df9d95d5a97@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Mailman-Approved-At: Thu, 07 Oct 2021 18:24:08 +0000 Subject: Re: [Intel-gfx] =?utf-8?b?4pyXIEZpLkNJLklHVDogZmFpbHVyZSBmb3Igc2Vy?= =?utf-8?q?ies_starting_with_=5Bv7=2C1/8=5D_drm/i915/gem=3A_Break_out_some?= =?utf-8?q?_shmem_backend_utils?= X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Am 07.10.21 um 17:53 schrieb Tvrtko Ursulin: > > On 07/10/2021 16:18, Vudum, Lakshminarayana wrote: >> -----Original Message----- >> From: Tvrtko Ursulin >> Sent: Thursday, October 7, 2021 6:41 AM >> To: Christian König ; >> intel-gfx@lists.freedesktop.org >> Cc: Vudum, Lakshminarayana >> Subject: Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting >> with [v7,1/8] drm/i915/gem: Break out some shmem backend utils >> >> >> On 07/10/2021 13:57, Christian König wrote: >>> Am 07.10.21 um 12:51 schrieb Tvrtko Ursulin: >>>> >>>> On 07/10/2021 10:19, Christian König wrote: >>>>> Am 07.10.21 um 11:15 schrieb Tvrtko Ursulin: >>>>>> Hi, >>>>>> >>>>>> On 06/10/2021 16:26, Patchwork wrote: >>>>>>> *Patch Details* >>>>>>> *Series:*    series starting with [v7,1/8] drm/i915/gem: Break out >>>>>>> some shmem backend utils >>>>>>> *URL:* https://patchwork.freedesktop.org/series/95501/ >>>>>>> >>>>>>> *State:*    failure >>>>>>> *Details:* >>>>>>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21264/index.htm >>>>>>> l >>>>>>> >>>>>> ml> >>>>>>> >>>>>>> >>>>>>>    CI Bug Log - changes from CI_DRM_10688_full -> >>>>>>> Patchwork_21264_full >>>>>>> >>>>>>> >>>>>>>      Summary >>>>>>> >>>>>>> *FAILURE* >>>>>>> >>>>>>> Serious unknown changes coming with Patchwork_21264_full >>>>>>> absolutely need to be verified manually. >>>>>>> >>>>>>> If you think the reported changes have nothing to do with the >>>>>>> changes introduced in Patchwork_21264_full, please notify your bug >>>>>>> team to allow them to document this new failure mode, which will >>>>>>> reduce false positives in CI. >>>>>>> >>>>>>> >>>>>>>      Possible new issues >>>>>>> >>>>>>> Here are the unknown changes that may have been introduced in >>>>>>> Patchwork_21264_full: >>>>>>> >>>>>>> >>>>>>>        IGT changes >>>>>>> >>>>>>> >>>>>>>          Possible regressions >>>>>>> >>>>>>>    * >>>>>>> >>>>>>>      igt@gem_sync@basic-many-each: >>>>>>> >>>>>>>        o shard-apl: NOTRUN -> INCOMPLETE >>>>>>> >>>>>> l7/igt@gem_sync@basic-many-each.html> >>>>>>> >>>>>> Something still fishy in the unlocked iterator? Or >>>>>> dma_resv_get_fences using it? >>>>> >>>>> Probably the later. I'm going to take a look. >>>>> >>>>> Thanks for the notice, >>>>> Christian. >>>>> >>>>>> >>>>>> <6> [187.551235] [IGT] gem_sync: starting subtest basic-many-each >>>>>> <1> [188.935462] BUG: kernel NULL pointer dereference, address: >>>>>> 0000000000000010 >>>>>> <1> [188.935485] #PF: supervisor write access in kernel mode <1> >>>>>> [188.935495] #PF: error_code(0x0002) - not-present page <6> >>>>>> [188.935504] PGD 0 P4D 0 <4> [188.935512] Oops: 0002 [#1] PREEMPT >>>>>> SMP NOPTI <4> [188.935521] CPU: 2 PID: 1467 Comm: gem_sync Not >>>>>> tainted 5.15.0-rc4-CI-Patchwork_21264+ #1 <4> [188.935535] Hardware >>>>>> name:  /NUC6CAYB, BIOS >>>>>> AYAPLCEL.86A.0049.2018.0508.1356 05/08/2018 <4> [188.935546] RIP: >>>>>> 0010:dma_resv_get_fences+0x116/0x2d0 >>>>>> <4> [188.935560] Code: 10 85 c0 7f c9 be 03 00 00 00 e8 15 8b df ff >>>>>> eb bd e8 8e c6 ff ff eb b6 41 8b 04 24 49 8b 55 00 48 89 e7 8d 48 >>>>>> 01 >>>>>> 41 89 0c 24 <4c> 89 34 c2 e8 41 f2 ff ff 49 89 c6 48 85 c0 75 8c 48 >>>>>> 8b 44 24 10 <4> [188.935583] RSP: 0018:ffffc900011dbcc8 EFLAGS: >>>>>> 00010202 <4> [188.935593] RAX: 0000000000000000 RBX: >>>>>> 00000000ffffffff RCX: >>>>>> 0000000000000001 >>>>>> <4> [188.935603] RDX: 0000000000000010 RSI: ffffffff822e343c RDI: >>>>>> ffffc900011dbcc8 >>>>>> <4> [188.935613] RBP: ffffc900011dbd48 R08: ffff88812d255bb8 R09: >>>>>> 00000000fffffffe >>>>>> <4> [188.935623] R10: 0000000000000001 R11: 0000000000000000 R12: >>>>>> ffffc900011dbd44 >>>>>> <4> [188.935633] R13: ffffc900011dbd50 R14: ffff888113d29cc0 R15: >>>>>> 0000000000000000 >>>>>> <4> [188.935643] FS:  00007f68d17e9700(0000) >>>>>> GS:ffff888277900000(0000) knlGS:0000000000000000 <4> [188.935655] >>>>>> CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4> [188.935665] >>>>>> CR2: 0000000000000010 CR3: 000000012d0a4000 CR4: >>>>>> 00000000003506e0 >>>>>> <4> [188.935676] Call Trace: >>>>>> <4> [188.935685]  i915_gem_object_wait+0x1ff/0x410 [i915] <4> >>>>>> [188.935988]  i915_gem_wait_ioctl+0xf2/0x2a0 [i915] <4> >>>>>> [188.936272]  ? i915_gem_object_wait+0x410/0x410 [i915] <4> >>>>>> [188.936533]  drm_ioctl_kernel+0xae/0x140 <4> [188.936546] >>>>>> drm_ioctl+0x201/0x3d0 <4> [188.936555]  ? >>>>>> i915_gem_object_wait+0x410/0x410 [i915] <4> [188.936820]  ? >>>>>> __fget_files+0xc2/0x1c0 <4> [188.936830]  ? __fget_files+0xda/0x1c0 >>>>>> <4> [188.936839]  __x64_sys_ioctl+0x6d/0xa0 <4> [188.936848] >>>>>> do_syscall_64+0x3a/0xb0 <4> [188.936859] >>>>>> entry_SYSCALL_64_after_hwframe+0x44/0xae >>>> >>>> FWIW if you disassemble the code it seems to be crashing in: >>>> >>>>    (*shared)[(*shared_count)++] = fence; // mov %r14, (%rdx, %rax, 8) >>>> >>>> RDX is *shared, RAX is *shared_count, RCX is *shared_count++ (for the >>>> next iteration. R13 is share and R12 shared_count. >>>> >>>> That *shared can contain 0000000000000010 makes no sense to me. At >>>> least yet. :) >>> >>> Yeah, me neither. I've gone over the whole code multiple time now and >>> absolutely don't get what's happening here. >>> >>> Adding some more selftests didn't helped either. As far as I can see >>> the code works as intended. >>> >>> Do we have any other reports of crashes? >> >> Yes, sporadic but present across different platforms since the change >> went it: >> https://intel-gfx-ci.01.org/tree/drm-tip/igt@gem_sync@basic-many-each.html. >> >> So issue is probably real. >> >> Did not find any other tests failing with the same signature. Lakshmi >> are you perhaps able to search for the same or similar signature >> across the whole set of recent results? >> >> [Lakshmi] Both the regressions failures are new. I filed below issues >> and reported. > > > Thanks Lakshmi! > > Christian, maybe revert for now since it looks tricky to figure out? I > at least couldn't spent much time looking at it today. Or try to find > a third set of eyes to look at it quickly in case we are not seeing > something. > > Looks like a good selftest will be needed here for robustness. > Including threads to trigger restarts and external manipulation to hit > the refcount zero. Yeah, agree. Already working on that. Going to send out the revert for dma_resv_get_fences() tomorrow. Christian. > > Regards, > > Tvrtko > >> https://gitlab.freedesktop.org/drm/intel/-/issues/4275 >> igt@i915_pm_dc@dc9-dpms - fail - Failed assertion: >> dc9_wait_entry(data->debugfs_fd, dc_target, prev_dc, 3000), DC9 state >> is not achieved >> >> https://gitlab.freedesktop.org/drm/intel/-/issues/4274 >> igt@gem_sync@basic-many-each - incomplete - RIP: >> 0010:dma_resv_get_fences >> >> Regards, >> >> Tvrtko >>