From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 2/2] drm/i915: Don't manually add connectors and planes state Date: Thu, 28 Feb 2019 21:27:48 +0000 Message-ID: <9c83104b936838652df9de8b7919894fe2ea24eb.camel@intel.com> References: <20190227230408.31390-1-jose.souza@intel.com> <20190227230408.31390-2-jose.souza@intel.com> <20190228113705.GE20097@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2092710003==" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D0396E239 for ; Thu, 28 Feb 2019 21:27:50 +0000 (UTC) In-Reply-To: <20190228113705.GE20097@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "ville.syrjala@linux.intel.com" Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org --===============2092710003== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-Ir8MS/gLRfu60WctJqMl" --=-Ir8MS/gLRfu60WctJqMl Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2019-02-28 at 13:37 +0200, Ville Syrj=C3=A4l=C3=A4 wrote: > On Wed, Feb 27, 2019 at 03:04:08PM -0800, Jos=C3=A9 Roberto de Souza > wrote: > > drm_atomic_commit() call chain already takes care of adding > > connectors and planes, so lets no add then manually if not changing > > their states. >=20 > The specific callgraph would make review easier. Appending this to the commit message is enough? drm_atomic_commit() drm_atomic_check_only() config->funcs->atomic_check()/intel_atomic_check() drm_atomic_helper_check() drm_atomic_helper_check_modeset() for_each_oldnew_crtc_in_state() drm_atomic_add_affected _connectors() drm_atomic_add_affected _planes() >=20 > > Cc: Ville Syrj=C3=A4l=C3=A4 > > Cc: Lyude Paul > > Signed-off-by: Jos=C3=A9 Roberto de Souza > > --- > > drivers/gpu/drm/i915/intel_ddi.c | 8 -------- > > 1 file changed, 8 deletions(-) > >=20 > > diff --git a/drivers/gpu/drm/i915/intel_ddi.c > > b/drivers/gpu/drm/i915/intel_ddi.c > > index 34dd5823398a..c22ddde2dfc1 100644 > > --- a/drivers/gpu/drm/i915/intel_ddi.c > > +++ b/drivers/gpu/drm/i915/intel_ddi.c > > @@ -3975,14 +3975,6 @@ static int modeset_pipe(struct drm_crtc > > *crtc, > > =20 > > crtc_state->mode_changed =3D true; > > =20 > > - ret =3D drm_atomic_add_affected_connectors(state, crtc); > > - if (ret) > > - goto out; > > - > > - ret =3D drm_atomic_add_affected_planes(state, crtc); > > - if (ret) > > - goto out; > > - > > ret =3D drm_atomic_commit(state); > > out: > > drm_atomic_state_put(state); > > --=20 > > 2.21.0 --=-Ir8MS/gLRfu60WctJqMl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlx4UlMACgkQVenbO/mO WkkCZwf/RWzFDpn1UCf/t1iq4gnOGh8ALJWaYKYEEJ8oFanjK98CbrPLLLD2ip3B FxZyrrw0/PVzMgMDSAQzDBgPDJv1Z1Be61Ebd59D8UzccqxALK5TMGHOlFy9WOar zGvmr20xeqsVAzuCtGLqm3yRyr+Y9y/CGPhXS5lNpnwykgLCvM56AaH9WD/Ye6/n eW6A/BOBLV4lja85b91vAqi3/1yjoBwTfXvbI4AL1rwj2O9a9MEfEQVqwxKk8Is+ CbSswhKOH29Rrt0SYiThGS4ks+NnB36pOZgI7bCFNK9V4enL1Hmtj8Sc9cWYxD50 Dcpm3M6KHwzm5Op/oujVRVokdE1e4w== =4L4C -----END PGP SIGNATURE----- --=-Ir8MS/gLRfu60WctJqMl-- --===============2092710003== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============2092710003==--