From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/lrc: Skip no-op per-bb buffer on gen9
Date: Thu, 21 Sep 2017 16:12:21 +0100 [thread overview]
Message-ID: <9c834ebe-290f-60ee-ccc2-f1d65d513b16@linux.intel.com> (raw)
In-Reply-To: <20170921135444.27330-2-chris@chris-wilson.co.uk>
On 21/09/2017 14:54, Chris Wilson wrote:
> Since we inherited the context image setup from gen8 which needed a
> per-bb workaround (for GPGPU), we are submitting an empty per-bb buffer
> on gen9. Now that we can skip adding the buffer to the context image,
> remove the dangling per-bb. This slightly improves execution latency,
> most notably on an idle engine.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=87725
How much of the 7% we get back? :)
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index 297c9c1564e5..91a5411bb9da 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1171,13 +1171,6 @@ static u32 *gen9_init_indirectctx_bb(struct intel_engine_cs *engine, u32 *batch)
> return batch;
> }
>
> -static u32 *gen9_init_perctx_bb(struct intel_engine_cs *engine, u32 *batch)
> -{
> - *batch++ = MI_BATCH_BUFFER_END;
> -
> - return batch;
> -}
> -
> #define CTX_WA_BB_OBJ_SIZE (PAGE_SIZE)
>
> static int lrc_setup_wa_ctx(struct intel_engine_cs *engine)
> @@ -1234,7 +1227,7 @@ static int intel_init_workaround_bb(struct intel_engine_cs *engine)
> return 0;
> case 9:
> wa_bb_fn[0] = gen9_init_indirectctx_bb;
> - wa_bb_fn[1] = gen9_init_perctx_bb;
> + wa_bb_fn[1] = NULL;
> break;
> case 8:
> wa_bb_fn[0] = gen8_init_indirectctx_bb;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-21 15:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:54 [PATCH 1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set Chris Wilson
2017-09-21 13:54 ` [PATCH 2/2] drm/i915/lrc: Skip no-op per-bb buffer on gen9 Chris Wilson
2017-09-21 15:12 ` Tvrtko Ursulin [this message]
2017-09-21 15:41 ` Chris Wilson
2017-09-21 14:53 ` ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set Patchwork
2017-09-21 15:10 ` [PATCH 1/2] " Tvrtko Ursulin
2017-09-21 16:38 ` ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
2017-09-25 9:23 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c834ebe-290f-60ee-ccc2-f1d65d513b16@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox