From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99034CA5FCB for ; Thu, 1 Oct 2026 15:16:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 172B310F6E4; Thu, 1 Oct 2026 15:16:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NjwqUDYT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2CC310F6E4; Thu, 1 Oct 2026 15:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790867786; x=1822403786; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=JlBw68LgQV6D1qQGQNYyJnssQKOxlOHYpA9JX6VTMDE=; b=NjwqUDYT1md6uoWpvye7w+RIosr0B4MUCMZTmee+Cqd2CoQV4HjhR4Dq ifc+MGClN3LGNVfkZIBUFPyrBtfrzPUtCWT1XwQCkEHVxe+cTQXolhtOy /ifOZqZIW5k6yEq7z+vhWFjhK2pQ5FSgX3KVogtntmE7dcrDsko19R8f8 kiVCao73CSI3TtZqsWRhQpCmbkisRjzACgoEFlLGofbJB2CUotCQ6Nxyp mWL2IWpJBiiTCmipBt/YKDotH1SW6eCfUdzY1TfBSls1Lu922rzTPVsKa kPsXs4s5ybXpL6ynicH7ywIhM2h27I6JqA4B7tojQU2Wbw1B5bODvsO2R w==; X-CSE-ConnectionGUID: lHwVJwF9RDKnqyo8pkCisw== X-CSE-MsgGUID: PWtmDVsZR1eoNAmrvw0nxg== X-IronPort-AV: E=McAfee;i="6800,10657,11922"; a="90579681" X-IronPort-AV: E=Sophos;i="6.27,134,1787036400"; d="scan'208";a="90579681" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2026 08:16:26 -0700 X-CSE-ConnectionGUID: KkhDUT8AQQuf+w0ItaRofA== X-CSE-MsgGUID: nKJU+EntRZqjb2oMzPnknA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,134,1787036400"; d="scan'208";a="276134308" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.111]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Oct 2026 08:16:24 -0700 From: Jani Nikula To: Ville Syrjala , intel-gfx@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Subject: Re: [PATCH 2/3] drm/i915/dp: Drop using intel_de_read_notrace() In-Reply-To: <971cd820abef78c947ee66a98b4c1a7a433ec361@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260930115303.24285-1-ville.syrjala@linux.intel.com> <20260930115303.24285-2-ville.syrjala@linux.intel.com> <971cd820abef78c947ee66a98b4c1a7a433ec361@intel.com> Date: Thu, 01 Oct 2026 18:16:21 +0300 Message-ID: <9e1c45b240823b3ba2351a90a1207cfcf59b6685@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 30 Sep 2026, Jani Nikula wrote: > On Wed, 30 Sep 2026, Ville Syrjala wrote: >> From: Ville Syrj=C3=A4l=C3=A4 >> >> I want to eliminate intel_de_read_notrace() to shrink the >> intel_de.h API a bit. That should help with the cleaning out >> the remaining uncore mess for xe vs. i915. >> >> Furthermore on xe intel_de_read_notrace() doesn't even do >> what it says on the tin, and instead all register accesses >> are traced anyway. >> >> Switch the last users of intel_de_read_notrace() >> (intel_dp_aux_wait_done() and intel_dp_aux_xfer()) >> over to the normal intel_de_read(). >> >> Signed-off-by: Ville Syrj=C3=A4l=C3=A4 >> --- >> drivers/gpu/drm/i915/display/intel_dp_aux.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux.c b/drivers/gpu/d= rm/i915/display/intel_dp_aux.c >> index 3cb07b0a901c..cd361164ecb8 100644 >> --- a/drivers/gpu/drm/i915/display/intel_dp_aux.c >> +++ b/drivers/gpu/drm/i915/display/intel_dp_aux.c >> @@ -66,7 +66,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp) >> int ret; >>=20=20 >> if (intel_parent_irq_enabled(display)) { >> -#define C (((status =3D intel_de_read_notrace(display, ch_ctl)) & DP_AU= X_CH_CTL_SEND_BUSY) =3D=3D 0) >> +#define C (((status =3D intel_de_read(display, ch_ctl)) & DP_AUX_CH_CTL= _SEND_BUSY) =3D=3D 0) >> done =3D wait_event_timeout(display->gmbus.wait_queue, C, >> msecs_to_jiffies_timeout(timeout_ms)); >>=20=20 >> @@ -324,7 +324,7 @@ intel_dp_aux_xfer(struct intel_dp *intel_dp, >>=20=20 >> /* Try to wait for any previous AUX channel activity */ >> for (try =3D 0; try < 3; try++) { >> - status =3D intel_de_read_notrace(display, ch_ctl); >> + status =3D intel_de_read(display, ch_ctl); >> if ((status & DP_AUX_CH_CTL_SEND_BUSY) =3D=3D 0) >> break; >> msleep(1); > > Sashiko has a point that there's now an extra trace call below this. > > With that fixed, > > Reviewed-by: Jani Nikula Oh, getting rid of the direct trace_i915_reg_rw() call here let's us get rid of this too: #include "intel_uncore_trace.h" --=20 Jani Nikula, Intel