From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v3 5/5] drm/i915: Simplify intel_engine_wakeup() Date: Mon, 27 Feb 2017 10:34:12 +0000 Message-ID: <9f3ac7ca-671a-e7db-fbe4-ec49458a1d14@linux.intel.com> References: <20170224180149.8737-1-chris@chris-wilson.co.uk> <20170224180149.8737-5-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 35BF66E37F for ; Mon, 27 Feb 2017 10:34:18 +0000 (UTC) In-Reply-To: <20170224180149.8737-5-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDI0LzAyLzIwMTcgMTg6MDEsIENocmlzIFdpbHNvbiB3cm90ZToKPiBOb3cgdGhlIG9ubHkg dXNlIG9mIHRoZSByZXR1cm4gdmFsdWUgaXMgYXNrIHdoZXRoZXIgb3Igbm90IHdlIGFjdHVhbGx5 Cj4gd29rZSBhIHByb2Nlc3MgdXAuIFdpdGggYSBzaW5nbGUgY29uZGl0aW9uIHRvIHJlcG9ydCwg d2UgY2FuIGdvIGJhY2sgdG8KPiB1c2luZyBhIGJvb2xlYW4uCgpBcmdoISA6KSBJIGd1ZXNzIGl0 IGRlcGVuZHMgb24gd2hldGhlciB5b3Uga2VlcCBvciBub3QgdGhlIG9wZW4gY29kZWQgCmludGVs X2VuZ2luZV93YWtldXAncyBpbiB0aGUgcHJldmlvdXMgcGF0Y2guCgpSZWdhcmRzLAoKVHZydGtv Cgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+IENjOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBN aWthIEt1b3BwYWxhIDxtaWthLmt1b3BwYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYnJlYWRjcnVtYnMuYyB8IDEzICsrKysrLS0tLS0tLS0K PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICB8ICA0ICstLS0KPiAg MiBmaWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDExIGRlbGV0aW9ucygtKQo+Cj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1bWJzLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9icmVhZGNydW1icy5jCj4gaW5kZXggOGU4M2JlMzQzMDU3 Li44NDAzNGVlODI3YWYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YnJlYWRjcnVtYnMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2JyZWFkY3J1 bWJzLmMKPiBAQCAtMjYsMTkgKzI2LDE2IEBACj4KPiAgI2luY2x1ZGUgImk5MTVfZHJ2LmgiCj4K PiAtdW5zaWduZWQgaW50IGludGVsX2VuZ2luZV93YWtldXAoc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+ICtib29sIGludGVsX2VuZ2luZV93YWtldXAoc3RydWN0IGludGVsX2VuZ2lu ZV9jcyAqZW5naW5lKQo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfd2FpdCAqd2FpdDsKPiAgCXVuc2ln bmVkIGxvbmcgZmxhZ3M7Cj4gLQl1bnNpZ25lZCBpbnQgcmV0ID0gMDsKPiArCWJvb2wgcmV0ID0g ZmFsc2U7Cj4KPiAgCXNwaW5fbG9ja19pcnFzYXZlKCZlbmdpbmUtPmJyZWFkY3J1bWJzLmxvY2ss IGZsYWdzKTsKPiAgCXdhaXQgPSBlbmdpbmUtPmJyZWFkY3J1bWJzLmZpcnN0X3dhaXQ7Cj4gLQlp ZiAod2FpdCkgewo+IC0JCXJldCA9IEVOR0lORV9XQUtFVVBfV0FJVEVSOwo+IC0JCWlmICh3YWtl X3VwX3Byb2Nlc3Mod2FpdC0+dHNrKSkKPiAtCQkJcmV0IHw9IEVOR0lORV9XQUtFVVBfQVNMRUVQ Owo+IC0JfQo+ICsJaWYgKHdhaXQgJiYgd2FrZV91cF9wcm9jZXNzKHdhaXQtPnRzaykpCj4gKwkJ cmV0ID0gdHJ1ZTsKPiAgCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmVuZ2luZS0+YnJlYWRjcnVt YnMubG9jaywgZmxhZ3MpOwo+Cj4gIAlyZXR1cm4gcmV0Owo+IEBAIC02Nyw3ICs2NCw3IEBAIHN0 YXRpYyB2b2lkIGludGVsX2JyZWFkY3J1bWJzX2hhbmdjaGVjayh1bnNpZ25lZCBsb25nIGRhdGEp Cj4gIAkgKiB0byBwcm9jZXNzIHRoZSBwZW5kaW5nIGludGVycnVwdCAoZS5nLCBsb3cgcHJpb3Jp dHkgdGFzayBvbiBhIGxvYWRlZAo+ICAJICogc3lzdGVtKSBhbmQgd2FpdCB1bnRpbCBpdCBzbGVl cHMgYmVmb3JlIGRlY2xhcmluZyBhIG1pc3NlZCBpbnRlcnJ1cHQuCj4gIAkgKi8KPiAtCWlmICgh KGludGVsX2VuZ2luZV93YWtldXAoZW5naW5lKSAmIEVOR0lORV9XQUtFVVBfQVNMRUVQKSkgewo+ ICsJaWYgKCFpbnRlbF9lbmdpbmVfd2FrZXVwKGVuZ2luZSkpIHsKPiAgCQltb2RfdGltZXIoJmIt PmhhbmdjaGVjaywgd2FpdF90aW1lb3V0KCkpOwo+ICAJCXJldHVybjsKPiAgCX0KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4gaW5kZXggM2RkNmVlZTRhMDhiLi4wMDc2 MjgyMzFlYzMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1 ZmZlci5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oCj4g QEAgLTY0Miw5ICs2NDIsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaW50ZWxfZW5naW5lX2hhc193 YWl0ZXIoY29uc3Qgc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAJcmV0dXJuIFJF QURfT05DRShlbmdpbmUtPmJyZWFkY3J1bWJzLmZpcnN0X3dhaXQpOwo+ICB9Cj4KPiAtdW5zaWdu ZWQgaW50IGludGVsX2VuZ2luZV93YWtldXAoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5l KTsKPiAtI2RlZmluZSBFTkdJTkVfV0FLRVVQX1dBSVRFUiBCSVQoMCkKPiAtI2RlZmluZSBFTkdJ TkVfV0FLRVVQX0FTTEVFUCBCSVQoMSkKPiArYm9vbCBpbnRlbF9lbmdpbmVfd2FrZXVwKHN0cnVj dCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSk7Cj4KPiAgdm9pZCBfX2ludGVsX2VuZ2luZV9kaXNh cm1fYnJlYWRjcnVtYnMoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKTsKPiAgdm9pZCBp bnRlbF9lbmdpbmVfZGlzYXJtX2JyZWFkY3J1bWJzKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVu Z2luZSk7Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==