From: Yaodong Li <yaodong.li@intel.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Cc: Sujaritha Sundaresan <sujaritha.sundaresan@intel.com>
Subject: Re: [PATCH v4 3/5] drm/i915/guc: Implement dynamic WOPCM partitioning
Date: Wed, 13 Dec 2017 10:19:06 -0800 [thread overview]
Message-ID: <9f924325-9c34-2e1d-22f2-0a47b165cb32@intel.com> (raw)
In-Reply-To: <1513156304.5228.19.camel@linux.intel.com>
On 12/13/2017 01:11 AM, Joonas Lahtinen wrote:
> On Tue, 2017-12-12 at 14:56 -0800, Jackie Li wrote:
>> Hardware may have specific restrictions on GuC WOPCM partition
>> size versus HuC firmware size. With static WOPCM partitioning,
>> there's no way to adjust the GuC WOPCM partition size based on
>> the actual HuC firmware size, so that GuC/HuC loading failure
>> would occur even if there was enough WOPCM space for both
>> GuC and HuC firmware.
> WOPCM being a shared feature of the hardware, it should not go under
> intel_guc_ prefix.
>
> There should be a clear division of what is specific to GuC feature
> only and what is just a feature that happens to be used by GuC (and
> equally can be used by HuC too).
the intel_guc_wopcm here only refers to the wopcm used by
GuC, this structure only defines the GuC related wopcm info.
(wopcm partition for GuC). We only need to set these values
(defined in this structure) to GuC registers. And this structure
should never be touched if GuC was disabled. so it should be
a part of GuC.
Regards, Jackie
>
> Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-12-13 18:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 22:56 [PATCH v4 1/5] drm/i915/guc: Move GuC WOPCM related code into separate files Jackie Li
2017-12-12 22:56 ` [PATCH v4 2/5] drm/i915/guc: Rename guc_ggtt_offset to intel_guc_ggtt_offset Jackie Li
2017-12-12 22:56 ` [PATCH v4 3/5] drm/i915/guc: Implement dynamic WOPCM partitioning Jackie Li
2017-12-13 9:11 ` Joonas Lahtinen
2017-12-13 18:19 ` Yaodong Li [this message]
2017-12-13 21:34 ` Michal Wajdeczko
2017-12-13 22:59 ` Yaodong Li
2017-12-14 11:43 ` Joonas Lahtinen
2017-12-15 4:55 ` Yaodong Li
2017-12-15 10:21 ` Joonas Lahtinen
2017-12-15 19:16 ` Yaodong Li
2017-12-12 22:56 ` [PATCH v4 4/5] drm/i915/guc: Add WOPCM partitioning support for CNL Jackie Li
2017-12-12 22:56 ` [PATCH v4 5/5] HAX Enable GuC Submission for CI Jackie Li
2017-12-12 23:18 ` ✗ Fi.CI.BAT: failure for series starting with [v4,1/5] drm/i915/guc: Move GuC WOPCM related code into separate files Patchwork
2017-12-13 8:19 ` [PATCH v4 1/5] " Joonas Lahtinen
2017-12-13 18:29 ` Yaodong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f924325-9c34-2e1d-22f2-0a47b165cb32@intel.com \
--to=yaodong.li@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=sujaritha.sundaresan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).