From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lionel Landwerlin Subject: Re: [PATCH v6 7/7] drm/i915: add a sysfs entry to let users set sseu configs Date: Wed, 23 May 2018 18:37:35 +0100 Message-ID: <9f9be814-d3ac-e0d7-c806-bb69fdbe2f04@intel.com> References: <20180522180002.11522-1-lionel.g.landwerlin@intel.com> <20180522180002.11522-8-lionel.g.landwerlin@intel.com> <4abc7173-35df-5bd7-5da8-13bec29c5d90@linux.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1972085597==" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5BF5C89F5B for ; Wed, 23 May 2018 17:37:49 +0000 (UTC) In-Reply-To: <4abc7173-35df-5bd7-5da8-13bec29c5d90@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tvrtko Ursulin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is a multi-part message in MIME format. --===============1972085597== Content-Type: multipart/alternative; boundary="------------B12FC3D3027DCECB37FCFDC4" Content-Language: en-US This is a multi-part message in MIME format. --------------B12FC3D3027DCECB37FCFDC4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit On 23/05/18 16:30, Tvrtko Ursulin wrote: >> >> +{ >> +    struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev); >> +    int ret = i915_gem_contexts_get_allow_sseu(dev_priv); >> + >> +    return snprintf(buf, PAGE_SIZE, "%d\n", ret); > > Propagate ENODEV all the way by making > i915_gem_contexts_get_allow_sseu return an int? Actually should a cat on a sysfs entry fail with ENODEV? --------------B12FC3D3027DCECB37FCFDC4 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
On 23/05/18 16:30, Tvrtko Ursulin wrote:

+{
+    struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);
+    int ret = i915_gem_contexts_get_allow_sseu(dev_priv);
+
+    return snprintf(buf, PAGE_SIZE, "%d\n", ret);

Propagate ENODEV all the way by making i915_gem_contexts_get_allow_sseu return an int?

Actually should a cat on a sysfs entry fail with ENODEV?

--------------B12FC3D3027DCECB37FCFDC4-- --===============1972085597== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1972085597==--