From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagar Arun Kamble Subject: Re: [PATCH 01/15] drm/i915/guc: Tidy guc_log_control Date: Fri, 2 Mar 2018 16:39:38 +0530 Message-ID: <9fc17112-2b3d-8a8d-c31d-fdfc9139cfb5@intel.com> References: <20180227125230.13000-1-michal.winiarski@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CCF36EE20 for ; Fri, 2 Mar 2018 11:09:41 +0000 (UTC) In-Reply-To: <20180227125230.13000-1-michal.winiarski@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyLzI3LzIwMTggNjoyMiBQTSwgTWljaGHFgiBXaW5pYXJza2kgd3JvdGU6Cj4gV2UgcGxh biB0byBkZWNvdXBsZSBsb2cgcnVudGltZSAobWFwcGluZyArIHJlbGF5KSBmcm9tIHZlcmJvc2l0 eSBjb250cm9sLgo+IExldCdzIHRpZHkgdGhlIGNvZGUgbm93IHRvIHJlZHVjZSB0aGUgY2h1cm4g aW4gdGhlIGZvbGxvd2luZyBwYXRjaGVzLgo+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGHFgiBXaW5p YXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNo cmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogRGFuaWVsZSBDZXJhb2xvIFNwdXJpbyA8ZGFu aWVsZS5jZXJhb2xvc3B1cmlvQGludGVsLmNvbT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWlj aGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4gQ2M6IFNhZ2FyIEFydW4gS2FtYmxlIDxzYWdhci5h LmthbWJsZUBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYyAgfCAxMSArKy0tLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19s b2cuYyB8IDc1ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oIHwgIDMgKy0KPiAgIDMgZmlsZXMgY2hhbmdl ZCwgNDYgaW5zZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2RlYnVnZnMuYwo+IGluZGV4IDMzZmJmMzk2NTMwOS4uNTg5ODNjYWZhZWNlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjUwMCwxMyArMjUwMCwxMCBAQCBz dGF0aWMgaW50IGk5MTVfZ3VjX2xvZ19jb250cm9sX2dldCh2b2lkICpkYXRhLCB1NjQgKnZhbCkK U2hvdWxkIHdlIG5hbWUgdGhpcyBpOTE1X2d1Y19sb2dfbGV2ZWxfZ2V0IGluc3RlYWQ/IGFuZCBv dGhlciByZWxhdGVkIApmdW5jdGlvbnMgdG9vPwo+ICAgewo+ICAgCXN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiA9IGRhdGE7Cj4gICAKPiAtCWlmICghSEFTX0dVQyhkZXZfcHJpdikp Cj4gKwlpZiAoIVVTRVNfR1VDKGRldl9wcml2KSkKPiAgIAkJcmV0dXJuIC1FTk9ERVY7Cj4gICAK PiAtCWlmICghZGV2X3ByaXYtPmd1Yy5sb2cudm1hKQo+IC0JCXJldHVybiAtRUlOVkFMOwo+IC0K PiAtCSp2YWwgPSBpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVsOwo+ICsJKnZhbCA9IGludGVs X2d1Y19sb2dfY29udHJvbF9nZXQoJmRldl9wcml2LT5ndWMpOwo+ICAgCj4gICAJcmV0dXJuIDA7 Cj4gICB9Cj4gQEAgLTI1MTUsMTAgKzI1MTIsMTAgQEAgc3RhdGljIGludCBpOTE1X2d1Y19sb2df Y29udHJvbF9zZXQodm9pZCAqZGF0YSwgdTY0IHZhbCkKPiAgIHsKPiAgIAlzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkYXRhOwo+ICAgCj4gLQlpZiAoIUhBU19HVUMoZGV2X3By aXYpKQo+ICsJaWYgKCFVU0VTX0dVQyhkZXZfcHJpdikpCj4gICAJCXJldHVybiAtRU5PREVWOwo+ ICAgCj4gLQlyZXR1cm4gaW50ZWxfZ3VjX2xvZ19jb250cm9sKCZkZXZfcHJpdi0+Z3VjLCB2YWwp Owo+ICsJcmV0dXJuIGludGVsX2d1Y19sb2dfY29udHJvbF9zZXQoJmRldl9wcml2LT5ndWMsIHZh bCk7Cj4gICB9Cj4gICAKPiAgIERFRklORV9TSU1QTEVfQVRUUklCVVRFKGk5MTVfZ3VjX2xvZ19j b250cm9sX2ZvcHMsCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2cuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19sb2cuYwo+IGluZGV4IDdi NTA3NGUyMTIwYy4uMjJhMDUzMjA4MTdiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2d1Y19sb2cuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19sb2cuYwo+IEBAIC02NTcsNTIgKzY1Nyw1NSBAQCB2b2lkIGludGVsX2d1Y19sb2dfZGVzdHJv eShzdHJ1Y3QgaW50ZWxfZ3VjICpndWMpCj4gICAJaTkxNV92bWFfdW5waW5fYW5kX3JlbGVhc2Uo Jmd1Yy0+bG9nLnZtYSk7Cj4gICB9Cj4gICAKPiAtaW50IGludGVsX2d1Y19sb2dfY29udHJvbChz dHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHU2NCBjb250cm9sX3ZhbCkKPiAraW50IGludGVsX2d1Y19s b2dfY29udHJvbF9nZXQoc3RydWN0IGludGVsX2d1YyAqZ3VjKQpTaG91bGQgd2UgYmUgcGFzc2lu ZyBndWNfbG9nIGFzIHBhcmFtZXRlciBhbmQgaW1wbGVtZW50IGd1Y19sb2dfdG9fZ3VjKCkgCmZ1 bmN0aW9uLgo+ICt7Cj4gKwlHRU1fQlVHX09OKCFndWMtPmxvZy52bWEpOwo+ICsJR0VNX0JVR19P TihpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVsIDwgMCk7Cj4gKwo+ICsJcmV0dXJuIGk5MTVf bW9kcGFyYW1zLmd1Y19sb2dfbGV2ZWw7Cj4gK30KPiArCj4gKyNkZWZpbmUgR1VDX0xPR19JU19F TkFCTEVEKHgpCQkoeCA+IDApCj4gKyNkZWZpbmUgR1VDX0xPR19MRVZFTF9UT19WRVJCT1NJVFko eCkJKEdVQ19MT0dfSVNfRU5BQkxFRCh4KSA/IHggLSAxIDogMCkKVGhpcyBpcyBiaXQgbWlzbGVh ZGluZywgY2FuIHdlIG1ha2UgdGhpcyBtYWNybyByZXR1cm4gLTEgaWYgbG9nZ2luZyBpcyAKdG8g YmUgZGlzYWJsZWQuIFRoYXQgd2F5IGd1Y19sb2dfY29udHJvbCBjYW4gYmUgaW52b2tlZCB3aXRo CnNpbmdsZSBzaWduZWQgMzJiaXQgcGFyYW1ldGVyLgo+ICtpbnQgaW50ZWxfZ3VjX2xvZ19jb250 cm9sX3NldChzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIHU2NCB2YWwpCj4gICB7Cj4gICAJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZ3VjX3RvX2k5MTUoZ3VjKTsKPiAtCWJvb2wg ZW5hYmxlX2xvZ2dpbmcgPSBjb250cm9sX3ZhbCA+IDA7Cj4gLQl1MzIgdmVyYm9zaXR5Owo+ICAg CWludCByZXQ7Cj4gICAKPiAtCWlmICghZ3VjLT5sb2cudm1hKQo+IC0JCXJldHVybiAtRU5PREVW Owo+ICsJQlVJTERfQlVHX09OKEdVQ19MT0dfVkVSQk9TSVRZX01JTiAhPSAwKTsKPiArCUdFTV9C VUdfT04oIWd1Yy0+bG9nLnZtYSk7Cj4gKwlHRU1fQlVHX09OKGk5MTVfbW9kcGFyYW1zLmd1Y19s b2dfbGV2ZWwgPCAwKTsKPiAgIAo+IC0JQlVJTERfQlVHX09OKEdVQ19MT0dfVkVSQk9TSVRZX01J Tik7Cj4gLQlpZiAoY29udHJvbF92YWwgPiAxICsgR1VDX0xPR19WRVJCT1NJVFlfTUFYKQo+ICsJ LyoKPiArCSAqIEd1QyBpcyByZWNvZ25pemluZyBsb2cgbGV2ZWxzIHN0YXJ0aW5nIGZyb20gMCB0 byBtYXgsIHdlJ3JlIHVzaW5nIDAKPiArCSAqIGFzIGluZGljYXRpb24gdGhhdCBsb2dnaW5nIHNo b3VsZCBiZSBkaXNhYmxkZWQuCj4gKwkgKi8KPiArCWlmIChHVUNfTE9HX0xFVkVMX1RPX1ZFUkJP U0lUWSh2YWwpIDwgR1VDX0xPR19WRVJCT1NJVFlfTUlOIHx8ClRoaXMgY2hlY2sgc2VlbXMgdW5u ZWNlc3NhcnkgYXMgd2UgY3VycmVudGx5IGRvbid0IGhhdmUgbmVnYXRpdmUgb3V0cHV0IApmb3Ig R19MX0xfVF9WIG1hY3JvLgpJZiB3ZSBhZGQgbmVnYXRpdmUgdmFsdWUgdGhlcmUsIHdpbGwgbmVl ZCB0byByZW1vdmUgdGhpcyBjaGVjay4KPiArCSAgICBHVUNfTE9HX0xFVkVMX1RPX1ZFUkJPU0lU WSh2YWwpID4gR1VDX0xPR19WRVJCT1NJVFlfTUFYKQo+ICAgCQlyZXR1cm4gLUVJTlZBTDsKPiAg IAo+IC0JLyogVGhpcyBjb21iaW5hdGlvbiBkb2Vzbid0IG1ha2Ugc2Vuc2UgJiB3b24ndCBoYXZl IGFueSBlZmZlY3QgKi8KPiAtCWlmICghZW5hYmxlX2xvZ2dpbmcgJiYgIWk5MTVfbW9kcGFyYW1z Lmd1Y19sb2dfbGV2ZWwpCj4gLQkJcmV0dXJuIDA7Cj4gKwltdXRleF9sb2NrKCZkZXZfcHJpdi0+ ZHJtLnN0cnVjdF9tdXRleCk7Cj4gICAKPiAtCXZlcmJvc2l0eSA9IGVuYWJsZV9sb2dnaW5nID8g Y29udHJvbF92YWwgLSAxIDogMDsKPiArCWlmIChpOTE1X21vZHBhcmFtcy5ndWNfbG9nX2xldmVs ID09IHZhbCkgewo+ICsJCXJldCA9IDA7Cj4gKwkJZ290byBvdXRfdW5sb2NrOwo+ICsJfQo+ICAg Cj4gLQlyZXQgPSBtdXRleF9sb2NrX2ludGVycnVwdGlibGUoJmRldl9wcml2LT5kcm0uc3RydWN0 X211dGV4KTsKPiAtCWlmIChyZXQpCj4gLQkJcmV0dXJuIHJldDsKPiAgIAlpbnRlbF9ydW50aW1l X3BtX2dldChkZXZfcHJpdik7Cj4gLQlyZXQgPSBndWNfbG9nX2NvbnRyb2woZ3VjLCBlbmFibGVf bG9nZ2luZywgdmVyYm9zaXR5KTsKPiArCXJldCA9IGd1Y19sb2dfY29udHJvbChndWMsIEdVQ19M T0dfSVNfRU5BQkxFRCh2YWwpLAo+ICsJCQkgICAgICBHVUNfTE9HX0xFVkVMX1RPX1ZFUkJPU0lU WSh2YWwpKTsKPiAgIAlpbnRlbF9ydW50aW1lX3BtX3B1dChkZXZfcHJpdik7Cj4gLQltdXRleF91 bmxvY2soJmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiArCWlmIChyZXQpCj4gKwkJZ290 byBvdXRfdW5sb2NrOwo+ICAgCj4gLQlpZiAocmV0IDwgMCkgewo+IC0JCURSTV9ERUJVR19EUklW RVIoImd1Y19sb2dnaW5nX2NvbnRyb2wgYWN0aW9uIGZhaWxlZCAlZFxuIiwgcmV0KTsKPiAtCQly ZXR1cm4gcmV0Owo+IC0JfQo+ICsJaTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA9IHZhbDsK PiAgIAo+IC0JaWYgKGVuYWJsZV9sb2dnaW5nKSB7Cj4gLQkJaTkxNV9tb2RwYXJhbXMuZ3VjX2xv Z19sZXZlbCA9IDEgKyB2ZXJib3NpdHk7Cj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0u c3RydWN0X211dGV4KTsKPiAgIAo+IC0JCS8qCj4gLQkJICogSWYgbG9nIHdhcyBkaXNhYmxlZCBh dCBib290IHRpbWUsIHRoZW4gdGhlIHJlbGF5IGNoYW5uZWwgZmlsZQo+IC0JCSAqIHdvdWxkbid0 IGhhdmUgYmVlbiBjcmVhdGVkIGJ5IG5vdyBhbmQgaW50ZXJydXB0cyBhbHNvIHdvdWxkCj4gLQkJ ICogbm90IGhhdmUgYmVlbiBlbmFibGVkLiBUcnkgYWdhaW4gbm93LCBqdXN0IGluIGNhc2UuCj4g LQkJICovCj4gKwlpZiAoR1VDX0xPR19JU19FTkFCTEVEKHZhbCkgJiYgIWd1Y19sb2dfaGFzX3J1 bnRpbWUoZ3VjKSkgewo+ICAgCQlyZXQgPSBndWNfbG9nX2xhdGVfc2V0dXAoZ3VjKTsKPiAtCQlp ZiAocmV0IDwgMCkgewo+IC0JCQlEUk1fREVCVUdfRFJJVkVSKCJHdUMgbG9nIGxhdGUgc2V0dXAg ZmFpbGVkICVkXG4iLCByZXQpOwo+IC0JCQlyZXR1cm4gcmV0Owo+IC0JCX0KPiArCQlpZiAocmV0 KQo+ICsJCQlnb3RvIG91dDsKPiAgIAo+ICAgCQkvKiBHdUMgbG9nZ2luZyBpcyBjdXJyZW50bHkg dGhlIG9ubHkgdXNlciBvZiBHdWMySG9zdCBpbnRlcnJ1cHRzICovCj4gICAJCW11dGV4X2xvY2so JmRldl9wcml2LT5kcm0uc3RydWN0X211dGV4KTsKPiBAQCAtNzEwLDcgKzcxMyw3IEBAIGludCBp bnRlbF9ndWNfbG9nX2NvbnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1NjQgY29udHJvbF92 YWwpCj4gICAJCWdlbjlfZW5hYmxlX2d1Y19pbnRlcnJ1cHRzKGRldl9wcml2KTsKPiAgIAkJaW50 ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+ICAgCQltdXRleF91bmxvY2soJmRldl9wcml2 LT5kcm0uc3RydWN0X211dGV4KTsKPiAtCX0gZWxzZSB7Cj4gKwl9IGVsc2UgaWYgKCFHVUNfTE9H X0lTX0VOQUJMRUQodmFsKSAmJiBndWNfbG9nX2hhc19ydW50aW1lKGd1YykpIHsKPiAgIAkJLyoK PiAgIAkJICogT25jZSBsb2dnaW5nIGlzIGRpc2FibGVkLCBHdUMgd29uJ3QgZ2VuZXJhdGUgbG9n cyAmIHNlbmQgYW4KPiAgIAkJICogaW50ZXJydXB0LiBCdXQgdGhlcmUgY291bGQgYmUgc29tZSBk YXRhIGluIHRoZSBsb2cgYnVmZmVyCj4gQEAgLTcxOCwxMSArNzIxLDEzIEBAIGludCBpbnRlbF9n dWNfbG9nX2NvbnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1NjQgY29udHJvbF92YWwpCj4g ICAJCSAqIGJ1ZmZlciBzdGF0ZSBhbmQgdGhlbiBjb2xsZWN0IHRoZSBsZWZ0IG92ZXIgbG9ncy4K PiAgIAkJICovCj4gICAJCWd1Y19mbHVzaF9sb2dzKGd1Yyk7Cj4gLQo+IC0JCS8qIEFzIGxvZ2dp bmcgaXMgZGlzYWJsZWQsIHVwZGF0ZSBsb2cgbGV2ZWwgdG8gcmVmbGVjdCB0aGF0ICovCj4gLQkJ aTkxNV9tb2RwYXJhbXMuZ3VjX2xvZ19sZXZlbCA9IDA7Cj4gICAJfQo+ICAgCj4gKwlyZXR1cm4g MDsKPiArCj4gK291dF91bmxvY2s6Cj4gKwltdXRleF91bmxvY2soJmRldl9wcml2LT5kcm0uc3Ry dWN0X211dGV4KTsKPiArb3V0Ogo+ICAgCXJldHVybiByZXQ7Cj4gICB9Cj4gICAKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oCj4gaW5kZXggZGFiMGU5NDk1NjdhLi4xNDFjZTljYTIy Y2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX2xvZy5oCj4gQEAgLTY0LDcgKzY0 LDggQEAgdm9pZCBpbnRlbF9ndWNfbG9nX2Rlc3Ryb3koc3RydWN0IGludGVsX2d1YyAqZ3VjKTsK PiAgIHZvaWQgaW50ZWxfZ3VjX2xvZ19pbml0X2Vhcmx5KHN0cnVjdCBpbnRlbF9ndWMgKmd1Yyk7 Cj4gICBpbnQgaW50ZWxfZ3VjX2xvZ19yZWxheV9jcmVhdGUoc3RydWN0IGludGVsX2d1YyAqZ3Vj KTsKPiAgIHZvaWQgaW50ZWxfZ3VjX2xvZ19yZWxheV9kZXN0cm95KHN0cnVjdCBpbnRlbF9ndWMg Kmd1Yyk7Cj4gLWludCBpbnRlbF9ndWNfbG9nX2NvbnRyb2woc3RydWN0IGludGVsX2d1YyAqZ3Vj LCB1NjQgY29udHJvbF92YWwpOwo+ICtpbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9sX2dldChzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMpOwo+ICtpbnQgaW50ZWxfZ3VjX2xvZ19jb250cm9sX3NldChzdHJ1 Y3QgaW50ZWxfZ3VjICpndWMsIHU2NCBjb250cm9sX3ZhbCk7Cj4gICB2b2lkIGk5MTVfZ3VjX2xv Z19yZWdpc3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpOwo+ICAgdm9pZCBp OTE1X2d1Y19sb2dfdW5yZWdpc3RlcihzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Owo+ICAgCgotLSAKVGhhbmtzLApTYWdhcgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==