From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, HTML_MESSAGE,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80388C10DCE for ; Fri, 13 Mar 2020 08:49:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D5A0206FA for ; Fri, 13 Mar 2020 08:49:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D5A0206FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 196936EB95; Fri, 13 Mar 2020 08:49:35 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56E316EB95 for ; Fri, 13 Mar 2020 08:49:33 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 01:49:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,548,1574150400"; d="scan'208,217";a="243314115" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga003.jf.intel.com with ESMTP; 13 Mar 2020 01:49:31 -0700 Received: from irsmsx604.ger.corp.intel.com (163.33.146.137) by IRSMSX151.ger.corp.intel.com (163.33.192.59) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 08:49:30 +0000 Received: from irsmsx604.ger.corp.intel.com (163.33.146.137) by IRSMSX604.ger.corp.intel.com (163.33.146.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 13 Mar 2020 08:49:30 +0000 Received: from irsmsx604.ger.corp.intel.com ([163.33.146.137]) by IRSMSX604.ger.corp.intel.com ([163.33.146.137]) with mapi id 15.01.1713.004; Fri, 13 Mar 2020 08:49:30 +0000 From: "Lisovskiy, Stanislav" To: =?iso-8859-1?Q?Ville_Syrj=E4l=E4?= Thread-Topic: [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers Thread-Index: AQHV9i4Tk0u3HzOHN0aWu4NbMnQsiahDklwAgAKozoY= Date: Fri, 13 Mar 2020 08:49:30 +0000 Message-ID: <9ffa74c26bc349aab1bd2fe8f427f451@intel.com> References: <20200309161204.17792-1-stanislav.lisovskiy@intel.com> <20200309161204.17792-4-stanislav.lisovskiy@intel.com>, <20200311160854.GB13686@intel.com> In-Reply-To: <20200311160854.GB13686@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.184.70.1] MIME-Version: 1.0 Subject: Re: [Intel-gfx] [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" Content-Type: multipart/mixed; boundary="===============1074642418==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1074642418== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_9ffa74c26bc349aab1bd2fe8f427f451intelcom_" --_000_9ffa74c26bc349aab1bd2fe8f427f451intelcom_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable >> Add correspondent helpers to be able to get old/new bandwidth >> global state object. >> >> v2: - Fixed typo in function call >> v3: - Changed new functions naming to use convention proposed >> by Jani Nikula, i.e intel_bw_* in intel_bw.c file. >Still nak on the rename. Cool. Discuss it with Jani Nikula then, to have at least some common strate= gy on how to be picky on me. Best Regards, Lisovskiy Stanislav ________________________________ From: Ville Syrj=E4l=E4 Sent: Wednesday, March 11, 2020 6:08:54 PM To: Lisovskiy, Stanislav Cc: intel-gfx@lists.freedesktop.org; Ausmus, James; Saarinen, Jani; Roper, = Matthew D Subject: Re: [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state helpers On Mon, Mar 09, 2020 at 06:11:59PM +0200, Stanislav Lisovskiy wrote: > Add correspondent helpers to be able to get old/new bandwidth > global state object. > > v2: - Fixed typo in function call > v3: - Changed new functions naming to use convention proposed > by Jani Nikula, i.e intel_bw_* in intel_bw.c file. Still nak on the rename. > > Signed-off-by: Stanislav Lisovskiy > --- > drivers/gpu/drm/i915/display/intel_bw.c | 33 ++++++++++++++++++++++--- > drivers/gpu/drm/i915/display/intel_bw.h | 9 +++++++ > 2 files changed, 39 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i9= 15/display/intel_bw.c > index 58b264bc318d..bdad7476dc7b 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.c > +++ b/drivers/gpu/drm/i915/display/intel_bw.c > @@ -374,8 +374,35 @@ static unsigned int intel_bw_data_rate(struct drm_i9= 15_private *dev_priv, > return data_rate; > } > > -static struct intel_bw_state * > -intel_atomic_get_bw_state(struct intel_atomic_state *state) > +struct intel_bw_state * > +intel_bw_get_old_state(struct intel_atomic_state *state) > +{ > + struct drm_i915_private *dev_priv =3D to_i915(state->base.dev); > + struct intel_global_state *bw_state; > + > + bw_state =3D intel_atomic_get_old_global_obj_state(state, &dev_priv= ->bw_obj); > + if (IS_ERR(bw_state)) > + return ERR_CAST(bw_state); > + > + return to_intel_bw_state(bw_state); > +} > + > +struct intel_bw_state * > +intel_bw_get_new_state(struct intel_atomic_state *state) > +{ > + struct drm_i915_private *dev_priv =3D to_i915(state->base.dev); > + struct intel_global_state *bw_state; > + > + bw_state =3D intel_atomic_get_new_global_obj_state(state, &dev_priv= ->bw_obj); > + > + if (IS_ERR(bw_state)) > + return ERR_CAST(bw_state); > + > + return to_intel_bw_state(bw_state); > +} > + > +struct intel_bw_state * > +intel_bw_get_state(struct intel_atomic_state *state) > { > struct drm_i915_private *dev_priv =3D to_i915(state->base.dev); > struct intel_global_state *bw_state; > @@ -420,7 +447,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *= state) > old_active_planes =3D=3D new_active_planes) > continue; > > - bw_state =3D intel_atomic_get_bw_state(state); > + bw_state =3D intel_bw_get_state(state); > if (IS_ERR(bw_state)) > return PTR_ERR(bw_state); > > diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm/i9= 15/display/intel_bw.h > index a8aa7624c5aa..b5f61463922f 100644 > --- a/drivers/gpu/drm/i915/display/intel_bw.h > +++ b/drivers/gpu/drm/i915/display/intel_bw.h > @@ -24,6 +24,15 @@ struct intel_bw_state { > > #define to_intel_bw_state(x) container_of((x), struct intel_bw_state, ba= se) > > +struct intel_bw_state * > +intel_bw_get_old_state(struct intel_atomic_state *state); > + > +struct intel_bw_state * > +intel_bw_get_new_state(struct intel_atomic_state *state); > + > +struct intel_bw_state * > +intel_bw_get_state(struct intel_atomic_state *state); > + > void intel_bw_init_hw(struct drm_i915_private *dev_priv); > int intel_bw_init(struct drm_i915_private *dev_priv); > int intel_bw_atomic_check(struct intel_atomic_state *state); > -- > 2.24.1.485.gad05a3d8e5 -- Ville Syrj=E4l=E4 Intel --_000_9ffa74c26bc349aab1bd2fe8f427f451intelcom_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable 

>> Add correspondent helpers to be able to get old/new bandw=
idth=0A=
>> global=
 state object.=0A=
>> =0A=
>> v2: - =
Fixed typo in function call=0A=
>> v3: - =
Changed new functions naming to use convention proposed=0A=
>>       =
by Jani Nikula, i.e intel_bw_* in intel_bw.c file.=0A=
=0A=
>Still nak on the rename.
Cool. Discuss it w=
ith Jani Nikula then, to have at least some common strategy on how to be pi=
cky on me.






Best Regards,



Lisovskiy Stanislav 










From: Ville Syrj=E4l=E4 &=
lt;ville.syrjala@linux.intel.com>

Sent: Wednesday, March 11, 2020 6:08:54 PM

To: Lisovskiy, Stanislav

Cc: intel-gfx@lists.freedesktop.org; Ausmus, James; Saarinen, Jani; =
Roper, Matthew D

Subject: Re: [PATCH v19 3/8] drm/i915: Add intel_bw_get_*_state help=
ers

 







On Mon, Mar 09, 2020 at 06:11:59PM +0200, Stan=
islav Lisovskiy wrote:

> Add correspondent helpers to be able to get old/new bandwidth

> global state object.

> 

> v2: - Fixed typo in function call

> v3: - Changed new functions naming to use convention proposed

>       by Jani Nikula, i.e intel_bw_* in =
intel_bw.c file.



Still nak on the rename.



> 

> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com&g=
t;

> ---

>  drivers/gpu/drm/i915/display/intel_bw.c | 33 ++++=
;+++++++++++++++=
;+++---

>  drivers/gpu/drm/i915/display/intel_bw.h |  9 +++=
;++++

>  2 files changed, 39 insertions(+), 3 deletions(-)

> 

> diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm=
/i915/display/intel_bw.c

> index 58b264bc318d..bdad7476dc7b 100644

> --- a/drivers/gpu/drm/i915/display/intel_bw.c

> +++ b/drivers/gpu/drm/i915/display/intel_bw.c

> @@ -374,8 +374,35 @@ static unsigned int intel_bw_data_rate(struct=
 drm_i915_private *dev_priv,

>        return data_rate;

>  }

>  

> -static struct intel_bw_state *

> -intel_atomic_get_bw_state(struct intel_atomic_state *state)

> +struct intel_bw_state *

> +intel_bw_get_old_state(struct intel_atomic_state *state)

> +{

> +     struct drm_i915_private *dev_priv =3D to=
_i915(state->base.dev);

> +     struct intel_global_state *bw_state;

> +

> +     bw_state =3D intel_atomic_get_old_global=
_obj_state(state, &dev_priv->bw_obj);

> +     if (IS_ERR(bw_state))

> +           =
;  return ERR_CAST(bw_state);

> +

> +     return to_intel_bw_state(bw_state);

> +}

> +

> +struct intel_bw_state *

> +intel_bw_get_new_state(struct intel_atomic_state *state)

> +{

> +     struct drm_i915_private *dev_priv =3D to=
_i915(state->base.dev);

> +     struct intel_global_state *bw_state;

> +

> +     bw_state =3D intel_atomic_get_new_global=
_obj_state(state, &dev_priv->bw_obj);

> +

> +     if (IS_ERR(bw_state))

> +           =
;  return ERR_CAST(bw_state);

> +

> +     return to_intel_bw_state(bw_state);

> +}

> +

> +struct intel_bw_state *

> +intel_bw_get_state(struct intel_atomic_state *state)

>  {

>        struct drm_i915_private *dev=
_priv =3D to_i915(state->base.dev);

>        struct intel_global_state *b=
w_state;

> @@ -420,7 +447,7 @@ int intel_bw_atomic_check(struct intel_atomic_=
state *state)

>            =
;        old_active_planes =3D=3D new_ac=
tive_planes)

>            =
;            continu=
e;

>  

> -           &nb=
sp; bw_state  =3D intel_atomic_get_bw_state(state);

> +           =
;  bw_state  =3D intel_bw_get_state(state);

>            =
;    if (IS_ERR(bw_state))

>            =
;            return =
PTR_ERR(bw_state);

>  

> diff --git a/drivers/gpu/drm/i915/display/intel_bw.h b/drivers/gpu/drm=
/i915/display/intel_bw.h

> index a8aa7624c5aa..b5f61463922f 100644

> --- a/drivers/gpu/drm/i915/display/intel_bw.h

> +++ b/drivers/gpu/drm/i915/display/intel_bw.h

> @@ -24,6 +24,15 @@ struct intel_bw_state {

>  

>  #define to_intel_bw_state(x) container_of((x), struct intel_bw_s=
tate, base)

>  

> +struct intel_bw_state *

> +intel_bw_get_old_state(struct intel_atomic_state *state);

> +

> +struct intel_bw_state *

> +intel_bw_get_new_state(struct intel_atomic_state *state);

> +

> +struct intel_bw_state *

> +intel_bw_get_state(struct intel_atomic_state *state);

> +

>  void intel_bw_init_hw(struct drm_i915_private *dev_priv);

>  int intel_bw_init(struct drm_i915_private *dev_priv);

>  int intel_bw_atomic_check(struct intel_atomic_state *state);

> -- 

> 2.24.1.485.gad05a3d8e5



-- 

Ville Syrj=E4l=E4

Intel







--_000_9ffa74c26bc349aab1bd2fe8f427f451intelcom_--

--===============1074642418==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

--===============1074642418==--