From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Dave Airlie <airlied@gmail.com>
Cc: "intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
David Miller <davem@davemloft.net>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PULL] topic/e1000e-fix
Date: Wed, 31 May 2017 07:54:06 +0200 [thread overview]
Message-ID: <CAKMK7uF-b1U7qipgEoYnAjDtrNdvKYT4KkoV2=krikkdGERkCw@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9twH-CXm+xj2Os87Ra7nOBQ+WNXYGF83wFqpQ3s=MNx_mQ@mail.gmail.com>
On Wed, May 31, 2017 at 1:06 AM, Dave Airlie <airlied@gmail.com> wrote:
> On 31 May 2017 at 08:10, David Miller <davem@davemloft.net> wrote:
>> From: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Date: Tue, 30 May 2017 22:15:42 +0200
>>
>>> If the e1000e maintainer wants to coalesce or not return statements
>>> this simple way, that's imo on him to change the color as needed.
>>
>> That's not how things work.
>>
>> If the maintainer wants you to style things a certain way, either you
>> do it that way or your patch isn't accepted.
Consider this pull a regression report, pls handle it.
> I'm not really sure why Chris just couldn't respin already.
>
> Though really I think Chris should have just asked for a revert of the
> original patch that broke stuff, instead of trying to patch a driver
> if he doesn't have time to get the patch right for the maintainer.
Ok, can we pls revert 2800209994f8 ("e1000e: Refactor PM flows") then?
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-31 5:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 20:15 [PULL] topic/e1000e-fix Daniel Vetter
2017-05-30 22:10 ` David Miller
2017-05-30 23:06 ` Dave Airlie
2017-05-31 5:54 ` Daniel Vetter [this message]
2017-05-31 6:10 ` Daniel Vetter
2017-05-31 15:08 ` David Miller
2017-05-31 15:50 ` Jani Nikula
2017-05-31 15:50 ` [PATCH v2 1/1] e1000e: Undo e1000e_pm_freeze if __e1000_shutdown fails Jani Nikula
2017-06-02 18:14 ` David Miller
2017-06-06 20:46 ` Jeff Kirsher
2017-06-07 1:07 ` [Intel-wired-lan] " Brown, Aaron F
2017-06-20 8:49 ` Daniel Vetter
2017-06-27 19:28 ` Dave Airlie
2017-06-27 20:51 ` Jeff Kirsher
2017-06-28 5:35 ` Daniel Vetter
2017-06-05 5:20 ` Neftin, Sasha
2017-05-31 16:23 ` [PULL] topic/e1000e-fix Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uF-b1U7qipgEoYnAjDtrNdvKYT4KkoV2=krikkdGERkCw@mail.gmail.com' \
--to=daniel.vetter@ffwll.ch \
--cc=airlied@gmail.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).