From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH v5 4/8] drm/cma-helper: Use the generic
 fbdev emulation
Date: Mon, 20 Aug 2018 23:44:56 -0700
Message-ID: <CALAqxLVQHDtxzWvuDVCFvAWaaBja582aJaEgn13Qt22_uKUf=A@mail.gmail.com>
References: <20180703160354.59955-1-noralf@tronnes.org>
 <20180703160354.59955-5-noralf@tronnes.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com
 [IPv6:2a00:1450:4864:20::444])
 by gabe.freedesktop.org (Postfix) with ESMTPS id C0D3B89C1C
 for <intel-gfx@lists.freedesktop.org>; Tue, 21 Aug 2018 06:44:58 +0000 (UTC)
Received: by mail-wr1-x444.google.com with SMTP id n2-v6so4382718wrw.7
 for <intel-gfx@lists.freedesktop.org>; Mon, 20 Aug 2018 23:44:58 -0700 (PDT)
In-Reply-To: <20180703160354.59955-5-noralf@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= <noralf@tronnes.org>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, dri-devel <dri-devel@lists.freedesktop.org>, David Lechner <david@lechnology.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gVHVlLCBKdWwgMywgMjAxOCBhdCA5OjAzIEFNLCBOb3JhbGYgVHLDuG5uZXMgPG5vcmFsZkB0
cm9ubmVzLm9yZz4gd3JvdGU6Cj4gVGhpcyBzd2l0Y2hlcyB0aGUgQ01BIGhlbHBlciBkcml2ZXJz
IHRoYXQgdXNlIGl0cyBmYmRldiBlbXVsYXRpb24gb3Zlcgo+IHRvIHRoZSBnZW5lcmljIGZiZGV2
IGVtdWxhdGlvbi4gSXQncyB0aGUgZmlyc3QgcGhhc2Ugb2YgdXNpbmcgZ2VuZXJpYwo+IGZiZGV2
LiBBIGxhdGVyIHBoYXNlIHdpbGwgdXNlIERSTSBjbGllbnQgY2FsbGJhY2tzIGZvciB0aGUKPiBs
YXN0Y2xvc2UvaG90cGx1Zy9yZW1vdmUgY2FsbGJhY2tzLgo+Cj4gVGhlcmUgYXJlIGN1cnJlbnRs
eSAyIGZiZGV2IGluaXQvZmluaSBmdW5jdGlvbnM6Cj4gLSBkcm1fZmJfY21hX2ZiZGV2X2luaXQv
ZHJtX2ZiX2NtYV9mYmRldl9maW5pCj4gLSBkcm1fZmJkZXZfY21hX2luaXQvZHJtX2ZiZGV2X2Nt
YV9maW5pCj4KPiBUaGlzIGlzIGJlY2F1c2UgdGhlIHdvcmsgb24gZ2VuZXJpYyBmYmRldiBjYW1l
IHVwIGR1cmluZyBhIGZiZGV2Cj4gcmVmYWN0b3JpbmcgYW5kIHRodXMgd2Fzbid0IGNvbXBsZXRl
ZC4gTm8gcG9pbnQgaW4gY29tcGxldGluZyB0aGF0Cj4gcmVmYWN0b3Jpbmcgd2hlbiBkcml2ZXJz
IHdpbGwgc29vbiBtb3ZlIHRvIGRybV9mYl9oZWxwZXJfZ2VuZXJpY19wcm9iZSgpLgo+Cj4gdGlu
eWRybSB1c2VzIGRybV9mYl9jbWFfZmJkZXZfaW5pdF93aXRoX2Z1bmNzKCkuCj4KPiBDYzogTGF1
cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgo+IFNpZ25l
ZC1vZmYtYnk6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+IEFja2VkLWJ5
OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IC0tLQo+ICBkcml2ZXJz
L2dwdS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuYyB8IDM2MCArKysrKy0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX2ZiX2NtYV9oZWxwZXIuaCAgICAgfCAg
IDMgLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDMyMSBkZWxldGlvbnMo
LSkKLi4uCj4gLXN0YXRpYyBpbnQgZHJtX2ZiZGV2X2NtYV9kZWZpb19pbml0KHN0cnVjdCBmYl9p
bmZvICpmYmksCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRy
bV9nZW1fY21hX29iamVjdCAqY21hX29iaikKPiAtewo+IC0gICAgICAgc3RydWN0IGZiX2RlZmVy
cmVkX2lvICpmYmRlZmlvOwo+IC0gICAgICAgc3RydWN0IGZiX29wcyAqZmJvcHM7Cj4gLQo+IC0g
ICAgICAgLyoKPiAtICAgICAgICAqIFBlciBkZXZpY2Ugc3RydWN0dXJlcyBhcmUgbmVlZGVkIGJl
Y2F1c2U6Cj4gLSAgICAgICAgKiBmYm9wczogZmJfZGVmZXJyZWRfaW9fY2xlYW51cCgpIGNsZWFy
cyBmYm9wcy5mYl9tbWFwCj4gLSAgICAgICAgKiBmYmRlZmlvOiBpbmRpdmlkdWFsIGRlbGF5cwo+
IC0gICAgICAgICovCj4gLSAgICAgICBmYmRlZmlvID0ga3phbGxvYyhzaXplb2YoKmZiZGVmaW8p
LCBHRlBfS0VSTkVMKTsKPiAtICAgICAgIGZib3BzID0ga3phbGxvYyhzaXplb2YoKmZib3BzKSwg
R0ZQX0tFUk5FTCk7Cj4gLSAgICAgICBpZiAoIWZiZGVmaW8gfHwgIWZib3BzKSB7Cj4gLSAgICAg
ICAgICAgICAgIGtmcmVlKGZiZGVmaW8pOwo+IC0gICAgICAgICAgICAgICBrZnJlZShmYm9wcyk7
Cj4gLSAgICAgICAgICAgICAgIHJldHVybiAtRU5PTUVNOwo+IC0gICAgICAgfQo+IC0KPiAtICAg
ICAgIC8qIGNhbid0IGJlIG9mZnNldCBmcm9tIHZhZGRyIHNpbmNlIGRpcnR5KCkgdXNlcyBjbWFf
b2JqICovCj4gLSAgICAgICBmYmktPnNjcmVlbl9idWZmZXIgPSBjbWFfb2JqLT52YWRkcjsKPiAt
ICAgICAgIC8qIGZiX2RlZmVycmVkX2lvX2ZhdWx0KCkgbmVlZHMgYSBwaHlzaWNhbCBhZGRyZXNz
ICovCj4gLSAgICAgICBmYmktPmZpeC5zbWVtX3N0YXJ0ID0gcGFnZV90b19waHlzKHZpcnRfdG9f
cGFnZShmYmktPnNjcmVlbl9idWZmZXIpKTsKPiAtCj4gLSAgICAgICAqZmJvcHMgPSAqZmJpLT5m
Ym9wczsKPiAtICAgICAgIGZiaS0+ZmJvcHMgPSBmYm9wczsKPiAtCj4gLSAgICAgICBmYmRlZmlv
LT5kZWxheSA9IG1zZWNzX3RvX2ppZmZpZXMoREVGQVVMVF9GQkRFRklPX0RFTEFZX01TKTsKPiAt
ICAgICAgIGZiZGVmaW8tPmRlZmVycmVkX2lvID0gZHJtX2ZiX2hlbHBlcl9kZWZlcnJlZF9pbzsK
PiAtICAgICAgIGZiaS0+ZmJkZWZpbyA9IGZiZGVmaW87Cj4gLSAgICAgICBmYl9kZWZlcnJlZF9p
b19pbml0KGZiaSk7Cj4gLSAgICAgICBmYmktPmZib3BzLT5mYl9tbWFwID0gZHJtX2ZiZGV2X2Nt
YV9kZWZlcnJlZF9pb19tbWFwOwo+IC0KPiAtICAgICAgIHJldHVybiAwOwo+IC19Cj4gLQo+IC1z
dGF0aWMgdm9pZCBkcm1fZmJkZXZfY21hX2RlZmlvX2Zpbmkoc3RydWN0IGZiX2luZm8gKmZiaSkK
PiAtewo+IC0gICAgICAgaWYgKCFmYmktPmZiZGVmaW8pCj4gLSAgICAgICAgICAgICAgIHJldHVy
bjsKPiAtCj4gLSAgICAgICBmYl9kZWZlcnJlZF9pb19jbGVhbnVwKGZiaSk7Cj4gLSAgICAgICBr
ZnJlZShmYmktPmZiZGVmaW8pOwo+IC0gICAgICAga2ZyZWUoZmJpLT5mYm9wcyk7Cj4gLX0KPiAt
Cj4gLXN0YXRpYyBpbnQKPiAtZHJtX2ZiZGV2X2NtYV9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxw
ZXIgKmhlbHBlciwKPiAtICAgICAgIHN0cnVjdCBkcm1fZmJfaGVscGVyX3N1cmZhY2Vfc2l6ZSAq
c2l6ZXMpCj4gLXsKPiAtICAgICAgIHN0cnVjdCBkcm1fZmJkZXZfY21hICpmYmRldl9jbWEgPSB0
b19mYmRldl9jbWEoaGVscGVyKTsKPiAtICAgICAgIHN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBo
ZWxwZXItPmRldjsKPiAtICAgICAgIHN0cnVjdCBkcm1fZ2VtX2NtYV9vYmplY3QgKm9iajsKPiAt
ICAgICAgIHN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+IC0gICAgICAgdW5zaWduZWQgaW50
IGJ5dGVzX3Blcl9waXhlbDsKPiAtICAgICAgIHVuc2lnbmVkIGxvbmcgb2Zmc2V0Owo+IC0gICAg
ICAgc3RydWN0IGZiX2luZm8gKmZiaTsKPiAtICAgICAgIHNpemVfdCBzaXplOwo+IC0gICAgICAg
aW50IHJldDsKPiAtCj4gLSAgICAgICBEUk1fREVCVUdfS01TKCJzdXJmYWNlIHdpZHRoKCVkKSwg
aGVpZ2h0KCVkKSBhbmQgYnBwKCVkKVxuIiwKPiAtICAgICAgICAgICAgICAgICAgICAgICBzaXpl
cy0+c3VyZmFjZV93aWR0aCwgc2l6ZXMtPnN1cmZhY2VfaGVpZ2h0LAo+IC0gICAgICAgICAgICAg
ICAgICAgICAgIHNpemVzLT5zdXJmYWNlX2JwcCk7Cj4gLQo+IC0gICAgICAgYnl0ZXNfcGVyX3Bp
eGVsID0gRElWX1JPVU5EX1VQKHNpemVzLT5zdXJmYWNlX2JwcCwgOCk7Cj4gLSAgICAgICBzaXpl
ID0gc2l6ZXMtPnN1cmZhY2Vfd2lkdGggKiBzaXplcy0+c3VyZmFjZV9oZWlnaHQgKiBieXRlc19w
ZXJfcGl4ZWw7Cj4gLSAgICAgICBvYmogPSBkcm1fZ2VtX2NtYV9jcmVhdGUoZGV2LCBzaXplKTsK
PiAtICAgICAgIGlmIChJU19FUlIob2JqKSkKPiAtICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9N
RU07Cj4gLQo+IC0gICAgICAgZmJpID0gZHJtX2ZiX2hlbHBlcl9hbGxvY19mYmkoaGVscGVyKTsK
PiAtICAgICAgIGlmIChJU19FUlIoZmJpKSkgewo+IC0gICAgICAgICAgICAgICByZXQgPSBQVFJf
RVJSKGZiaSk7Cj4gLSAgICAgICAgICAgICAgIGdvdG8gZXJyX2dlbV9mcmVlX29iamVjdDsKPiAt
ICAgICAgIH0KPiAtCj4gLSAgICAgICBmYiA9IGRybV9nZW1fZmJkZXZfZmJfY3JlYXRlKGRldiwg
c2l6ZXMsIDAsICZvYmotPmJhc2UsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgIGZiZGV2X2NtYS0+ZmJfZnVuY3MpOwo+IC0gICAgICAgaWYgKElTX0VSUihmYikpIHsKPiAt
ICAgICAgICAgICAgICAgZGV2X2VycihkZXYtPmRldiwgIkZhaWxlZCB0byBhbGxvY2F0ZSBEUk0g
ZnJhbWVidWZmZXIuXG4iKTsKPiAtICAgICAgICAgICAgICAgcmV0ID0gUFRSX0VSUihmYik7Cj4g
LSAgICAgICAgICAgICAgIGdvdG8gZXJyX2ZiX2luZm9fZGVzdHJveTsKPiAtICAgICAgIH0KPiAt
Cj4gLSAgICAgICBoZWxwZXItPmZiID0gZmI7Cj4gLQo+IC0gICAgICAgZmJpLT5wYXIgPSBoZWxw
ZXI7Cj4gLSAgICAgICBmYmktPmZsYWdzID0gRkJJTkZPX0ZMQUdfREVGQVVMVDsKPiAtICAgICAg
IGZiaS0+ZmJvcHMgPSAmZHJtX2ZiZGV2X2NtYV9vcHM7Cj4gLQo+IC0gICAgICAgZHJtX2ZiX2hl
bHBlcl9maWxsX2ZpeChmYmksIGZiLT5waXRjaGVzWzBdLCBmYi0+Zm9ybWF0LT5kZXB0aCk7Cj4g
LSAgICAgICBkcm1fZmJfaGVscGVyX2ZpbGxfdmFyKGZiaSwgaGVscGVyLCBzaXplcy0+ZmJfd2lk
dGgsIHNpemVzLT5mYl9oZWlnaHQpOwo+IC0KPiAtICAgICAgIG9mZnNldCA9IGZiaS0+dmFyLnhv
ZmZzZXQgKiBieXRlc19wZXJfcGl4ZWw7Cj4gLSAgICAgICBvZmZzZXQgKz0gZmJpLT52YXIueW9m
ZnNldCAqIGZiLT5waXRjaGVzWzBdOwo+IC0KPiAtICAgICAgIGRldi0+bW9kZV9jb25maWcuZmJf
YmFzZSA9IChyZXNvdXJjZV9zaXplX3Qpb2JqLT5wYWRkcjsKPiAtICAgICAgIGZiaS0+c2NyZWVu
X2Jhc2UgPSBvYmotPnZhZGRyICsgb2Zmc2V0Owo+IC0gICAgICAgZmJpLT5maXguc21lbV9zdGFy
dCA9ICh1bnNpZ25lZCBsb25nKShvYmotPnBhZGRyICsgb2Zmc2V0KTsKCkhleSBOb3JhbGYsIGFs
bCwKICBJJ3ZlIGJlZW4gZGlnZ2luZyBmb3IgYSBiaXQgb24gdGhlIHJlZ3Jlc3Npb24gdGhhdCB0
aGlzIHBhdGNoIGhhcwp0cmlwcGVkIG9uIHRoZSBIaUtleSBib2FyZCBhcyByZXBvcnRlZCBoZXJl
OgpodHRwczovL2xrbWwub3JnL2xrbWwvMjAxOC84LzE2LzgxCgpUaGUgZmlyc3QgaXNzdWUgd2Fz
IHRoYXQgdGhlIGtpcmluIGRyaXZlciB3YXMgc2V0dGluZwptb2RlX2NvbmZpZy5tYXhfd2lkdGgv
aGVpZ2h0ID0gMjA0OCwgd2hpY2ggd2FzIGNhdXNpbmcgZXJyb3JzIGFzIHRoZQp0aGUgcmVxdWVz
dGVkIHJlc29sdXRpb24gd2FzIDE5MjB4MjE2MCAoZHVlIHRvIHN1cmZhY2VmbGluZ2VyCnJlcXVl
c3RpbmcgeSoyIGZvciBwYWdlIGZsaXBwaW5nKS4gIFRoaXMgd2FzIHJlbGF0aXZlbHkgc2ltcGxl
IGVub3VnaAp0byBmaWd1cmUgb3V0IGFuZCBmaXgsIGJ1dCBidW1waW5nIHRoZSB2YWx1ZXMgdXAg
b24gaXRzIG93biBkaWRuJ3QKc2VlbSB0byByZXNvbHZlIHRoZSBpc3N1ZSBlbnRpcmVseSwgYXMg
SSBzdGFydGVkIHRvIHNlZSBoYXJkIGhhbmdzIG9uCmJvb3R1cCB3aGVuIHVzZXJzcGFjZSBzdGFy
dGVkIHVzaW5nIHRoZSBlbXVsYXRlZCBmYmRldiBkZXZpY2UuCgpBZnRlciBjb25maXJtaW5nIHJl
dmVydGluZyB0aGUgcGF0Y2ggaGVyZSB3b3JrZWQgYXJvdW5kIGl0LCBJIHN0YXJ0ZWQKZGlnZ2lu
ZyB0aHJvdWdoIHdoYXQgbWlnaHQgYmUgZGlmZmVyZW50LCBhbmQgSSB0aGluayBJJ3ZlIGZvdW5k
IGl0LgpJbiB0aGUgZHJtX2ZiZGV2X2NtYV9jcmVhdGUoKSBmdW5jdGlvbiBhYm92ZSwgd2Ugc2V0
IHRoZQpmYmktPmZpeC5zbWVtX3N0YXJ0IHZhbHVlLCB3aGVyZSBhcyBpbiBkcm1fZmJfaGVscGVy
X2dlbmVyaWNfcHJvYmUoKSwKd2hpY2ggbm93IHJlcGxhY2VzIHRoYXQsIHdlIGRvbid0IHNldCBz
bWVtX3N0YXJ0IHZhbHVlIGF0IGFsbC4KClNpbmNlIHdlIGRvbid0IGhhdmUgYSBkcm1fZ2VtX2Nt
YV9vYmplY3QgcmVmZXJlbmNlIGluCmRybV9mYl9oZWxwZXJfZ2VuZXJpY19wcm9iZSgpLCBJIGlu
c3RlYWQgYWRkZWQ6CiAgIGZiaS0+Zml4LnNtZW1fc3RhcnQgPSBwYWdlX3RvX3BoeXModmlydF90
b19wYWdlKGZiaS0+c2NyZWVuX2J1ZmZlcikpOwoKQW5kIHRoYXQgZ290IHRoaW5ncyB3b3JraW5n
IQoKU28geWVhLCBJIHdhbnRlZCB0byBmaWd1cmUgb3V0IGlmIHdlIGFyZSBqdXN0IG1pc3Npbmcg
dGhlIGxpbmUgYWJvdmUKaW4gZHJtX2ZiX2hlbHBlcl9nZW5lcmljX3Byb2JlKCk/IE9yIGlmIHRo
ZSBraXJpbiBkcml2ZXIgc2hvdWxkIGJlCnNldHRpbmcgdGhlIGZpeC5zbWVtX3N0YXJ0IGluIHNv
bWUgb3RoZXIgZmFzaGlvbj8KCnRoYW5rcwotam9obgpfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9pbnRlbC1nZngK