From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Lespiau, Damien" <damien.lespiau@intel.com>
Subject: Re: [PATCH 02/10] drm/i915: enable and disable
 DDI_FUNC_CTL at the right time
Date: Wed, 10 Oct 2012 14:04:43 +0100
Message-ID: <CAPX-8+_G+KVKnfO2+=ZZma+0Ja2if-gfcCi-FeJpsCx_CBfO2A@mail.gmail.com>
References: <1349211142-4802-1-git-send-email-przanoni@gmail.com>
	<1349449561-3599-1-git-send-email-przanoni@gmail.com>
	<1349449561-3599-3-git-send-email-przanoni@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from azsmga101.ch.intel.com (mga07.intel.com [143.182.124.22])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5404B9E760
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Oct 2012 06:04:45 -0700 (PDT)
Received: by mail-qc0-f177.google.com with SMTP id u28so368928qcs.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 10 Oct 2012 06:04:43 -0700 (PDT)
In-Reply-To: <1349449561-3599-3-git-send-email-przanoni@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> And the right time is exactly after/before changing PIPE_CONF. See the
> documentation about the mode set sequence.
>
> This code is not inside any encoder-specific callback because
> DDI_FUNC_CTL is part of the pipe, so it is used by all encoders.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>

The r-b still holds with the resend.

-- 
Damien