[PATCH 00/10] Haswell pipe and clocking fixes

Paulo Zanoni
2012-10-05T15:06:13Z

Hi

This is a resend of the first 10 patches of the 47-patch series sent a few days
ago, with comments received on IRC and email applied.

Main changes:
- Patch 1 rewritten. Damien pointed some things and I also had a conversation
with an engineer and concluded that we should only check the LCPLL value and
print errors in case it's not exactly what we expect. This register should
be set by the BIOS and we shouldn't be changing it. Also, enabling/disabling
LCPLL is very complicated and would require a lot of code.
- Reordered patches. As pointed by Chris and Damien we should first fork
haswell_crtc_mode_set and then change it, instead of changing
ironlake_crtc_mode_set, forking a haswell version and then undoing the
changes in ironlake_crtc.

This was the first of the 4 sub-series. So far I don't have things to change on
the second series (patches 11-24), so feel free to review them as they are.
After the changes on the first 10 patches, only patch 23 gets a very small
conflict, so I won't resend the whole series again.

I have some changes for the third series (25-38) so for now let's focus on
patches 1-10 and 11-24.

Paulo Zanoni (10):
drm/i915: rewrite the LCPLL code
drm/i915: enable and disable DDI_FUNC_CTL at the right time
drm/i915: enable and disable PIPE_CLK_SEL at the right time
drm/i915: add haswell_crtc_mode_set
drm/i915: add proper CPU/PCH checks to crtc_mode_set functions
drm/i915: add haswell_set_pipeconf
drm/i915: completely rewrite the Haswell PLL handling code
drm/i915: don't rely on previous values set on DDI_BUF_CTL
drm/i915: disable DDI_BUF_CTL at the correct time
drm/i915: pipe and planes should be disabled on haswell_crtc_mode_set

drivers/gpu/drm/i915/i915_drv.h | 7 +
drivers/gpu/drm/i915/i915_reg.h | 9 +
drivers/gpu/drm/i915/intel_ddi.c | 441 ++++++++++++++++++++++++++++-------
drivers/gpu/drm/i915/intel_display.c | 275 +++++++++++++++++++++-
drivers/gpu/drm/i915/intel_drv.h | 12 +
drivers/gpu/drm/i915/intel_hdmi.c | 2 +
6 files changed, 651 insertions(+), 95 deletions(-)

--
1.7.11.4