Re: [PATCH 08/10] drm/i915: don't rely on previous values set on DDI_BUF_CTL

Lespiau, Damien
2012-10-10T14:28:01Z

On Fri, Oct 5, 2012 at 4:05 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> Just set the only bit we need, everything else is either ignored on
> HDMI or should be set to zero.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Is the assumption that intel_enable_ddi() will only ever be used by
the HDMI encore likely to hold true for ever? looks like a general
function that could be used by others to me. Also intel_disable_ddi()
read the register back, so it'd be unfair to only touch
intel_enable_ddi() if you want to do that.

I'd just stay on the safe side and retain the programming here.

--
Damien