From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wilde, Martin" Subject: Responsiveness Changes to i915 Driver Date: Thu, 14 Aug 2014 23:52:47 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_002_D01299DE3DA75martinwildeintelcom_" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 857D16E7AE for ; Thu, 14 Aug 2014 16:55:03 -0700 (PDT) Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" Cc: "Cheng, Anton" List-Id: intel-gfx@lists.freedesktop.org --_002_D01299DE3DA75martinwildeintelcom_ Content-Type: text/plain; charset="Windows-1252" Content-ID: <8C233B8F7E6D054185C3EDD2F623EBE8@intel.com> Content-Transfer-Encoding: quoted-printable Greetings, I am submitting the below changes to i915 Gfx driver to support resume time= Responsiveness measurements. These changes parallel the work already done= in the IVB Windows Gfx driver. These changes in addition to other OTS scr= ipts (suspend_resume) allow tracking of what is referred to as the =93B2I= =94 or =93Button To Image=94 time of the platform. The shorter this time, = the more responsiveness the platform is viewed by the end user. Panel sele= ction is an important factor in providing a more responsive system. Note t= here is no dependency on other scripts. The changes are standalone. * Display the current T1_T3 value. This is used to verify that the tim= ing set in the VBT is correct. We have seen many instances where the value= is not set correctly for the panel and the resume time is longer than nece= ssary (e.g. 500ms T3 versus 200ms T3). * Print the time when the first page flip occurs. This is when the use= r first sees the desktop displayed from resume. While this measurement cou= ld be done by other methods, this is the actual time that the desktop manag= er/framebuffer makes the driver request and the Gfx driver performs the act= ion. Thus any layering software added can be correlated to increases in th= is time. To support the latter (first page flip), I added a new ftrace called =93tra= ce_i915_resume=94. I looked at the existing page flip trace message and th= at one is designed for every page flip. I did not want to convolute it wit= h the one time flip trace on resume. I used a trace message instead of a p= rintk to reduce any performance impacts of using a printk. Additionally pr= intk is not reliable of when the message actually appears in the kernel log= . The attached patch file for the 3.10 Linux Kernel (currently used by the Ch= romium/Chrome OS project for a BayTrail platform) has the small number of c= hanges to a few files in the i915 directory. The changes are minimal and h= ave no impact in performance (that I have seen). I can also make the changes to the 3.15 Linux Kernel if required. Let me know of any additional questions Regards, -martin PCCG GED Responsiveness Technologist --_002_D01299DE3DA75martinwildeintelcom_ Content-Type: application/octet-stream; name="i915.patch" Content-Description: i915.patch Content-Disposition: attachment; filename="i915.patch"; size=3912; creation-date="Thu, 14 Aug 2014 23:52:47 GMT"; modification-date="Thu, 14 Aug 2014 23:52:47 GMT" Content-ID: <4AD004E22ED37940AB2CE2819B252C34@intel.com> Content-Transfer-Encoding: base64 ZGlmZiAtcnVwTiBzcmMub3JnL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmMgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmMKLS0tIHNyYy5vcmcvdGhpcmRfcGFydHkva2VybmVsLzMuMTAv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwkyMDE0LTA4LTE0IDE0OjIxOjM4LjY4MzMx OTA0MCAtMDcwMAorKysgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZHJ2LmMJMjAxNC0wNy0yOSAxMTowMTo0NC44Mjk5NjgzNDEgLTA3MDAKQEAg LTYxNSw2ICs2MTUsOCBAQCBzdGF0aWMgaW50IF9faTkxNV9kcm1fdGhhdyhzdHJ1Y3QgZHJtX2Rl CiAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsK IAlpbnQgZXJyb3IgPSAwOwogCisJZGV2X3ByaXYtPnRyYWNlX3BhZ2VfZmxpcCA9IHRydWU7IC8v IHdlIGFyZSByZXN1bWluZywgdHJhY2UgZmlyc3QgZmxpcAorCiAJaW50ZWxfdW5jb3JlX2Vhcmx5 X3Nhbml0aXplKGRldik7CiAKIAlpbnRlbF91bmNvcmVfc2FuaXRpemUoZGV2KTsKZGlmZiAtcnVw TiBzcmMub3JnL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2Lmggc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZHJ2LmgKLS0tIHNyYy5vcmcvdGhpcmRfcGFydHkva2VybmVsLzMuMTAvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9kcnYuaAkyMDE0LTA4LTE0IDE0OjIxOjQ3LjY4NzMxODczOCAtMDcw MAorKysgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZHJ2LmgJMjAxNC0wNy0yOSAxMTowMTo0NC44Mjk5NjgzNDEgLTA3MDAKQEAgLTE1MDksNiAr MTUwOSw3IEBAIHR5cGVkZWYgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgewogCS8qIE9sZCB1bXMg c3VwcG9ydCBpbmZyYXN0cnVjdHVyZSwgc2FtZSB3YXJuaW5nIGFwcGxpZXMuICovCiAJc3RydWN0 IGk5MTVfdW1zX3N0YXRlIHVtczsKIAkKKwlib29sIHRyYWNlX3BhZ2VfZmxpcDsgLy8gRmlyc3Qg cGFnZSBmbGlwIGFmdGVyIFMzIHRyYWNlIGZsYWcKIH0gZHJtX2k5MTVfcHJpdmF0ZV90OwogCiBz dGF0aWMgaW5saW5lIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICp0b19pOTE1KGNvbnN0IHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCmRpZmYgLXJ1cE4gc3JjLm9yZy90aGlyZF9wYXJ0eS9rZXJuZWwv My4xMC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmggc3JjL3RoaXJkX3BhcnR5L2tl cm5lbC8zLjEwL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfdHJhY2UuaAotLS0gc3JjLm9yZy90 aGlyZF9wYXJ0eS9rZXJuZWwvMy4xMC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgJ MjAxNC0wNy0yMiAxNDo1MToyNy45ODU3NDA3NDggLTA3MDAKKysrIHNyYy90aGlyZF9wYXJ0eS9r ZXJuZWwvMy4xMC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3RyYWNlLmgJMjAxNC0wOC0wNSAx NDoyODo0NS44ODkzMTkyNzUgLTA3MDAKQEAgLTUxMCw2ICs1MTAsMjIgQEAgVFJBQ0VfRVZFTlQo aW50ZWxfZ3B1X2ZyZXFfY2hhbmdlLAogCSAgICBUUF9wcmludGsoIm5ld19mcmVxPSV1IiwgX19l bnRyeS0+ZnJlcSkKICk7CiAKK1RSQUNFX0VWRU5UKGk5MTVfcmVzdW1lLAorCSAgICBUUF9QUk9U Tyhjb25zdCBjaGFyICphY3Rpb24sIGJvb2wgc3RhcnQpLAorCSAgICBUUF9BUkdTKGFjdGlvbiwg c3RhcnQpLAorCisJICAgIFRQX1NUUlVDVF9fZW50cnkoCisJCQkgICAgIF9fZmllbGQoY29uc3Qg Y2hhciAqLCBhY3Rpb24pCisJCQkgICAgIF9fZmllbGQoYm9vbCwgc3RhcnQpCisJCQkgICAgICks CisKKwkgICAgVFBfZmFzdF9hc3NpZ24oCisJCQkgICBfX2VudHJ5LT5hY3Rpb24gPSBhY3Rpb247 CisJCQkgICBfX2VudHJ5LT5zdGFydCA9IHN0YXJ0OworCQkJICAgKSwKKworCSAgICBUUF9wcmlu dGsoIiVzICVzIiwgX19lbnRyeS0+YWN0aW9uLCAoX19lbnRyeS0+c3RhcnQpPyJiZWdpbiI6ImVu ZCIpCispOwogI2VuZGlmIC8qIF9JOTE1X1RSQUNFX0hfICovCiAKIC8qIFRoaXMgcGFydCBtdXN0 IGJlIG91dHNpZGUgcHJvdGVjdGlvbiAqLwpkaWZmIC1ydXBOIHNyYy5vcmcvdGhpcmRfcGFydHkv a2VybmVsLzMuMTAvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHNyYy90aGly ZF9wYXJ0eS9rZXJuZWwvMy4xMC9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMK LS0tIHNyYy5vcmcvdGhpcmRfcGFydHkva2VybmVsLzMuMTAvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZGlzcGxheS5jCTIwMTQtMDgtMTQgMTQ6MjI6MzEuNzM5MzE3MjY1IC0wNzAwCisrKyBz cmMvdGhpcmRfcGFydHkva2VybmVsLzMuMTAvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCTIwMTQtMDgtMTQgMTE6NTg6MzUuNzQzNjA2MTgxIC0wNzAwCkBAIC04MzU4LDYgKzgz NTgsMTEgQEAgc3RhdGljIGludCBpbnRlbF9jcnRjX3BhZ2VfZmxpcChzdHJ1Y3QgZAogCiAJdHJh Y2VfaTkxNV9mbGlwX3JlcXVlc3QoaW50ZWxfY3J0Yy0+cGxhbmUsIG9iaik7CiAKKwlpZiAoZGV2 X3ByaXYtPnRyYWNlX3BhZ2VfZmxpcCkgeworCQlkZXZfcHJpdi0+dHJhY2VfcGFnZV9mbGlwID0g ZmFsc2U7IC8vIHJlc2V0IHRvIG9ubHkgdHJhY2sgb25jZQorCQl0cmFjZV9pOTE1X3Jlc3VtZSgi Zmlyc3QgcGFnZSBmbGlwIGFmdGVyIHJlc3VtZSIsIGZhbHNlKTsKKwl9CisKIAlyZXR1cm4gMDsK IAogY2xlYW51cF9wZW5kaW5nOgpAQCAtOTgwNSw2ICs5ODEwLDggQEAgc3RhdGljIHZvaWQgaW50 ZWxfY3J0Y19pbml0KHN0cnVjdCBkcm1fZAogCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRj OwogCWludCBpOwogCisJZGV2X3ByaXYtPnRyYWNlX3BhZ2VfZmxpcCA9IGZhbHNlOyAvLyByZXNl dCBTMyBwYWdlIGZsaXAgdG8gbm8gdHJhY2UKKwogCWludGVsX2NydGMgPSBremFsbG9jKHNpemVv ZigqaW50ZWxfY3J0YyksIEdGUF9LRVJORUwpOwogCWlmIChpbnRlbF9jcnRjID09IE5VTEwpCiAJ CXJldHVybjsKZGlmZiAtcnVwTiBzcmMub3JnL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKLS0tIHNyYy5vcmcvdGhpcmRfcGFydHkva2Vy bmVsLzMuMTAvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwkyMDE0LTA4LTE0IDE0OjI0 OjQ1LjY1NTMxMjc4NSAtMDcwMAorKysgc3JjL3RoaXJkX3BhcnR5L2tlcm5lbC8zLjEwL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMJMjAxNC0wOC0xNCAxMTo1NzozMC4yMDM2MDgzNzQg LTA3MDAKQEAgLTM1MjgsNiArMzUyOCw3IEBAIGludGVsX2RwX2luaXRfcGFuZWxfcG93ZXJfc2Vx dWVuY2VyKHN0cnUKIAlpbnRlbF9kcC0+cGFuZWxfcG93ZXJfY3ljbGVfZGVsYXkgPSBnZXRfZGVs YXkodDExX3QxMik7CiAjdW5kZWYgZ2V0X2RlbGF5CiAKKwlwcmludGsoS0VSTl9JTkZPICJpOTE1 OiBlRFAgVDMgVmFsdWU6ICVkXG4iLCBpbnRlbF9kcC0+cGFuZWxfcG93ZXJfdXBfZGVsYXkpOwog CURSTV9ERUJVR19LTVMoInBhbmVsIHBvd2VyIHVwIGRlbGF5ICVkLCBwb3dlciBkb3duIGRlbGF5 ICVkLCBwb3dlciBjeWNsZSBkZWxheSAlZFxuIiwKIAkJICAgICAgaW50ZWxfZHAtPnBhbmVsX3Bv d2VyX3VwX2RlbGF5LCBpbnRlbF9kcC0+cGFuZWxfcG93ZXJfZG93bl9kZWxheSwKIAkJICAgICAg aW50ZWxfZHAtPnBhbmVsX3Bvd2VyX2N5Y2xlX2RlbGF5KTsK --_002_D01299DE3DA75martinwildeintelcom_ Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --_002_D01299DE3DA75martinwildeintelcom_--