Re: [PATCH v9 03/23] gpu: nova-core: gsp: Return GspStaticInfo from boot()

Eliot Courtney
2026-03-12T16:45:44Z

On Wed Mar 11, 2026 at 9:39 AM JST, Joel Fernandes wrote:
> Refactor the GSP boot function to return only the GspStaticInfo,
> removing the FbLayout from the return tuple.

I think the commit message may need updating - `boot` doesn't return
FbLayout. And it returns `GetGspStaticInfoReply`, not `GspStaticInfo`.

Other than that,
Reviewed-by: Eliot Courtney <ecourtney@nvidia.com>

>
> @@ -126,7 +129,8 @@ fn run_fwsec_frts(
> /// user-space, patching them with signatures, and building firmware-specific intricate data
> /// structures that the GSP will use at runtime.
> ///
> - /// Upon return, the GSP is up and running, and its runtime object given as return value.
> + /// Upon return, the GSP is up and running, and static GPU information is returned.
> + ///
> pub(crate) fn boot(
> mut self: Pin<&mut Self>,
> pdev: &pci::Device<device::Bound>,
> @@ -134,7 +138,7 @@ pub(crate) fn boot(
> chipset: Chipset,
> gsp_falcon: &Falcon<Gsp>,
> sec2_falcon: &Falcon<Sec2>,
> - ) -> Result {
> + ) -> Result<GetGspStaticInfoReply> {
> let dev = pdev.as_ref();
>
> let bios = Vbios::new(dev, bar)?;
> @@ -225,6 +229,6 @@ pub(crate) fn boot(
> Err(e) => dev_warn!(pdev, "GPU name unavailable: {:?}\n", e),
> }
>
> - Ok(())
> + Ok(info)
> }
> }