Re: [PATCH v10 12/21] gpu: nova-core: mm: Add unified page table entry wrapper enums

John Hubbard
2026-04-09T18:02:58Z

On 4/9/26 3:33 AM, Joel Fernandes wrote:
...
> Since it is 3 against 1 here, I rest my case :-). I am still in

As Danilo points out, we want to foster healthy debate and land
on whatever comes out of that. Not just by counting noses. :)

> disagreement since I do not see much benefit (that is why I said
> pointless above). Actually it is not even about readability, that is
> subjective (and I haven’t heard most people say parametrizing code for
> the sake of it makes it more readable anyway). It is that the code gen
> is worse, and the complexity is just moved to a higher level in the
> code, not removed. So what are we getting out of this really, other than
> more boiler plate in higher layers of the code that did not exist
> before? Not performance, not better generated code. Really nothing. See
> all the data points in my previous reply.

Alex's latest response[1] does a *much* better job than mine, in
explicitly highlighting what we get out of this. (It arrived a bit after
your response here.) Please take a very close look at that response and
see what you think.

The patterns in these page tables are not a new thing, and Rust has
language features to help express them.

[1] https://lore.kernel.org/DHOKJ3MJNO5P.SXKOAYKX13JL@nvidia.com

thanks,
--
John Hubbard