From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D28CC636D3 for ; Tue, 7 Feb 2023 17:47:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 81EAF10E1E9; Tue, 7 Feb 2023 17:47:38 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id D011710E1E9; Tue, 7 Feb 2023 17:47:36 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 365FAB81A21; Tue, 7 Feb 2023 17:47:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C6A1C433D2; Tue, 7 Feb 2023 17:47:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675792053; bh=+64e+8mFJKnm+yEYJF8Wm9cBrBW+Xnn8VVoYGCj2o4o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lxPHTo2gRczfX0FFhodjL1OD3Pe7ccpOrMmfFdKFWYKVdnvT1bv/uWyoHYoiFRr2j k/JbE9UPKwTdKM2YLNh19Ql5cfYg2zbPzDpI5dLprUCYigNH7pNE/gsuH0lBBsQCaq 7sEi/3TPeWngpL4gNkJwGZfRGagS3Cta4/+ZHetM= Date: Tue, 7 Feb 2023 18:47:31 +0100 From: Greg Kroah-Hartman To: Jani Nikula Message-ID: References: <20230207143337.2126678-1-jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230207143337.2126678-1-jani.nikula@intel.com> Subject: Re: [Intel-gfx] [PATCH] drm: Disable dynamic debug as broken X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Jim Cromie , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Maxime Ripard , Thomas Zimmermann , stable@vger.kernel.org, David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Feb 07, 2023 at 04:33:37PM +0200, Jani Nikula wrote: > From: Ville Syrjälä > > CONFIG_DRM_USE_DYNAMIC_DEBUG breaks debug prints for (at least modular) > drm drivers. The debug prints can be reinstated by manually frobbing > /sys/module/drm/parameters/debug after the fact, but at that point the > damage is done and all debugs from driver probe are lost. This makes > drivers totally undebuggable. > > There's a more complete fix in progress [1], with further details, but > we need this fixed in stable kernels. Mark the feature as broken and > disable it by default, with hopes distros follow suit and disable it as > well. > > [1] https://lore.kernel.org/r/20230125203743.564009-1-jim.cromie@gmail.com > > Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro") > Cc: Jim Cromie > Cc: Greg Kroah-Hartman > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter > Cc: dri-devel@lists.freedesktop.org > Cc: # v6.1+ > Signed-off-by: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig > index f42d4c6a19f2..dc0f94f02a82 100644 > --- a/drivers/gpu/drm/Kconfig > +++ b/drivers/gpu/drm/Kconfig > @@ -52,7 +52,8 @@ config DRM_DEBUG_MM > > config DRM_USE_DYNAMIC_DEBUG > bool "use dynamic debug to implement drm.debug" > - default y > + default n > + depends on BROKEN > depends on DRM > depends on DYNAMIC_DEBUG || DYNAMIC_DEBUG_CORE > depends on JUMP_LABEL Acked-by: Greg Kroah-Hartman