Re: [Intel-gfx] [PATCH 09/10] vfio: Make vfio_container optionally compiled

Jason Gunthorpe
2022-11-01T12:56:17Z

On Tue, Nov 01, 2022 at 08:41:56AM +0000, Tian, Kevin wrote:
> > From: Jason Gunthorpe <jgg@nvidia.com>
> > Sent: Wednesday, October 26, 2022 2:51 AM
> >
> > if VFIO
> > +config VFIO_CONTAINER
> > + bool "Support for the VFIO container /dev/vfio/vfio"
> > + select VFIO_IOMMU_TYPE1 if MMU && (X86 || S390 || ARM ||
> > ARM64)
> > + default y
> > + help
> > + The VFIO container is the classic interface to VFIO for establishing
> > + mappings. If N is selected here then IOMMUFD must be used the
>
> establishing IOMMU mappings.
>
> s/used the manage/used to manage/

Done

> > +if VFIO_CONTAINER
> > config VFIO_IOMMU_TYPE1
> > tristate
> > - default n
> > + default MMU && (X86 || S390 || ARM || ARM64)
>
> there are already same conditions for selecting TYPE1 from
> VFIO_CONTAINER. what does duplicating conditions here
> bring to us?

Yah, we can leave this out - this is just the more normal way to
approach this kconfig trick, AFAICT

Thanks,
Jason