Re: [Intel-gfx] [PATCH 00/10] Connect VFIO to IOMMUFD

Yi Liu
2022-11-01T12:55:15Z

On 2022/11/1 19:41, Jason Gunthorpe wrote:
> On Tue, Nov 01, 2022 at 11:04:38AM +0800, Yi Liu wrote:
>> On 2022/11/1 07:24, Jason Gunthorpe wrote:
>>> On Mon, Oct 31, 2022 at 08:25:39PM +0800, Yi Liu wrote:
>>>>> There is something wrong with the test suite that it isn't covering
>>>>> the above, I'm going to look into that today.
>>>>
>>>> sounds to be the cause. I didn't see any significant change in vfio_main.c
>>>> that may fail gvt. So should the iommufd changes. Then we will re-run the
>>>> test after your update.:-)
>>>
>>> I updated the github with all the changes made so far, it is worth
>>> trying again!
>>
>> gvt is still failing with below call trace in host side. vfio_unpin_pages()
>> is still in problem. Any idea on it?
>
> Oh, this is my mistake, I rushed a bit getting updated branches:
>
> diff --git a/drivers/vfio/iommufd.c b/drivers/vfio/iommufd.c
> index 40eb6931ab2321..29e7b1fdd0cd4a 100644
> --- a/drivers/vfio/iommufd.c
> +++ b/drivers/vfio/iommufd.c
> @@ -118,6 +118,7 @@ static void vfio_emulated_unmap(void *data, unsigned long iova,
> }
>
> static const struct iommufd_access_ops vfio_user_ops = {
> + .needs_pin_pages = 1,
> .unmap = vfio_emulated_unmap,
> };

yes, it is. The call trace goes away. my colleague is running gvt full test
now.

--
Regards,
Yi Liu