Re: [Intel-gfx] [PATCH 02/10] vfio: Move vfio_device_assign_container() into vfio_device_first_open()

Jason Gunthorpe
2022-11-01T17:38:04Z

On Tue, Nov 01, 2022 at 10:37:14PM +0800, Yi Liu wrote:
> > @@ -784,12 +791,6 @@ static struct file *vfio_device_open(struct vfio_device *device)
> > struct file *filep;
> > int ret;
> > - mutex_lock(&device->group->group_lock);
> > - ret = vfio_device_assign_container(device);
> > - mutex_unlock(&device->group->group_lock);
> > - if (ret)
> > - return ERR_PTR(ret);
> > -
> > mutex_lock(&device->dev_set->lock);
> > device->open_count++;
> > if (device->open_count == 1) {
> > @@ -833,7 +834,6 @@ static struct file *vfio_device_open(struct vfio_device *device)
> > err_unassign_container:
>
> should the err_unassign_container be renamed to be err_dec_count?

Yes, I went with err_unlock

Thanks,
Jason