From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21DC9C00A5A for ; Tue, 17 Jan 2023 22:50:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 415E810E5EF; Tue, 17 Jan 2023 22:50:20 +0000 (UTC) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7CB110E5EF for ; Tue, 17 Jan 2023 22:50:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673995817; x=1705531817; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=M/qZjrNxlyG1yz8g7lq/Hb24H05mQQgOnueVyvM6/ns=; b=S2cOnRkU6/k0RAysa3vB8979EpvOj7T1VsIyU1gi8DcL3jkWf39mIfkQ 2svU9dKwmSLaDtcm0PpDNBrZ5nmArkdSKMvYzB4wb5SBgQYJOLxfY2QWz mlUjPDDtTFLdTpUperzWL3/EjXge738p6HLF0d638inRyDBMO1UVO7I2D PFhxIxaqK++snu4Bj295dQUiGOJdq1XKSIXYWonee1W9qPwh1o7enA3+a LwXeJ9iuHpoMktfJs764P94BXdUdKvcxqwK29bI3JenbMdXFdP+iRm6tU giqh7bxrHLx7y70NMFnahfNwJM08+48sNmu+A4Iuw9255wwR9VvNf5TeB A==; X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="387185767" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="387185767" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jan 2023 14:50:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10593"; a="691756254" X-IronPort-AV: E=Sophos;i="5.97,224,1669104000"; d="scan'208";a="691756254" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.55]) by orsmga001.jf.intel.com with SMTP; 17 Jan 2023 14:50:14 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 18 Jan 2023 00:50:14 +0200 Date: Wed, 18 Jan 2023 00:50:14 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Rodrigo Vivi Message-ID: References: <20221219172927.9603-1-sasa.dragic@gmail.com> <20221219172927.9603-2-sasa.dragic@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH 1/1] drm/i915: re-disable RC6p on Sandy Bridge X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Dec 21, 2022 at 09:09:17AM -0500, Rodrigo Vivi wrote: > On Tue, Dec 20, 2022 at 12:32:05PM +0200, Ville Syrjälä wrote: > > On Mon, Dec 19, 2022 at 06:29:27PM +0100, Sasa Dragic wrote: > > > RC6p on Sandy Bridge got re-enabled over time, causing visual glitches > > > and GPU hangs. > > > > > > Disabled originally in commit 1c8ecf80fdee ("drm/i915: do not enable > > > RC6p on Sandy Bridge"). > > > > re cover letter: > > > It was originally disabled in commit 1c8ecf80fdee ("drm/i915: do not > > > enable RC6p on Sandy Bridge"), and subsequently re-enabled by > > > 13c5a577b342 ("drm/i915/gt: Select the deepest available parking mode > > > for rc6"), which seems to focus only on Ivy Bridge. > > > > That only kicks in while parked (ie. fully idle from > > software POV). I think the real bad commit is > > fb6db0f5bf1d ("drm/i915: Remove unsafe i915.enable_rc6") > > which seems to affects which rc6 level is selected while > > unparked. > > > > We should mention both of those commits here: > > Fixes: fb6db0f5bf1d ("drm/i915: Remove unsafe i915.enable_rc6") > > Fixes: 13c5a577b342 ("drm/i915/gt: Select the deepest available parking mode for rc6") > > > > Also we want > > Cc: stable@vger.kernel.org > > > > We can add those while pushing, so no need to resend for that. > > agreed. > > Reviewed-by: Rodrigo Vivi Pushed to drm-intel-gt-next. Thanks for the patch and review. > > > > > > > > > Signed-off-by: Sasa Dragic > > > --- > > > drivers/gpu/drm/i915/i915_pci.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c > > > index 668e9da52584..69377564028a 100644 > > > --- a/drivers/gpu/drm/i915/i915_pci.c > > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > > @@ -423,7 +423,8 @@ static const struct intel_device_info ilk_m_info = { > > > .has_coherent_ggtt = true, \ > > > .has_llc = 1, \ > > > .has_rc6 = 1, \ > > > - .has_rc6p = 1, \ > > > + /* snb does support rc6p, but enabling it causes various issues */ \ > > > + .has_rc6p = 0, \ > > > > The one downside of doing it this way is that we also lose > > the debugfs/sysfs files so we can't monitor rc6+/++ > > residency anymore to make sure they are not entered. > > > > I think ideally we'd split this into two parts: which rc6 > > states the hw actually has vs. which rc6 states we actually > > want to use. But at least for the time being I think this > > simple should be sufficient, and should be easy to backport > > to stable releases. > > > > > .has_rps = true, \ > > > .dma_mask_size = 40, \ > > > .__runtime.ppgtt_type = INTEL_PPGTT_ALIASING, \ > > > -- > > > 2.37.2 > > > > -- > > Ville Syrjälä > > Intel -- Ville Syrjälä Intel