From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v7 04/22] drm/edid: Use the pre-parsed VICs
Date: Wed, 18 Jan 2023 17:08:57 +0200 [thread overview]
Message-ID: <Y8gLiSc3hrxfn9QH@intel.com> (raw)
In-Reply-To: <30f1a97193171e70ec1c26c4b685d8930799b9a6.1672826282.git.jani.nikula@intel.com>
On Wed, Jan 04, 2023 at 12:05:19PM +0200, Jani Nikula wrote:
> Now that we have all the VICs in info->vics, use them to simplify access
> based on VIC index, i.e. on the order of VICs in the EDID, and avoid
> passing CTA VDB pointers around.
>
> This also fixes the highly unlikely scenarios of a) multiple HDMI VSDBs,
> and b) HDMI VSDB 3D modes using VIC indexes that span across multiple
> CTA VDBs, and the combination of the two.
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Cool. Takes care of my previously stated concern of
multiple CTA/HDMI data blocks.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/drm_edid.c | 92 +++++++++++++-------------------------
> 1 file changed, 32 insertions(+), 60 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index 90846dc69061..7f0386175230 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -4468,28 +4468,20 @@ static u8 svd_to_vic(u8 svd)
> return svd;
> }
>
> +/*
> + * Return a display mode for the 0-based vic_index'th VIC across all CTA VDBs in
> + * the EDID, or NULL on errors.
> + */
> static struct drm_display_mode *
> -drm_display_mode_from_vic_index(struct drm_connector *connector,
> - const u8 *video_db, u8 video_len,
> - u8 video_index)
> +drm_display_mode_from_vic_index(struct drm_connector *connector, int vic_index)
> {
> + const struct drm_display_info *info = &connector->display_info;
> struct drm_device *dev = connector->dev;
> - struct drm_display_mode *newmode;
> - u8 vic;
>
> - if (video_db == NULL || video_index >= video_len)
> + if (!info->vics || vic_index >= info->vics_len || !info->vics[vic_index])
> return NULL;
>
> - /* CEA modes are numbered 1..127 */
> - vic = svd_to_vic(video_db[video_index]);
> - if (!drm_valid_cea_vic(vic))
> - return NULL;
> -
> - newmode = drm_mode_duplicate(dev, cea_mode_for_vic(vic));
> - if (!newmode)
> - return NULL;
> -
> - return newmode;
> + return drm_display_mode_from_cea_vic(dev, info->vics[vic_index]);
> }
>
> /*
> @@ -4538,9 +4530,8 @@ static int do_y420vdb_modes(struct drm_connector *connector,
> * Makes an entry for a videomode in the YCBCR 420 bitmap
> */
> static void
> -drm_add_cmdb_modes(struct drm_connector *connector, u8 svd)
> +drm_add_cmdb_modes(struct drm_connector *connector, u8 vic)
> {
> - u8 vic = svd_to_vic(svd);
> struct drm_hdmi_info *hdmi = &connector->display_info.hdmi;
>
> if (!drm_valid_cea_vic(vic))
> @@ -4577,16 +4568,20 @@ drm_display_mode_from_cea_vic(struct drm_device *dev,
> }
> EXPORT_SYMBOL(drm_display_mode_from_cea_vic);
>
> -static int
> -do_cea_modes(struct drm_connector *connector, const u8 *db, u8 len)
> +/* Add modes based on VICs parsed in parse_cta_vdb() */
> +static int add_cta_vdb_modes(struct drm_connector *connector)
> {
> + const struct drm_display_info *info = &connector->display_info;
> + const struct drm_hdmi_info *hdmi = &info->hdmi;
> int i, modes = 0;
> - struct drm_hdmi_info *hdmi = &connector->display_info.hdmi;
>
> - for (i = 0; i < len; i++) {
> + if (!info->vics)
> + return 0;
> +
> + for (i = 0; i < info->vics_len; i++) {
> struct drm_display_mode *mode;
>
> - mode = drm_display_mode_from_vic_index(connector, db, len, i);
> + mode = drm_display_mode_from_vic_index(connector, i);
> if (mode) {
> /*
> * YCBCR420 capability block contains a bitmap which
> @@ -4598,7 +4593,7 @@ do_cea_modes(struct drm_connector *connector, const u8 *db, u8 len)
> * Add YCBCR420 modes only if sink is HDMI 2.0 capable.
> */
> if (i < 64 && hdmi->y420_cmdb_map & (1ULL << i))
> - drm_add_cmdb_modes(connector, db[i]);
> + drm_add_cmdb_modes(connector, info->vics[i]);
>
> drm_mode_probed_add(connector, mode);
> modes++;
> @@ -4693,15 +4688,13 @@ static int add_hdmi_mode(struct drm_connector *connector, u8 vic)
> }
>
> static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> - const u8 *video_db, u8 video_len, u8 video_index)
> + int vic_index)
> {
> struct drm_display_mode *newmode;
> int modes = 0;
>
> if (structure & (1 << 0)) {
> - newmode = drm_display_mode_from_vic_index(connector, video_db,
> - video_len,
> - video_index);
> + newmode = drm_display_mode_from_vic_index(connector, vic_index);
> if (newmode) {
> newmode->flags |= DRM_MODE_FLAG_3D_FRAME_PACKING;
> drm_mode_probed_add(connector, newmode);
> @@ -4709,9 +4702,7 @@ static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> }
> }
> if (structure & (1 << 6)) {
> - newmode = drm_display_mode_from_vic_index(connector, video_db,
> - video_len,
> - video_index);
> + newmode = drm_display_mode_from_vic_index(connector, vic_index);
> if (newmode) {
> newmode->flags |= DRM_MODE_FLAG_3D_TOP_AND_BOTTOM;
> drm_mode_probed_add(connector, newmode);
> @@ -4719,9 +4710,7 @@ static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> }
> }
> if (structure & (1 << 8)) {
> - newmode = drm_display_mode_from_vic_index(connector, video_db,
> - video_len,
> - video_index);
> + newmode = drm_display_mode_from_vic_index(connector, vic_index);
> if (newmode) {
> newmode->flags |= DRM_MODE_FLAG_3D_SIDE_BY_SIDE_HALF;
> drm_mode_probed_add(connector, newmode);
> @@ -4742,8 +4731,7 @@ static int add_3d_struct_modes(struct drm_connector *connector, u16 structure,
> * also adds the stereo 3d modes when applicable.
> */
> static int
> -do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len,
> - const u8 *video_db, u8 video_len)
> +do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len)
> {
> struct drm_display_info *info = &connector->display_info;
> int modes = 0, offset = 0, i, multi_present = 0, multi_len;
> @@ -4818,9 +4806,7 @@ do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len,
> for (i = 0; i < 16; i++) {
> if (mask & (1 << i))
> modes += add_3d_struct_modes(connector,
> - structure_all,
> - video_db,
> - video_len, i);
> + structure_all, i);
> }
> }
>
> @@ -4857,8 +4843,6 @@ do_hdmi_vsdb_modes(struct drm_connector *connector, const u8 *db, u8 len,
>
> if (newflag != 0) {
> newmode = drm_display_mode_from_vic_index(connector,
> - video_db,
> - video_len,
> vic_index);
>
> if (newmode) {
> @@ -5249,20 +5233,16 @@ static int add_cea_modes(struct drm_connector *connector,
> {
> const struct cea_db *db;
> struct cea_db_iter iter;
> - const u8 *hdmi = NULL, *video = NULL;
> - u8 hdmi_len = 0, video_len = 0;
> - int modes = 0;
> + int modes;
> +
> + /* CTA VDB block VICs parsed earlier */
> + modes = add_cta_vdb_modes(connector);
>
> cea_db_iter_edid_begin(drm_edid, &iter);
> cea_db_iter_for_each(db, &iter) {
> - if (cea_db_tag(db) == CTA_DB_VIDEO) {
> - video = cea_db_data(db);
> - video_len = cea_db_payload_len(db);
> - modes += do_cea_modes(connector, video, video_len);
> - } else if (cea_db_is_hdmi_vsdb(db)) {
> - /* FIXME: Switch to use cea_db_data() */
> - hdmi = (const u8 *)db;
> - hdmi_len = cea_db_payload_len(db);
> + if (cea_db_is_hdmi_vsdb(db)) {
> + modes += do_hdmi_vsdb_modes(connector, (const u8 *)db,
> + cea_db_payload_len(db));
> } else if (cea_db_is_y420vdb(db)) {
> const u8 *vdb420 = cea_db_data(db) + 1;
>
> @@ -5273,14 +5253,6 @@ static int add_cea_modes(struct drm_connector *connector,
> }
> cea_db_iter_end(&iter);
>
> - /*
> - * We parse the HDMI VSDB after having added the cea modes as we will be
> - * patching their flags when the sink supports stereo 3D.
> - */
> - if (hdmi)
> - modes += do_hdmi_vsdb_modes(connector, hdmi, hdmi_len,
> - video, video_len);
> -
> return modes;
> }
>
> --
> 2.34.1
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2023-01-18 15:09 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 10:05 [Intel-gfx] [PATCH v7 00/22] drm/edid: info & modes parsing and drm_edid refactors Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 01/22] drm/edid: fix AVI infoframe aspect ratio handling Jani Nikula
2023-01-18 14:56 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 02/22] drm/edid: fix parsing of 3D modes from HDMI VSDB Jani Nikula
2023-01-18 15:00 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 03/22] drm/edid: parse VICs from CTA VDB early Jani Nikula
2023-01-18 15:12 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 04/22] drm/edid: Use the pre-parsed VICs Jani Nikula
2023-01-18 15:08 ` Ville Syrjälä [this message]
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 05/22] drm/edid: use VIC in AVI infoframe if sink lists it in CTA VDB Jani Nikula
2023-01-18 15:18 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 06/22] drm/edid: rename struct drm_display_info *display to *info Jani Nikula
2023-01-18 15:19 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 07/22] drm/edid: refactor CTA Y420CMDB parsing Jani Nikula
2023-01-18 15:24 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 08/22] drm/edid: split CTA Y420VDB info and mode parsing Jani Nikula
2023-01-18 15:32 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 09/22] drm/edid: fix and clarify HDMI VSDB audio latency parsing Jani Nikula
2023-01-18 15:41 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 10/22] drm/edid: add helper for HDMI VSDB audio latency field length Jani Nikula
2023-01-18 15:42 ` Ville Syrjälä
2023-01-19 9:44 ` Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 11/22] drm/edid: split HDMI VSDB info and mode parsing Jani Nikula
2023-01-18 16:08 ` Ville Syrjälä
2023-01-19 15:46 ` [Intel-gfx] [PATCH] " Jani Nikula
2023-01-19 15:59 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 12/22] drm/edid: store quirks in display info Jani Nikula
2023-01-18 16:09 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 13/22] drm/edid: stop passing quirks around Jani Nikula
2023-01-18 16:09 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 14/22] drm/edid: merge ELD handling to update_display_info() Jani Nikula
2023-01-18 16:14 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 15/22] drm/edid: move EDID BPC quirk application " Jani Nikula
2023-01-18 16:15 ` Ville Syrjälä
2023-01-19 12:16 ` Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 16/22] drm/edid: refactor _drm_edid_connector_update() and rename Jani Nikula
2023-01-19 12:19 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 17/22] drm/edid: add separate drm_edid_connector_add_modes() Jani Nikula
2023-01-19 12:23 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 18/22] drm/edid: remove redundant _drm_connector_update_edid_property() Jani Nikula
2023-01-19 12:23 ` Ville Syrjälä
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 19/22] drm/i915/edid: convert DP, HDMI and LVDS to drm_edid Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 20/22] drm/i915/bios: convert intel_bios_init_panel() " Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 21/22] drm/i915/opregion: convert intel_opregion_get_edid() to struct drm_edid Jani Nikula
2023-01-04 10:05 ` [Intel-gfx] [PATCH v7 22/22] drm/i915/panel: move panel fixed EDID to struct intel_panel Jani Nikula
2023-01-04 10:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: info & modes parsing and drm_edid refactors Patchwork
2023-01-04 10:40 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-01-19 15:49 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/edid: info & modes parsing and drm_edid refactors (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gLiSc3hrxfn9QH@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox