From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E14D6C54EAA for ; Fri, 27 Jan 2023 09:08:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 65EB910E42E; Fri, 27 Jan 2023 09:08:38 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5AE4010E42E; Fri, 27 Jan 2023 09:08:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C7921B81ED1; Fri, 27 Jan 2023 09:08:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0390FC433D2; Fri, 27 Jan 2023 09:08:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674810514; bh=2G/hsP8wZXgxnN+v9hmdG6FLAzuvTLuIT43qSfo4pAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OlTurCqHgNxLsRw4T2KBUBILpX+noceshEsSxr4YH2jEYCUvVw5po3LapF/jPSC1b hkNREgPEJAoeONdvfDsnuqPVyfSHo7eZ2KGcFGFFmLJ0IeMyvrTv4qJHGvJlwUG8Hc NiEAClHSm8Kgq+dDnS2/lM0djVntMI3bIrytWKtg= Date: Fri, 27 Jan 2023 10:08:31 +0100 From: Greg Kroah-Hartman To: Alan Previn Message-ID: References: <20230125082637.118970-1-alan.previn.teres.alexis@intel.com> <20230125082637.118970-4-alan.previn.teres.alexis@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230125082637.118970-4-alan.previn.teres.alexis@intel.com> Subject: Re: [Intel-gfx] [PATCH v7 3/6] mei: clean pending read with vtag on bus X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Alexander Usyskin , dri-devel@lists.freedesktop.org, Vivi@kroah.com, Rodrigo , Tomas Winkler Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Jan 25, 2023 at 12:26:34AM -0800, Alan Previn wrote: > From: Alexander Usyskin > > Client on bus have only one vtag map slot and should disregard the vtag > value when cleaning pending read flag. > Fixes read flow control message unexpectedly generated when > clent on bus send messages with different vtags. > > Signed-off-by: Alexander Usyskin > Reviewed-by: Tomas Winkler > Signed-off-by: Alan Previn > --- > drivers/misc/mei/client.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c > index 9ddb854b8155..5c19097266fe 100644 > --- a/drivers/misc/mei/client.c > +++ b/drivers/misc/mei/client.c > @@ -1343,7 +1343,9 @@ static void mei_cl_reset_read_by_vtag(const struct mei_cl *cl, u8 vtag) > struct mei_cl_vtag *vtag_l; > > list_for_each_entry(vtag_l, &cl->vtag_map, list) { > - if (vtag_l->vtag == vtag) { > + /* The client on bus has one fixed vtag map */ > + if ((cl->cldev && mei_cldev_enabled(cl->cldev)) || > + vtag_l->vtag == vtag) { > vtag_l->pending_read = false; > break; > } > -- > 2.39.0 > Acked-by: Greg Kroah-Hartman