From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C81AC433E6 for ; Wed, 10 Mar 2021 19:10:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF96764FAB for ; Wed, 10 Mar 2021 19:10:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF96764FAB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5B6586E2B6; Wed, 10 Mar 2021 19:10:43 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23FF06E2B6; Wed, 10 Mar 2021 19:10:42 +0000 (UTC) IronPort-SDR: jakf9GQLCQsEncvlFMGmL3k4VitlTHhRfnc1ke+6qJaEFrAFPOG4VL/fFLULQXr+JNll0e9glf 3ie64fbDPm3A== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="186165035" X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="186165035" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 11:10:40 -0800 IronPort-SDR: Btp3Itzl8w9KSNLASOiAc9XnDx8irfou9OPI54aCO7iGM8IZSZ2mJLl3D18Jd1dcOS1Tih4/ke DP0frKLl3dDg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="409209965" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga007.jf.intel.com with SMTP; 10 Mar 2021 11:10:38 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 10 Mar 2021 21:10:37 +0200 Date: Wed, 10 Mar 2021 21:10:37 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [RFC v1 4/6] drm/edid: use the new displayid iterator for detailed modes X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 09, 2021 at 03:54:12PM +0200, Jani Nikula wrote: > Neatly reduce displayid boilerplate in code. No functional changes. > = > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_edid.c | 23 ++++++----------------- > 1 file changed, 6 insertions(+), 17 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 58e61f792bc7..fbaa7d679cb2 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -5333,27 +5333,16 @@ static int add_displayid_detailed_1_modes(struct = drm_connector *connector, > static int add_displayid_detailed_modes(struct drm_connector *connector, > struct edid *edid) > { > - const u8 *displayid; > - int length, idx; > const struct displayid_block *block; > + struct displayid_iter iter; > int num_modes =3D 0; > - int ext_index =3D 0; > - > - for (;;) { > - displayid =3D drm_find_displayid_extension(edid, &length, &idx, > - &ext_index); > - if (!displayid) > - break; > = > - idx +=3D sizeof(struct displayid_hdr); > - for_each_displayid_db(displayid, block, idx, length) { > - switch (block->tag) { > - case DATA_BLOCK_TYPE_1_DETAILED_TIMING: > - num_modes +=3D add_displayid_detailed_1_modes(connector, block); > - break; > - } > - } > + displayid_iter_edid_begin(edid, &iter); > + displayid_iter_for_each(block, &iter) { > + if (block->tag =3D=3D DATA_BLOCK_TYPE_1_DETAILED_TIMING) > + num_modes +=3D add_displayid_detailed_1_modes(connector, block); > } > + displayid_iter_end(&iter); > = > return num_modes; > } > -- = > 2.20.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx