From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEEF6C433E0 for ; Wed, 10 Mar 2021 19:12:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6B79D64FAB for ; Wed, 10 Mar 2021 19:12:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B79D64FAB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5550B89D1D; Wed, 10 Mar 2021 19:12:33 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id C34E889CCB; Wed, 10 Mar 2021 19:12:31 +0000 (UTC) IronPort-SDR: UEaj4FXvBjV0F/tCh9reA3oewfaABI8pDNav1JdVUdP9z8fOryyF09L/Q9jHB3LAgB8IA1Oxmu 1x5lCKrBB0Dg== X-IronPort-AV: E=McAfee;i="6000,8403,9919"; a="175648512" X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="175648512" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Mar 2021 11:12:30 -0800 IronPort-SDR: HipzxYdw+gN21AwTQH3t+Ng6MKWD1GrE4t0kpDe9Vj6FXNA+TOtSRPrxBGtTz0nq/NG4HpuJ1z YEK5iUgf5JeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,238,1610438400"; d="scan'208";a="372057886" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by orsmga006.jf.intel.com with SMTP; 10 Mar 2021 11:12:28 -0800 Received: by stinkbox (sSMTP sendmail emulation); Wed, 10 Mar 2021 21:12:27 +0200 Date: Wed, 10 Mar 2021 21:12:27 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Message-ID: References: <8a527f66b856d6c099313046e028a18f9257baa8.1615297748.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a527f66b856d6c099313046e028a18f9257baa8.1615297748.git.jani.nikula@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [RFC v1 5/6] drm/edid: use the new displayid iterator for finding CEA extension X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Mar 09, 2021 at 03:54:13PM +0200, Jani Nikula wrote: > Neatly reduce displayid boilerplate in code. No functional changes. > = > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/drm_edid.c | 25 +++++++++---------------- > 1 file changed, 9 insertions(+), 16 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index fbaa7d679cb2..4526e2557dca 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -3266,35 +3266,28 @@ const u8 *drm_find_edid_extension(const struct ed= id *edid, > = > static const u8 *drm_find_cea_extension(const struct edid *edid) > { > - int length, idx; > const struct displayid_block *block; > + struct displayid_iter iter; > const u8 *cea; > - const u8 *displayid; > - int ext_index; > + int ext_index =3D 0; > = > /* Look for a top level CEA extension block */ > /* FIXME: make callers iterate through multiple CEA ext blocks? */ > - ext_index =3D 0; > cea =3D drm_find_edid_extension(edid, CEA_EXT, &ext_index); > if (cea) > return cea; > = > /* CEA blocks can also be found embedded in a DisplayID block */ > - ext_index =3D 0; > - for (;;) { > - displayid =3D drm_find_displayid_extension(edid, &length, &idx, > - &ext_index); > - if (!displayid) > - return NULL; > - > - idx +=3D sizeof(struct displayid_hdr); > - for_each_displayid_db(displayid, block, idx, length) { > - if (block->tag =3D=3D DATA_BLOCK_CTA) > - return (const u8 *)block; > + displayid_iter_edid_begin(edid, &iter); > + displayid_iter_for_each(block, &iter) { > + if (block->tag =3D=3D DATA_BLOCK_CTA) { > + cea =3D (const u8 *)block; > + break; > } > } > + displayid_iter_end(&iter); > = > - return NULL; > + return cea; > } > = > static __always_inline const struct drm_display_mode *cea_mode_for_vic(u= 8 vic) > -- = > 2.20.1 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx