From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 909FAC433B4 for ; Wed, 7 Apr 2021 14:34:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 539E061260 for ; Wed, 7 Apr 2021 14:34:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 539E061260 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC1816E91C; Wed, 7 Apr 2021 14:34:04 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C77BD6E91C for ; Wed, 7 Apr 2021 14:34:03 +0000 (UTC) IronPort-SDR: LfKZbkAlWg3QDuRKvTMvwyZZ5Wb/IrPZqyD4K6LC15MP2xVT75aoEAGCV8cl6UuaLTe+BSGjw8 D5ybaD96zwBA== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="191158805" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="191158805" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 07:34:03 -0700 IronPort-SDR: ldihhA/59HDnMc+e64owLkHua+A4oRtugQoCGxW98enhMXXiwJrmezE3a0GLXehmH+8+7ZuGfd 2hFWBlBWXItA== X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="448271910" Received: from ldmccree-mobl.amr.corp.intel.com (HELO intel.com) ([10.209.131.134]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 07:34:02 -0700 Date: Wed, 7 Apr 2021 10:34:02 -0400 From: Rodrigo Vivi To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jani Saarinen Message-ID: References: <30685BA7-1D02-48A0-9B7A-4933ED2B8F0D@canonical.com> <20200824180438.GI6112@intel.com> <010FB10D-B1EF-4C2E-A8AD-B7409E771BD0@canonical.com> <20200826130511.GN6112@intel.com> <432E1B70-7F52-4DF7-8887-0769F17DAD30@canonical.com> <20201013111532.GY6112@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201013111532.GY6112@intel.com> Subject: Re: [Intel-gfx] [Regression] "drm/i915: Implement display w/a #1143" breaks HDMI on ASUS GL552VW X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Runyan, Arthur J" , intel-gfx , Kai-Heng Feng Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 13, 2020 at 02:15:32PM +0300, Ville Syrj=E4l=E4 wrote: > On Tue, Oct 13, 2020 at 01:20:35PM +0800, Kai-Heng Feng wrote: > > = > > = > > > On Sep 3, 2020, at 14:26, Kai-Heng Feng = wrote: > > > = > > > = > > > = > > >> On Aug 26, 2020, at 21:05, Ville Syrj=E4l=E4 wrote: > > >> = > > >> On Wed, Aug 26, 2020 at 12:40:15PM +0800, Kai-Heng Feng wrote: > > >>> Hi, > > >>> = > > >>>> On Aug 25, 2020, at 02:46, Runyan, Arthur J wrote: > > >>>> = > > >>>> I remember some strangeness about the blnclegdisbl. I'll see if I= can dig up some more. > > >>> = > > >>> = > > >>> The register read can be found at [1] and [2]. > > >>> = > > >>> [1] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/co= mments/119 > > >>> [2] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/co= mments/120 > > >> = > > >> Looks like it's using the 400mV/0dB setting. Can we get the same dum= ps > > >> with the driver loaded just to confirm whether we're using different > > >> settings? = > > >> = > > >> Also a dump of /sys/kernel/debug/dri/0/i915_vbt would be good > > >> to have. > > > = > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/comments= /124 > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/comments= /125 > > > https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/comments= /126 > > = > > A gentle ping... > = > I cooked up some hacks for you to try: > git://github.com/vsyrjala/linux.git skl_vswing_wa_hacks > = > An upstream bug report would probably be a good idea so that the > communication doesn't have to go through a middle man over email... any update on this? Cc: Jani > = > > = > > > = > > > Kai-Heng > > > = > > >> = > > >>> = > > >>> Kai-Heng > > >>> = > > >>>> = > > >>>> -----Original Message----- > > >>>> From: Ville Syrj=E4l=E4 = > > >>>> Sent: Monday, August 24, 2020 11:05 AM > > >>>> To: Kai-Heng Feng > > >>>> Cc: Runyan, Arthur J ; Vivi, Rodrigo ; intel-gfx > > >>>> Subject: Re: [Regression] "drm/i915: Implement display w/a #1143" = breaks HDMI on ASUS GL552VW > > >>>> = > > >>>> On Mon, Aug 17, 2020 at 02:17:49PM +0800, Kai-Heng Feng wrote: > > >>>>> = > > >>>>> = > > >>>>>> On Aug 17, 2020, at 00:22, Runyan, Arthur J wrote: > > >>>>>> = > > >>>>>> You'll need to read out the DDI_BUF_TRANS_* and DISPIO_CR_TX_BMU= _CR0 registers at boot before i915 programs them and compare with what driv= er programs. = > > >>>>>> Rodrigo can probably show you how. = > > >>>>> = > > >>>>> Right, I'll wait for a patch then :) > > >>>> = > > >>>> To grab the BIOS reg values we just have to make sure the driver d= oesn't load. Eg. pass something like "modprobe.blacklist=3Di915,snd_hda_int= el 3" to the kernel cmdline (+ whatever other magic ubuntu might require). = Confirm with something like "lsmod | grep i915" to make sure the driver did= n't sneak in despite our best efforts. > > >>>> = > > >>>> Then we can dump the registers with intel_reg from igt-gpu-tools: > > >>>> intel_reg read --count 20 0x64E00 0x64E60 0x64EC0 0x64F20 0x64F80 = intel_reg read 0x64000 0x64100 0x64200 0x64300 0x64400 0x6C00C > > >>>> = > > >>>> The only somewhat suspicious thing I noticed is that we treat DISP= IO_CR_TX_BMU_CR0:tx_blnclegdisbl as a bitmask (bit 23 -> DDI A, bit 24 -> D= DI B, etc.) whereas the spec seems to be saying that we should just zero ou= t all the bits of tx_blnclegdisbl when any DDI needs iboost. Art, is our in= terpretation of the bits correct or just a fairy tale? > > >>>> = > > >>>>> = > > >>>>> Kai-Heng > > >>>>> = > > >>>>>> = > > >>>>>> -----Original Message----- > > >>>>>> From: Kai-Heng Feng > > >>>>>> Sent: Thursday, August 13, 2020 10:14 PM > > >>>>>> To: Runyan, Arthur J > > >>>>>> Cc: Vivi, Rodrigo ; Ville Syrj=E4l=E4 = > > >>>>>> ; intel-gfx = > > >>>>>> > > >>>>>> Subject: Re: [Regression] "drm/i915: Implement display w/a #1143= " = > > >>>>>> breaks HDMI on ASUS GL552VW > > >>>>>> = > > >>>>>> Hi, > > >>>>>> = > > >>>>>>> On Aug 14, 2020, at 01:56, Runyan, Arthur J wrote: > > >>>>>>> = > > >>>>>>> The workaround is freeing up stuck vswing values to let new vsw= ing programming kick in. Maybe the new vswing values are wrong. > > >>>>>>> Try checking the vswing that driver programs against what BIOS/= GOP programs. > > >>>>>> = > > >>>>>> Do you mean to print out value of I915_READ()? > > >>>>>> val =3D I915_READ(CHICKEN_TRANS(transcoder)); > > >>>>>> = > > >>>>>> Kai-Heng > > >>>>>> = > > >>>>>>> = > > >>>>>>> -----Original Message----- > > >>>>>>> From: Vivi, Rodrigo > > >>>>>>> Sent: Thursday, August 13, 2020 9:50 AM > > >>>>>>> To: Kai-Heng Feng ; Runyan, Arthur= J = > > >>>>>>> > > >>>>>>> Cc: Ville Syrj=E4l=E4 ; intel-gf= x = > > >>>>>>> > > >>>>>>> Subject: Re: [Regression] "drm/i915: Implement display w/a #114= 3" = > > >>>>>>> breaks HDMI on ASUS GL552VW > > >>>>>>> = > > >>>>>>> Art, any comment here? > > >>>>>>> = > > >>>>>>> I just checked and the W/a 1143 is implemented as described, b= ut it is failing HDMI on this hybrid system. > > >>>>>>> = > > >>>>>>>> On Aug 12, 2020, at 9:07 PM, Kai-Heng Feng wrote: > > >>>>>>>> = > > >>>>>>>> Hi, > > >>>>>>>> = > > >>>>>>>> There's a regression reported that HDMI output stops working a= fter os upgrade: > > >>>>>>>> https://bugs.launchpad.net/bugs/1871721 > > >>>>>>>> = > > >>>>>>>> Here's the bisect result: > > >>>>>>>> 0519c102f5285476d7868a387bdb6c58385e4074 is the first bad comm= it = > > >>>>>>>> commit 0519c102f5285476d7868a387bdb6c58385e4074 > > >>>>>>>> Author: Ville Syrj=E4l=E4 > > >>>>>>>> Date: Mon Jan 22 19:41:31 2018 +0200 > > >>>>>>>> = > > >>>>>>>> drm/i915: Implement display w/a #1143 > > >>>>>>>> = > > >>>>>>>> Apparently SKL/KBL/CFL need some manual help to get the = > > >>>>>>>> programmed HDMI vswing to stick. Implement the relevant = > > >>>>>>>> workaround (display w/a #1143). > > >>>>>>>> = > > >>>>>>>> Note that the relevant chicken bits live in a transcoder regis= ter = > > >>>>>>>> even though the bits affect a specific DDI port rather than a = > > >>>>>>>> specific transcoder. Hence we must pick the correct transcoder= = > > >>>>>>>> register instance based on the port rather than based on the = > > >>>>>>>> cpu_transcoder. > > >>>>>>>> = > > >>>>>>>> Also note that for completeness I included support for DDI A/E= = > > >>>>>>>> in the code even though we never have HDMI on those ports. > > >>>>>>>> = > > >>>>>>>> v2: CFL needs the w/a as well (Rodrigo and Art) > > >>>>>>>> = > > >>>>>>>> Cc: Rodrigo Vivi > > >>>>>>>> Cc: Art Runyan > > >>>>>>>> Signed-off-by: Ville Syrj=E4l=E4 > > >>>>>>>> Link: = > > >>>>>>>> https://patchwork.freedesktop.org/patch/msgid/20180122174131.2= 8046 > > >>>>>>>> -1-ville.syrjala@linux.intel.com > > >>>>>>>> Reviewed-by: Rodrigo Vivi > > >>>>>>>> = > > >>>>>>>> = > > >>>>>>>> dmesg from drm-tip with drm.debug=3D0xe can be found here: > > >>>>>>>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1871721/c= omme > > >>>>>>>> nts > > >>>>>>>> / > > >>>>>>>> 64 > > >>>>>>>> = > > >>>>>>>> Kai-Heng > > >>>>>>> = > > >>>>>>> = > > >>>>>> = > > >>>> = > > >>>> -- > > >>>> Ville Syrj=E4l=E4 > > >>>> Intel > > >> = > > >> -- = > > >> Ville Syrj=E4l=E4 > > >> Intel > > > = > = > -- = > Ville Syrj=E4l=E4 > Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx