From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD225C433ED for ; Thu, 29 Apr 2021 12:16:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3FB6961449 for ; Thu, 29 Apr 2021 12:16:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FB6961449 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E03E6EE82; Thu, 29 Apr 2021 12:16:10 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C40B6EE82 for ; Thu, 29 Apr 2021 12:16:09 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id 82-20020a1c01550000b0290142562ff7c9so6563750wmb.3 for ; Thu, 29 Apr 2021 05:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=t/3lBFugAZfPxScEd0M7U4gV+okH/cRVvr29rWLjXr8=; b=QJp3t4N0dhhh0UAq3eMbh6LhjilqWhpaDDlheFXK6lw472UxonVcST8/8meK5ZnrfP ophyMwrl06cAF27hbSf9zFTEzg4sfWe7AK1wVGpDBZXyqcuPLcocWFnA/8Qxs27bekIJ S7+DMDXny29W3vwgtoWWPaWNnq3+Sd2gRwMD8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=t/3lBFugAZfPxScEd0M7U4gV+okH/cRVvr29rWLjXr8=; b=T7Z5ahNc3gASQlavuYAOXfnE5E2Y0ak/ioIp5zPkZXMMBz6EXu3FJSh0wYSTqwToGS eP8Zj4j+ohzS6Ezy9i6oD9EhYYi7WczQLH1LfeTBYHxth96emz8NTp6Rt8TRGQ+oyGWH ScKroSfYAZzFxEk13a2ECvDX1Xw/xgsvFPYfEfq0FBZ7mxolmpZO8oE6dvxlZOvR9tSq vu42qLnvk9zUEGUYdWxlKetUWoKszbxanx93ZbAco2JdPyGrvNZXZqY0K7m2UFk3dRSr qiM5lTWhQmP57e2o+9rZJ4TuZJhPwYlG6gNNwvJeXc+p6gGRTjzxrGkrL0WmCAYJvLos vnVg== X-Gm-Message-State: AOAM531hGuGcK135oBfgoYjGS6MwbOnCN6abOyQ2uWcukr2IDpEFnytG kw5T9oppxt0UHiP3t+QYlNduuQ== X-Google-Smtp-Source: ABdhPJz+mfmrJ2AnYQzj8rOscVaWD6P8zUhLl/2gpnFkHf/Ml/3YHL9t3o41liu0S13zHMYzJNgong== X-Received: by 2002:a05:600c:2298:: with SMTP id 24mr12305235wmf.167.1619698568093; Thu, 29 Apr 2021 05:16:08 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id p5sm3598645wma.45.2021.04.29.05.16.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Apr 2021 05:16:07 -0700 (PDT) Date: Thu, 29 Apr 2021 14:16:05 +0200 From: Daniel Vetter To: Jason Ekstrand Message-ID: References: <20210423223131.879208-1-jason@jlekstrand.net> <20210423223131.879208-9-jason@jlekstrand.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.32scarlett+ Subject: Re: [Intel-gfx] [PATCH 08/21] drm/i915/gem: Disallow bonding of virtual engines X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel GFX , Maling list - DRI developers Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Apr 28, 2021 at 01:58:17PM -0500, Jason Ekstrand wrote: > On Wed, Apr 28, 2021 at 12:18 PM Jason Ekstrand wrote: > > > > On Wed, Apr 28, 2021 at 5:13 AM Daniel Vetter wrote: > > > > > > On Tue, Apr 27, 2021 at 08:51:08AM -0500, Jason Ekstrand wrote: > > > > I sent a v2 of this patch because it turns out I deleted a bit too > > > > much code. This function in particular, has to stay, unfortunately. > > > > When a batch is submitted with a SUBMIT_FENCE, this is used to push > > > > the work onto a different engine than than the one it's supposed to > > > > run in parallel with. This means we can't dead-code this function or > > > > the bond_execution function pointer and related stuff. > > > > > > Uh that's disappointing, since if I understand your point correctly, the > > > sibling engines should all be singletons, not load balancing virtual ones. > > > So there really should not be any need to pick the right one at execution > > > time. > > > > The media driver itself seems to work fine if I delete all the code. > > It's just an IGT testcase that blows up. I'll do more digging to see > > if I can better isolate why. > > I did more digging and I figured out why this test hangs. The test > looks at an engine class where there's more than one of that class > (currently only vcs) and creates a context where engine[0] is all of > the engines of that class bonded together and engine[1-N] is each of > those engines individually. It then tests that you can submit a batch > to one of the individual engines and then submit with > EXEC_FENCE_SUBMIT to the balanced engine and the kernel will sort it > out. This doesn't seem like a use-case we care about. > > If we cared about anything, I would expect it to be submitting to two > balanced contexts and expecting "pick any two" behavior. But that's > not what the test is testing for. Yeah ditch it. Instead make sure that the bonded setparam/ctx validation makes sure that 1) no virtual engines are used 2) no engine used twice 3) anything else stupid you can come up with that we should make sure is blocked. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx